Received-SPF: pass (google.com: domain of linux-kernel+bounces-195050-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <c936db6e-58cd-4445-92a2-9d53ba7f6b8c@axis.com>
Date: Thu, 30 May 2024 10:18:08 +0200
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 1/2] dt-bindings: hwmon: ti,ina2xx: Add alert-polarity
 property
To: Guenter Roeck <linux@roeck-us.net>, Krzysztof Kozlowski
 <krzk@kernel.org>, Jean Delvare <jdelvare@suse.com>,
 Rob Herring <robh@kernel.org>, Krzysztof Kozlowski <krzk+dt@kernel.org>,
 Conor Dooley <conor+dt@kernel.org>
Cc: linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
 linux-kernel@vger.kernel.org, kernel@axis.com
References: <20240529-apol-ina2xx-fix-v1-0-77b4b382190f@axis.com>
 <20240529-apol-ina2xx-fix-v1-1-77b4b382190f@axis.com>
 <1ae97b90-ff20-4238-abe2-f2e5d87fc344@kernel.org>
 <76dd5c0e-cc67-4ad1-8733-d8efdb8a172b@roeck-us.net>
Content-Language: en-US
From: Amna Waseem <Amna.Waseem@axis.com>
In-Reply-To: <76dd5c0e-cc67-4ad1-8733-d8efdb8a172b@roeck-us.net>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?OEhmNXUzWjNVREViQ0RaVU4wdXdFTG9FNVFBWVQyWStnVUEzaDJhbWYrdDhj?=
 =?utf-8?B?R0R2YWlOWlF2RnV4cG01eWo3VUZrVFVvMmZFc09sSWd3SnBYU3VqczBmOC9a?=
 =?utf-8?B?L0JJdWxYMjhrWTNnYUQ2elplMFB5WWJFOCtoOWJJRi9iRWNxRFhEYjJqdUxE?=
 =?utf-8?B?amR6V0c4amx4SHY1VnJXL0Q2SlhDOEdjSWk3RjhKWXhKaG1JQ2JGbmtxblhY?=
 =?utf-8?B?VWZYZjZXajNDZk5ZWmpoeXRxRUV4VHU5Rm82d2lDSkU4bHcwY3dOWXc3TFVi?=
 =?utf-8?B?b1RyL0pDUWFleFFRUnhEZmtnZXVXck53T0ZWUnFPWkIvc2VxVkkvSFBXNkpO?=
 =?utf-8?B?TXBxTXQvTVVVcVlvSGRIWDJSRm1Sbm8yOEVraGZqOHI4RFpKOUlid0txTlBt?=
 =?utf-8?B?TEUzSUIrZXc2OWFCWDF0OWVHMmJ6RlVWc3lhVEZKNWEvbWViQjN1L3FCWHVD?=
 =?utf-8?B?TjV5amgweGNDUmVGam1SMDJNZ0lrQmxRTGR5Q1JiTkk0S2pHZUpKYzNhaVRh?=
 =?utf-8?B?cW1yK2MzaXlaV3B1MnJSVk9LOVJqMUsrWHBCK2dtbTJWTUczUnlhMDlXZzha?=
 =?utf-8?B?QkR6UGFZQ3Y2WVVFZkNvemt3cnhiL0NCZXF5dzMxd2xLNktWTUkzL1Q0TXNF?=
 =?utf-8?B?VEZ2ZTZnN2EwemFNR2lCK3FaOVA2T1pUV3dYMXFXNVZ6SGtpREY4SCtvbU9C?=
 =?utf-8?B?ZVZtak45WTkzMzVuRG9lZmJhaUpwek52dDBYNk9JaDAzQ2VaTmhzOHA1ZWZF?=
 =?utf-8?B?dnd3anZKaUwvdGlGanJJMDdNWnE5TXdqU0Z4SHVDakErdzQrZnZ6aHo4S2dV?=
 =?utf-8?B?VkVjdUJxcHdnYk1JdjFlaC9yR1FmRkFCN0paRjAvYlF6UFBXQzhjS2pWbUFn?=
 =?utf-8?B?clo5dEJ2ZUxOTUt4SlY4dFZETFZPa1hkS1Rrb2hCdFgrck5EN0wxREpub2RU?=
 =?utf-8?B?V1VQVHVESndxaG9JTjBRNVFPNUNMYk9SWDhMakVkR0hKeFRJUllGWlc0eUVN?=
 =?utf-8?B?T3Z3NFRWbUdFMlUxTzZOOEQreVI0NDcxOE5PZ0hqdVRVVWVsYms3dFJaeXpJ?=
 =?utf-8?B?RnRKMmJiWlVhdXZrbU5PcWhIY3EwWFNLTDdyQUNmd3FLbGxMUUFic1RoWVdR?=
 =?utf-8?B?VVZKWi9FQ1BiS3N4Vjc0MnBNVEtSQ0RObnUwdTB1LzJsc0hSZTBRb2tabS92?=
 =?utf-8?B?djlUQUU0RDFIVFZ1WTA0L3dnU1o1ZXpIdEVOZ0VXdEtNaU9yYzRWdmJ1UVpK?=
 =?utf-8?B?VzlxY1lhQ1Zqcm5tb1A4cktoMWFwczRtelNuSlBDS1FPUjVMUFNubDRnaDJZ?=
 =?utf-8?B?TlJiZDV3VnJmQThZV2dBcjkrWjlveDI0MCtEckdqdmIrV0xoS1dBam1meUg0?=
 =?utf-8?B?Ynk4YWMrY1V4WkF1QTIvaXE0QWJlY1NPUVIxUWozbkpoSVR0MWpiQ05naVB0?=
 =?utf-8?B?WUNTNkUvSGNPNm10OGY0cE11dlpHT3F6MElya3UrQjY3NFlBSk01WlhZTHBJ?=
 =?utf-8?B?NHNkQUdpT1l4d3ZTcFo1UGxCU3J4SVIvVG5XQS9uWEo4UDJZeVpaaU83UUdz?=
 =?utf-8?B?TVB3bDVpb3lrZ21MYjR1SnhWRFQrMTA5VFBqdjJTOWN6NEpidlYwWm5hTVA2?=
 =?utf-8?B?STBLMWxqSU5qSkNuYlUrMXZ2anRRd1dyajRkb0I1MjFaSWxhQmEyZFR3eDBw?=
 =?utf-8?B?MjkxY1JET21wMXUrRmpKOUQ3MGFYOURZdE9veGJhL2xleDEzTE9nbDBVL2pJ?=
 =?utf-8?B?aXp6dVJuaGd5VE9TS0pTamZocUZrcWgyN1Bvc3djSDFLRzJ1bVRoY3FHKzIz?=
 =?utf-8?B?MTJNb0RNM1NGTWNGZkllamNBcXd6d25zdUJPNExqekUzY1RkN2V0RTh6cUEw?=
 =?utf-8?B?Z1pNTlZHSUlrdE1oUE9KVlV1L3FES0gxeVJjUUxVZEJHeVlxSmQ1ZThKRDhy?=
 =?utf-8?B?aUwvb0ZDRjYvdjFzOGxIN0xnUFhhbUo4WTdzOUN2VEtSMmo5VzA5NkFWeGNX?=
 =?utf-8?B?S0gyU3RuYnBCOXdnd3FWYWJYdDROVFg5RHIxZlI2WFNMOXo0MGxJQUp0WDE0?=
 =?utf-8?B?OG1nME04NDZZMUpiMGRHVERnUkwvMXNxUUdwSmZQWHBwVy96VSswNzIwSFdi?=
 =?utf-8?Q?003Q=3D?=
X-OriginatorOrg: axis.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e25eb5b6-bd9d-4419-45e0-08dc80810b1d
X-MS-Exchange-CrossTenant-AuthSource: DB9PR02MB9994.eurprd02.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 May 2024 08:18:10.6282
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 78703d3c-b907-432f-b066-88f7af9ca3af
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: AZuPRv75VxEDgF6xqQdVYHQCDwNQ44RF9kOsYo03eLhp+ygqitVEJHZpNI6VMT8p
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR02MB6109

On 5/29/24 16:01, Guenter Roeck wrote:
> On 5/29/24 00:07, Krzysztof Kozlowski wrote:
>> On 29/05/2024 08:07, Amna Waseem wrote:
>>> Add a property to the binding to configure the Alert Polarity.
>>> Alert pin is asserted based on the value of Alert Polarity bit of
>>> Mask/Enable register. It is by default 0 which means Alert pin is
>>> configured to be active low. To configure it to active high, set
>>> alert-polarity property value to 1.
>>>
>>> Signed-off-by: Amna Waseem <Amna.Waseem@axis.com>
>>> ---
>>>   Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml | 9 +++++++++
>>>   1 file changed, 9 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml 
>>> b/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml
>>> index df86c2c92037..a3f0fd71fcc6 100644
>>> --- a/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml
>>> +++ b/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml
>>> @@ -66,6 +66,14 @@ properties:
>>>       description: phandle to the regulator that provides the VS 
>>> supply typically
>>>         in range from 2.7 V to 5.5 V.
>>>   +  alert-polarity:
>>
>> Missing vendor prefix.
>>
>
> Are you sure you want a vendor prefix here ? Reason for asking is that
> many hardware monitoring chips have configurable alert or interrupt 
> polarity,
> only the name is different. Some examples are the JC42.4 standard ("event
> polarity"), adt7410/adt7420 "interrupt polarity", MAX31827 ("alarm 
> polarity"),
> or DS1621 ("output polarity"). We even have a vendor property, 
> "adi,alarm-pol",
> used for MAX31827.
>
> Secondary problem is that not all chips of the series support this
> configuration. INA209 has a configurable "warning polarity", but the
> warning pin and the smbus alert pin are two different pins.
> INA219 and INA220 do not have alert or interrupt output pins.
> Only INA226, INA230, INA231, INA238, and INA260 support configurable
> alert polarity.
>
> Thanks,
> Guenter

I agree with not using vendor prefix with alert-polarity property. 
@Krzysztof Kozlowski what do you suggest?

Amna

>>> +    description: |
>>
>> Do not need '|' unless you need to preserve formatting.
>>
>>> +      Alert polarity bit value of Mask/Enable register. Alert pin 
>>> is asserted
>>> +      based on the value of Alert polarity Bit. Default value is 
>>> active low.
>>> +      0 selects active low, 1 selects active high.
>>
>> Just use string, easier to read. But for sure do not introduce different
>> values than we already have - GPIO HIGH is 0, not 1.
>>
>>
>>
>> Best regards,
>> Krzysztof
>>
>