Received-SPF: pass (google.com: domain of linux-kernel+bounces-195094-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <fdc3bffa-7149-48a4-949a-dd469c6c2726@amd.com>
Date: Thu, 30 May 2024 14:22:04 +0530
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 1/1] iommu: Make iommu_sva_domain_alloc() static
To: Lu Baolu <baolu.lu@linux.intel.com>, Joerg Roedel <joro@8bytes.org>,
 Will Deacon <will@kernel.org>, Robin Murphy <robin.murphy@arm.com>,
 Jason Gunthorpe <jgg@ziepe.ca>, Kevin Tian <kevin.tian@intel.com>,
 Jean-Philippe Brucker <jean-philippe@linaro.org>
Cc: iommu@lists.linux.dev, linux-kernel@vger.kernel.org
References: <20240528045458.81458-1-baolu.lu@linux.intel.com>
Content-Language: en-US
From: Vasant Hegde <vasant.hegde@amd.com>
In-Reply-To: <20240528045458.81458-1-baolu.lu@linux.intel.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?QmRlbUNXZjByTDYwZ0xFdlJ1bk9rNXU0WXNiSkF2bUxJSVNkakZpSFpicUJ1?=
 =?utf-8?B?eVIvc1ZQcGM1YXdXSTI3M2pXQWdFNEdTNzM2cWZGVUhJWFQ4RjdqWkc5SVZu?=
 =?utf-8?B?U09PazlvS1VDV1dDWkkvcERYOFJ6ZmJaTE5PR2VsdXBsTno0T3BKNFFxOGw0?=
 =?utf-8?B?L2cycjdXWEl0TlN3VDhlNno1YmVjRERicXBZUXN0VnVCOXBLcnVYRUdwSnQ5?=
 =?utf-8?B?eGNUcE5ibHlFOEVKbTFjaUFib1NjN0NabUlIK2kwR0E5d0RtTUJWVVNSS0dT?=
 =?utf-8?B?ek1EbDJZRm9UL0ZManN3NHYrQS9sNTd3N1dMbFJmS0FnNkRCMEpjekVHSlVx?=
 =?utf-8?B?MHl1YzhzRFNDZWpkbEUrVkxpMHNWLzJhSHlXaWk2SFMzRmtzeUNUNGEvSVdt?=
 =?utf-8?B?eEp2OENtTXZIektqeDJBeEpWOUc3VDFzUzJlakpYVUt6bnRibE9NdVBDR0dY?=
 =?utf-8?B?QnpjdUUvMzEzckYwMElXSDNVQUdRK3NBazhFQzFZaHB3U004SG1QRXo3bDYr?=
 =?utf-8?B?Sk5mMW1abTFlZlgrN3FTbGFZTHMxNGVxMFZyMGFyNkc2L3RWTlFrK2c3OEts?=
 =?utf-8?B?ZWdFcWdUUDE0TDZ4b2sxNUlVZ0FURlJEVlJzYUVDK2JoL2hHZ2dQZm94RnFT?=
 =?utf-8?B?QzFxd2g1WDI0MUV6WjJ1VkxOVEJOR0dQbGl3cXI1RHZXTUs0c2lrSjJZS2tC?=
 =?utf-8?B?Q0dXMnJZVVd0Wm82ZXhLTktMejUyZzFodXVwbi95M0w3Z1FvSUxDbWtYc2hz?=
 =?utf-8?B?NENmS3V2cGtKUjFhRDZQRTFRZnVaOHRleGVkcld1eFBzR1RETnFUOE9mZDF3?=
 =?utf-8?B?dkpCMmY3Q1RFTmxPL0pXLy9mNmV2Rkw5bStWREE0MTNWZUYvdnJHdzhGYkhk?=
 =?utf-8?B?S1NkOVBWdk9HeklCWXNUbjdWdWFleW9vb3k3czhZYktuTlB0OU1MN3JhS21B?=
 =?utf-8?B?VXo3SytyQnQ4UGdhRnZRNHlWdjRiTVhxeE1vSytvNmQwUWw2RlB3T2ZCRFJx?=
 =?utf-8?B?cytBUU5mLzh4Q1VNNURqZVUrMTUwUnZpM0o2STFqUWtGSkE1cXZYenFBQTJZ?=
 =?utf-8?B?U2dRd2lGZzc2djQwalp1Z3VqNVFHN3NWN3IxYmxTRDFQRjFqeDVOVjFSWUZo?=
 =?utf-8?B?MFZPRGg1cUs5U2ZPVS9WaEZxdnd6cW1BSEZFTkRCUnZmT2ZLWk9jc2ltakVT?=
 =?utf-8?B?K1o2R3ZGTjNSTURvN2pNTFZhT2dYNHE3YVBaNlJqaEJEUWcwSlZRbThPM2M1?=
 =?utf-8?B?OVVxTHZnQ1ZXNFNWV0QveTFmRXNBdnBIakJabFBWR0JGWlZwL3MydUZwVit5?=
 =?utf-8?B?Um1sRlVaWlRVWU8rQThSam9zcWF0NlV3TWJKeUNOV0NEd3dRbnRZV1BQNXNW?=
 =?utf-8?B?VGpadXg3b3FSeGZyaTlFRS9IS240RmlPMGJSZFVQbzdEVUNneXZYMFJ0VUlo?=
 =?utf-8?B?YzZHRmozbWVVU3dBN2Q0UllZeW1CbnpocmxmZ1A1WkMxZk14aW4xaGc5a1Fq?=
 =?utf-8?B?M1F6S3dleEdPOGpxNjJaQWVQenQveXE2ckFlRzU2UnVxOEZPVXBreUx6bUdY?=
 =?utf-8?B?SkNsVjdreFpKYjF1UEQ4S3FFZUZpOURDQUdMdnVoNStZZFlveG9RZTNmbUM0?=
 =?utf-8?B?TURxaGZISkl1NTF4cDhoM3RvYmNmWjlaN2Y2OEUzbmZMZzFWTUM2STJPWXBE?=
 =?utf-8?B?TkxaYUZTUG5reThBK004VnFLRHJtREpxTitXZmhvUHV3QWxlbDJudDc5aWFs?=
 =?utf-8?B?ejNDQ1lCUUdESURYUFhWd2lHcWZLWmNodzBqYXkrbmltYnJLS1Z6OVBFR2Rh?=
 =?utf-8?B?Y256Z3Q4cWd3TkhBYWE0NHgzY09odEIyV25obzRUbGE1Wi9FQXRKYWp0cHZG?=
 =?utf-8?B?Y1VkTkFDVFdSaDFxZFJiaHpXZnVCZzlSYzBIYjVMdCtoR2NUdzZiL1AxcGxi?=
 =?utf-8?B?RXFQRTlFRWlRbTFheFVQK2VDTENhR2RWSzB5WHNqRW5LTENBeFNCMDN0RHh1?=
 =?utf-8?B?eHlrZlZiUUV6OFgzQy91dTdUVzVVaWdleWxsNmd6ZlZOY1Q5Z01NWGQ4eVN5?=
 =?utf-8?B?Y0J0bUd2ZXh1eHM0UWFiWHNTTTRGRTBsTk5VaWo4bHJCc0Z6ZDJrQ214KzdI?=
 =?utf-8?Q?f3TqlPjmsLf7h6mA/TXdUVrU/?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c3da0f2d-4d17-4af9-b650-08dc8085cd14
X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB6048.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 May 2024 08:52:14.2963
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: p+kgoNGQihtWsjyx33ROxng//QfzecTK/twSJXSJrPYXwz1NMKRGO0HvjoWQ99QElSOBI2vPx0mZYydvZ8pwOw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR12MB6432

Hi Lu,

On 5/28/2024 10:24 AM, Lu Baolu wrote:
> iommu_sva_domain_alloc() is only called in iommu-sva.c, hence make it
> static.
> 
> On the other hand, iommu_sva_domain_alloc() should not return NULL anymore
> after commit <80af5a452024> ("iommu: Add ops->domain_alloc_sva()"), the
> removal of inline code avoids potential confusion.
> 
> Fixes: 80af5a452024 ("iommu: Add ops->domain_alloc_sva()")
> Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>
> ---
>  include/linux/iommu.h     | 8 --------
>  drivers/iommu/iommu-sva.c | 6 ++++--
>  2 files changed, 4 insertions(+), 10 deletions(-)
> 
> diff --git a/include/linux/iommu.h b/include/linux/iommu.h
> index 7bc8dff7cf6d..5cdd3d41b87b 100644
> --- a/include/linux/iommu.h
> +++ b/include/linux/iommu.h
> @@ -1527,8 +1527,6 @@ struct iommu_sva *iommu_sva_bind_device(struct device *dev,
>  					struct mm_struct *mm);
>  void iommu_sva_unbind_device(struct iommu_sva *handle);
>  u32 iommu_sva_get_pasid(struct iommu_sva *handle);
> -struct iommu_domain *iommu_sva_domain_alloc(struct device *dev,
> -					    struct mm_struct *mm);
>  #else
>  static inline struct iommu_sva *
>  iommu_sva_bind_device(struct device *dev, struct mm_struct *mm)
> @@ -1553,12 +1551,6 @@ static inline u32 mm_get_enqcmd_pasid(struct mm_struct *mm)
>  }
>  
>  static inline void mm_pasid_drop(struct mm_struct *mm) {}
> -
> -static inline struct iommu_domain *
> -iommu_sva_domain_alloc(struct device *dev, struct mm_struct *mm)
> -{
> -	return NULL;
> -}
>  #endif /* CONFIG_IOMMU_SVA */
>  
>  #ifdef CONFIG_IOMMU_IOPF
> diff --git a/drivers/iommu/iommu-sva.c b/drivers/iommu/iommu-sva.c
> index 18a35e798b72..25e581299226 100644
> --- a/drivers/iommu/iommu-sva.c
> +++ b/drivers/iommu/iommu-sva.c
> @@ -10,6 +10,8 @@
>  #include "iommu-priv.h"
>  
>  static DEFINE_MUTEX(iommu_sva_lock);
> +static struct iommu_domain *iommu_sva_domain_alloc(struct device *dev,
> +						   struct mm_struct *mm);

If we move move iommu_sva_domain_alloc() before iommu_sva_bind_device() then we
can avoid this forward declaration.

-Vasant