Received: by 2002:a05:6500:1b8f:b0:1fa:5c73:8e2d with SMTP id df15csp1159938lqb; Thu, 30 May 2024 01:57:14 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCX/HNgIstAya+KAIMiSWKi8e63Bg9PE4wiqRET2mnmFp136fC65hCyCMdaFY5wI1GxgWcTTfs6Y8jejrzWksyIr/hYD61jKLoq9eD7Low== X-Google-Smtp-Source: AGHT+IG73R3HqhJAeKH4y4/H/502hPlAix7Y6ySbjOnXWXSGn1xLRvKoFp9J9erFyF9Mb4q0Seyo X-Received: by 2002:a17:90b:8d7:b0:2c0:747:6bb with SMTP id 98e67ed59e1d1-2c1acc7e27dmr1837534a91.23.1717059433916; Thu, 30 May 2024 01:57:13 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1717059433; cv=pass; d=google.com; s=arc-20160816; b=nw/2vPsr/1hQNMvCpFuMiDEtYJZTTKQboXF6ymsWX0eJ2Zcqket7ygULNasTLYnZO9 /mnZNHfzNjwIn944fU2wDQtlS36O1dnUqlnyC/K/cuXx40/W96lbMHtIyLW8npwb/nAM /Ll6VSZ3Ibvlz4hmKg2AQEvdKYa3V9pxp9NfJ8K9V50f71ITcTIZh055NszPPMrs5EtY 6YZ6jHsbHJI5sCcnh8+9cemavi8kLph3+UWW4ygiOVa/T5G2Gex4/Ehy+Xi2ZjPE5qXK E/xNzILA1neDEBGNjndv0UrxP6UgVOh90PnBmWSZu+0pF0kjwwVCgYbWysECe21fj1TN eKog== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:list-unsubscribe:list-subscribe:list-id:precedence :user-agent:content-transfer-encoding:autocrypt:references :in-reply-to:date:cc:to:from:subject:message-id:dkim-signature; bh=wp9dT8wMnCyOCgEUiVZrNKqa8UOFLDrwjHbCmADMGTw=; fh=zSN+Gu8AntiKlDc9g8C3775kA5b2bCYNvUiUncqdLk4=; b=GLSIQtApnWQ1YWTd35UW6kB+gAwncXznbME86SC1ztRMS+2tn0NZoZNd305cEnoO/t +CBX7ntStOLBFXpJAutTY/9azzJbCGTAyPaSEzebJFNBIh3XS9UysxCeHtj8jvyEST4R 9rJ8nr/TK4A1Zofb9OuJa6PomrNjTLHkZspwBZoegOtQ8zZTnorrQMPpD205StQMM0s6 8IR74vkTuvqZjTvLiB8LNH/T8QZ0gXl1Ku10TRL6ez8/aClJ+WSAM0kimU9EBpk11tEe /AeDN2KnIp0GPRvrEV3h2bo7I+Ay3BA4ua6vKRGqIrkOY3mCxCJn7aLXWjqSmYoXleeI Bvyw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=LgVmunu4; arc=pass (i=1 spf=pass spfdomain=redhat.com dkim=pass dkdomain=redhat.com dmarc=pass fromdomain=redhat.com); spf=pass (google.com: domain of linux-kernel+bounces-195101-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-195101-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id 98e67ed59e1d1-2c1a777aeebsi1221713a91.42.2024.05.30.01.57.13 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 May 2024 01:57:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-195101-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=LgVmunu4; arc=pass (i=1 spf=pass spfdomain=redhat.com dkim=pass dkdomain=redhat.com dmarc=pass fromdomain=redhat.com); spf=pass (google.com: domain of linux-kernel+bounces-195101-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-195101-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id EB373283641 for ; Thu, 30 May 2024 08:57:07 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id AEE40176AA7; Thu, 30 May 2024 08:56:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="LgVmunu4" Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 292316F31F for ; Thu, 30 May 2024 08:56:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717059390; cv=none; b=BqwtBX6OpYNrBVt3u30JzKOAaAFeVHWMLo4qxUl7NJrwDkFnJGs17UjqdPnTtq6R6eZsuvscbHK6jEXNRCogPoLUvWOlMKCLdVkRgaVHtYGBfusvjN/yzxZk56wcR23T83VYNxqFFtxinM2940VmBLaTvenc5dfrrVyVRu2ctDs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717059390; c=relaxed/simple; bh=7MIEsx3viVzGK+9Ye/pP9NjKqSOEzFj4nY7OfSS17JA=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=PozVFHg1zOigzia5BfCL30K3/VQHm6r5tf9ugJ8y92+Plyvh3RbdqC+NZ1wW4jliFs/3FR1IHdM3nf++FfmnrTQMLdupyQOE83krkvmGvwGVMK8oymU2gDU5HSF5kRIdvkQUHaF8gVIWkaS73eBxLQc082fSDM0wmLWxsFkZlaA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=LgVmunu4; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1717059387; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=wp9dT8wMnCyOCgEUiVZrNKqa8UOFLDrwjHbCmADMGTw=; b=LgVmunu4+LINRh3pSqLYgGD6q7wDmfgRKAVXZyUEPD/lpi3cVagJmkytTjv3hd6DcpcY0V dBHSnvXEokNiucVunxLKvrIeENapjB/bBVGQyGjsbFBPyW48NWIRemJ5E7EiidcW8g/e/m zLtZbSwT+GQZXYqsI/ZzVe/LlsNnjkw= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-330-9igs_UFeMf6OE_SYLtw3MA-1; Thu, 30 May 2024 04:56:26 -0400 X-MC-Unique: 9igs_UFeMf6OE_SYLtw3MA-1 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-35dbe9e69d5so15862f8f.1 for ; Thu, 30 May 2024 01:56:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717059385; x=1717664185; h=mime-version:user-agent:content-transfer-encoding:autocrypt :references:in-reply-to:date:cc:to:from:subject:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=wp9dT8wMnCyOCgEUiVZrNKqa8UOFLDrwjHbCmADMGTw=; b=OF0/AUTpQBAbiGbJ2RzY6OL9O8avgKX8PMBwjN1uVEy/qFiaLdqk1jGbBHVM6txw8r n7RDw3xgk82MMJj+40uIjAGj4dvDvavHTNZNN92gptPLm+sfxcp/BXFmaCc3uZKhWAld naCLoeeza2mw0jy14LdD2M2UUb+8aK/hljveJ4V4pFbSyAkl11wtfyivKuK34FOm5TZQ 3PiSRgPyIV++4he4oLwzINntcRjZ0eNFi/HRKQCQAXtDXvhyruuQuSRxMTiENGz+Frw4 YIsUtckvKR3fvfNtwkpDzfpXxrKRGV0yKMOkiIv22RzUQ3mos7AlokajpuD+g/yCvLf1 w1Cw== X-Forwarded-Encrypted: i=1; AJvYcCUYFxn4Grse+0Bf6upPxbBoWrZDevhCq7boEIhHVLge+0oKTbm8yohDe7FTfSy/vccnOnoLq2NqAcjqkD3OzpGPM0kvHPCxK6+2eKOt X-Gm-Message-State: AOJu0Ywt+Z2CjsB/+Ffbv9gUaxlwPgGN5hCc2PwH6XJEFfbF4F6xp9Fn 6ZwK1QGnuCFnNiwj7DEBbPr4bOgET1oy404z+VC2MQHQXQOAIoXp9+XlL8fXvDdHtTxkYr/G+Wg hImizYDXucnimqaTkixY8gXf3+G1K6Tq12hRXwJ1Uva7NZV8OhhLMrc038WC9uw== X-Received: by 2002:a5d:6106:0:b0:358:a09:2677 with SMTP id ffacd0b85a97d-35dc007f0e5mr1417481f8f.2.1717059385139; Thu, 30 May 2024 01:56:25 -0700 (PDT) X-Received: by 2002:a5d:6106:0:b0:358:a09:2677 with SMTP id ffacd0b85a97d-35dc007f0e5mr1417462f8f.2.1717059384745; Thu, 30 May 2024 01:56:24 -0700 (PDT) Received: from gerbillo.redhat.com ([2a0d:3341:b094:ab10:29ae:cdc:4db4:a22a]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-35dc9885324sm1013378f8f.38.2024.05.30.01.56.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 May 2024 01:56:24 -0700 (PDT) Message-ID: <6092d48946628c7e41fff25b161fdb71ce55d3d2.camel@redhat.com> Subject: Re: [PATCH net] net: dsa: microchip: fix wrong register write when masking interrupt From: Paolo Abeni To: Tristram.Ha@microchip.com, Arun Ramadoss , Woojung Huh , Andrew Lunn , Vivien Didelot , Florian Fainelli , Vladimir Oltean Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , UNGLinuxDriver@microchip.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Date: Thu, 30 May 2024 10:56:22 +0200 In-Reply-To: <1716932113-3418-1-git-send-email-Tristram.Ha@microchip.com> References: <1716932113-3418-1-git-send-email-Tristram.Ha@microchip.com> Autocrypt: addr=pabeni@redhat.com; prefer-encrypt=mutual; keydata=mQINBGISiDUBEAC5uMdJicjm3ZlWQJG4u2EU1EhWUSx8IZLUTmEE8zmjPJFSYDcjtfGcbzLPb63BvX7FADmTOkO7gwtDgm501XnQaZgBUnCOUT8qv5MkKsFH20h1XJyqjPeGM55YFAXc+a4WD0YyO5M0+KhDeRLoildeRna1ey944VlZ6Inf67zMYw9vfE5XozBtytFIrRyGEWkQwkjaYhr1cGM8ia24QQVQid3P7SPkR78kJmrT32sGk+TdR4YnZzBvVaojX4AroZrrAQVdOLQWR+w4w1mONfJvahNdjq73tKv51nIpu4SAC1Zmnm3x4u9r22mbMDr0uWqDqwhsvkanYmn4umDKc1ZkBnDIbbumd40x9CKgG6ogVlLYeJa9WyfVMOHDF6f0wRjFjxVoPO6p/ZDkuEa67KCpJnXNYipLJ3MYhdKWBZw0xc3LKiKc+nMfQlo76T/qHMDfRMaMhk+L8gWc3ZlRQFG0/Pd1pdQEiRuvfM5DUXDo/YOZLV0NfRFU9SmtIPhbdm9cV8Hf8mUwubihiJB/9zPvVq8xfiVbdT0sPzBtxW0fXwrbFxYAOFvT0UC2MjlIsukjmXOUJtdZqBE3v3Jf7VnjNVj9P58+MOx9iYo8jl3fNd7biyQWdPDfYk9ncK8km4skfZQIoUVqrWqGDJjHO1W9CQLAxkfOeHrmG29PK9tHIwARAQABtB9QYW9sbyBBYmVuaSA8cGFiZW5pQHJlZGhhdC5jb20+iQJSBBMBCAA8FiEEg1AjqC77wbdLX2LbKSR5jcyPE6QFAmISiDUCGwMFCwkIBwIDIgIBBhUKCQgLAgQWAgMBAh4HAheAAAoJECkkeY3MjxOkJSYQAJcc6MTsuFxYdYZkeWjW//zbD3ApRHzpNlHLVSuJqHr9/aDS+tyszgS8jj9MiqALzgq4iZbg 7ZxN9ZsDL38qVIuFkSpgMZCiUHdxBC11J8nbBSLlpnc924UAyr5XrGA99 6Wl5I4Km3128GY6iAkH54pZpOmpoUyBjcxbJWHstzmvyiXrjA2sMzYjt3Xkqp0cJfIEekOi75wnNPofEEJg28XPcFrpkMUFFvB4Aqrdc2yyR8Y36rbw18sIX3dJdomIP3dL7LoJi9mfUKOnr86Z0xltgcLPGYoCiUZMlXyWgB2IPmmcMP2jLJrusICjZxLYJJLofEjznAJSUEwB/3rlvFrSYvkKkVmfnfro5XEr5nStVTECxfy7RTtltwih85LlZEHP8eJWMUDj3P4Q9CWNgz2pWr1t68QuPHWaA+PrXyasDlcRpRXHZCOcvsKhAaCOG8TzCrutOZ5NxdfXTe3f1jVIEab7lNgr+7HiNVS+UPRzmvBc73DAyToKQBn9kC4jh9HoWyYTepjdcxnio0crmara+/HEyRZDQeOzSexf85I4dwxcdPKXv0fmLtxrN57Ae82bHuRlfeTuDG3x3vl/Bjx4O7Lb+oN2BLTmgpYq7V1WJPUwikZg8M+nvDNcsOoWGbU417PbHHn3N7yS0lLGoCCWyrK1OY0QM4EVsL3TjOfUtCNQYW9sbyBBYmVuaSA8cGFvbG8uYWJlbmlAZ21haWwuY29tPokCUgQTAQgAPBYhBINQI6gu+8G3S19i2ykkeY3MjxOkBQJiEoitAhsDBQsJCAcCAyICAQYVCgkICwIEFgIDAQIeBwIXgAAKCRApJHmNzI8TpBzHD/45pUctaCnhee1vkQnmStAYvHmwrWwIEH1lzDMDCpJQHTUQOOJWDAZOFnE/67bxSS81Wie0OKW2jvg1ylmpBA0gPpnzIExQmfP72cQ1TBoeVColVT6Io35BINn+ymM7c0Bn8RvngSEpr3jBtqvvWXjvtnJ5/HbOVQCg62NC6ewosoKJPWpGXMJ9SKsVIOUHsmoWK60spzeiJoSmAwm3zTJQnM5kRh2q iWjoCy8L35zPqR5TV+f5WR5hTVCqmLHSgm1jxwKhPg9L+GfuE4d0SWd84y GeOB3sSxlhWsuTj1K6K3MO9srD9hr0puqjO9sAizd0BJP8ucf/AACfrgmzIqZXCfVS7jJ/M+0ic+j1Si3yY8wYPEi3dvbVC0zsoGj9n1R7B7L9c3g1pZ4L9ui428vnPiMnDN3jh9OsdaXeWLvSvTylYvw9q0DEXVQTv4/OkcoMrfEkfbXbtZ3PRlAiddSZA5BDEkkm6P9KA2YAuooi1OD9d4MW8LFAeEicvHG+TPO6jtKTacdXDRe611EfRwTjBs19HmabSUfFcumL6BlVyceIoSqXFe5jOfGpbBevTZtg4kTSHqymGb6ra6sKs+/9aJiONs5NXY7iacZ55qG3Ib1cpQTps9bQILnqpwL2VTaH9TPGWwMY3Nc2VEc08zsLrXnA/yZKqZ1YzSY9MGXWYLkCDQRiEog1ARAAyXMKL+x1lDvLZVQjSUIVlaWswc0nV5y2EzBdbdZZCP3ysGC+s+n7xtq0o1wOvSvaG9h5q7sYZs+AKbuUbeZPu0bPWKoO02i00yVoSgWnEqDbyNeiSW+vI+VdiXITV83lG6pS+pAoTZlRROkpb5xo0gQ5ZeYok8MrkEmJbsPjdoKUJDBFTwrRnaDOfb+Qx1D22PlAZpdKiNtwbNZWiwEQFm6mHkIVSTUe2zSemoqYX4QQRvbmuMyPIbwbdNWlItukjHsffuPivLF/XsI1gDV67S1cVnQbBgrpFDxN62USwewXkNl+ndwa+15wgJFyq4Sd+RSMTPDzDQPFovyDfA/jxN2SK1Lizam6o+LBmvhIxwZOfdYH8bdYCoSpqcKLJVG3qVcTwbhGJr3kpRcBRz39Ml6iZhJyI3pEoX3bJTlR5Pr1Kjpx13qGydSMos94CIYWAKhegI06aTdvvuiigBwjngo/Rk5S+iEGR5KmTqGyp27o6YxZy6D4NIc6PKUzhIUxfvuHNvfu sD2W1U7eyLdm/jCgticGDsRtweytsgCSYfbz0gdgUuL3EBYN3JLbAU+UZpy v/fyD4cHDWaizNy/KmOI6FFjvVh4LRCpGTGDVPHsQXaqvzUybaMb7HSfmBBzZqqfVbq9n5FqPjAgD2lJ0rkzb9XnVXHgr6bmMRlaTlBMAEQEAAYkCNgQYAQgAIBYhBINQI6gu+8G3S19i2ykkeY3MjxOkBQJiEog1AhsMAAoJECkkeY3MjxOkY1YQAKdGjHyIdOWSjM8DPLdGJaPgJdugHZowaoyCxffilMGXqc8axBtmYjUIoXurpl+f+a7S0tQhXjGUt09zKlNXxGcebL5TEPFqgJTHN/77ayLslMTtZVYHE2FiIxkvW48yDjZUlefmphGpfpoXe4nRBNto1mMB9Pb9vR47EjNBZCtWWbwJTIEUwHP2Z5fV9nMx9Zw2BhwrfnODnzI8xRWVqk7/5R+FJvl7s3nY4F+svKGD9QHYmxfd8Gx42PZc/qkeCjUORaOf1fsYyChTtJI4iNm6iWbD9HK5LTMzwl0n0lL7CEsBsCJ97i2swm1DQiY1ZJ95G2Nz5PjNRSiymIw9/neTvUT8VJJhzRl3Nb/EmO/qeahfiG7zTpqSn2dEl+AwbcwQrbAhTPzuHIcoLZYV0xDWzAibUnn7pSrQKja+b8kHD9WF+m7dPlRVY7soqEYXylyCOXr5516upH8vVBmqweCIxXSWqPAhQq8d3hB/Ww2A0H0PBTN1REVw8pRLNApEA7C2nX6RW0XmA53PIQvAP0EAakWsqHoKZ5WdpeOcH9iVlUQhRgemQSkhfNaP9LqR1XKujlTuUTpoyT3xwAzkmSxN1nABoutHEO/N87fpIbpbZaIdinF7b9srwUvDOKsywfs5HMiUZhLKoZzCcU/AEFjQsPTATACGsWf3JYPnWxL9 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.50.4 (3.50.4-1.fc39) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Tue, 2024-05-28 at 14:35 -0700, Tristram.Ha@microchip.com wrote: > From: Tristram Ha >=20 > The initial code used 32-bit register. After that it was changed to 0x1F > so it is no longer appropriate to use 32-bit write. IMHO the above sentence is too much unclear. It sort of implies that the currently used register is 8 bit wide because such register address can be represented with 8 bit - which in turn sounds weird or irrelevant. I guess some documentation describes register 0x1F, please rephrase the changelog accordingly. Thanks, Paolo