Received-SPF: pass (google.com: domain of linux-kernel+bounces-195133-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
References: <20240528003521.979836-1-ankur.a.arora@oracle.com>
 <20240528003521.979836-11-ankur.a.arora@oracle.com>
 <20240528161816.GF26599@noisy.programming.kicks-ass.net>
User-agent: mu4e 1.4.10; emacs 27.2
From: Ankur Arora <ankur.a.arora@oracle.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Ankur Arora <ankur.a.arora@oracle.com>, linux-kernel@vger.kernel.org,
        tglx@linutronix.de, torvalds@linux-foundation.org, paulmck@kernel.org,
        rostedt@goodmis.org, mark.rutland@arm.com, juri.lelli@redhat.com,
        joel@joelfernandes.org, raghavendra.kt@amd.com, sshegde@linux.ibm.com,
        boris.ostrovsky@oracle.com, konrad.wilk@oracle.com,
        Andy Lutomirski
 <luto@kernel.org>
Subject: Re: [PATCH v2 10/35] entry: irqentry_exit only preempts for
 TIF_NEED_RESCHED
In-reply-to: <20240528161816.GF26599@noisy.programming.kicks-ass.net>
Date: Thu, 30 May 2024 02:03:20 -0700
Message-ID: <87mso77jtz.fsf@oracle.com>
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?/1BhR3qKgF4HOUV4BCR2aqe5j4uDYbiBx60nCsIw4kx+lrZXg4Bo458wOWrs?=
 =?us-ascii?Q?WBodkb9w01KV8s6arq7ExODxrn/0+3cPUVTGEITB4c06UOdQHW36QDwfK+LX?=
 =?us-ascii?Q?cEqzeiiBW9122nirCe613TgiGVvZMDJ9tGdxvJdw9XDgbvj66nTTAe87Mixn?=
 =?us-ascii?Q?4AnCTQJbIusGdVRgfkupxbkA1KBuegNbcmeP/PaOCDj2IQz5IhDGkmFOO2J5?=
 =?us-ascii?Q?YxrcaCHBhnUoB0nKEB+zp5ASiZKhTZM5zVtOb3mcFzP+EO7I5foWaqLHLU1d?=
 =?us-ascii?Q?Ec4U47qP+oXgL9GTCuB/VH3uGiqruzjx6xgLKvdXhRacgBLQmFIJ0G83/d+F?=
 =?us-ascii?Q?PneFsUS603MIG15CEBRjVgThdxyKEuIEKzR6xvvuR7fjVZ6klZnxpVDXJcpa?=
 =?us-ascii?Q?J1U8/a7km+54zPNhpHRR/WVzZ/QVsgliHVLh2C/oOzSHm1n/yCgVa+miT7cJ?=
 =?us-ascii?Q?h4QpZXoUA9b4gngqH22sZwK5pJ0oURd35bGtFMwaw/pziCM1/DyrD8Itb/WL?=
 =?us-ascii?Q?Pxf0DwvqrJCVY2oksV4MQZ/nK7tVLD/1H/NoJzD9UOF73vRJ0mEv+7oDvLHm?=
 =?us-ascii?Q?atMk31bNpL47hX782l4NNXs0MdP074XyDb3HGeNyBS5qdcIcqUxtOUOSDY+v?=
 =?us-ascii?Q?W2VSZX57zC+DUCgzcyw51Y2NsNONXgYVxEcfRI3HkPhl8tJkjyddir9DN4XM?=
 =?us-ascii?Q?NCGIJoyIrV6r5g19a1WfdzwsH8olzsjGoBuAjaQMX30qZ+WQYflJA0Fnaxcz?=
 =?us-ascii?Q?evyU84NGBa7lv8BNEk2M8kqBOu1yf2mZku1htJixFTz2Y7BsnopjbMD5+BSW?=
 =?us-ascii?Q?KvAc1F+gt937tob8d41XuymGq9kxOqvEgIE1CdWPUnA2/TZF7M8OQEo17soI?=
 =?us-ascii?Q?NQu5MzmzFglZjsuzd8zfpRvprAh6Nwzt8cymWBm92HSdheGdSLhYdDlYLRsp?=
 =?us-ascii?Q?Ty05/LtyQ3bk+gEHmrFQWrKa3S8Yfu1/JeCzYUv8Qfh42khbN0524whmW73E?=
 =?us-ascii?Q?osyDZb2Il8LjEymdi0Qv2Xnri6AK/bLiVVE1tuNBcmB3dPK2qVDaEkB6q/48?=
 =?us-ascii?Q?VwN8i2OvhNdiZTSAWuTSeNv2/rAf3Z/7TqtcpLS7A6mpdLDtI00yvTU50KM3?=
 =?us-ascii?Q?woVFO+/K7jW0r3+uJ5MR0ttxMkcNZOzt21C6LlKPge303x7GgVSWubDoFAV9?=
 =?us-ascii?Q?ezx0ZdXhtTO/kSRpaIPfSUAN0gNUredKVNmEnapOFkG1Eo8HtdQHV0q6eNo8?=
 =?us-ascii?Q?Gxqsur7GLJRP5viFry2JPGCGMQA24Qdfp42tghS6DzODx4rfOXWm2k9Mphpd?=
 =?us-ascii?Q?lO6SyKdnuqZ6izmPGKy0vDScDG3wJuh9FAp6C8DuRLhpjm0y20LSqGih6oNG?=
 =?us-ascii?Q?6HPA0/qM466tjV18d9GqnaG7uKLV5iWFptge7sCAvCqHxxgiG5sPmGRuk3oA?=
 =?us-ascii?Q?Q05UG0kWvIBP1jElvIgh+OsuhsYC7dPWAf3VoMnf5z0tj/+NSLUt39bq9afY?=
 =?us-ascii?Q?XpLHgTXzUK3CAuQlTsyBh6J4KWb2H4wWKEAEuIyAXPQJ+vVruXtwfvLqrAcD?=
 =?us-ascii?Q?9JIJPKOXBRgX5RgEtQ4Ovx9jISqCU7f0Cy7OlHz68mxs0xNhr8dCPYIEEJpG?=
 =?us-ascii?Q?xA=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	XxMs9IsY3TLPnDLo+6wdCD20TYMGaJtsCK06vCUKfKTSSlf3HVURfb0gxsJ7RYIo+cz5jprmAq5qAl1beAKuOGiElYJ1GTlejTW552ndJXaz3bArS2Ayhr1o+VDxuBPBknIdSMk3Yoe7slqupQTDnAcHxDiK4U0Olg/FKGnCqeWNghT446NxtBox5EfbJevFWhlaQT/KdgNqbWtQR3j95jxOp3YiCmPsPfQMY3OLxmtqW/xxJLCDiTB32ziSE9iXff+g8pXTM3gO+eLYSpwSvjB8cBBWrR2IdtqDbJcc9ZNk1CBttFjCDzf8CiOuZte9nikukYyG5ilB/qktuv9HaYeYEeQJaJd1lg4KK59/sMbowjXtV7xP9/uVkS1p7Zxv1CtmPCucDNscHkTqFMCgRavqoMwYwS3CSTo0CHQzyFlHP6uxUq7er8zFx20aCRWz59HhdsP89V2zEuwoQYIyJaY7y6bmY3F8x7disxht7PqxxdCrqUMzExRcDiGV5KTcjgxRZAKyafOWS6+KF7KdHL9JKB7QWPij8WUJcS/ymBfNyswaPlcvJ7OGjZThFtiBCg6p5sN1oiJ7UKQ/kgLdO+v7g1CTER5UNfqw8yfuDA8=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3317f06c-a7dd-422a-baae-08dc80875eba
X-MS-Exchange-CrossTenant-AuthSource: CO6PR10MB5409.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 May 2024 09:03:28.4353
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 8nGpQsG6kIk7rTAbNuwCcpVP1qYrlY62JV9KLQBHsaUEGsGEthh/5UDCcGKBplW4Ei3sQ4U7Z0zn7ANzkbUJVNGNN9BWgDciGudOt+f0BfE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN4PR10MB5656
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.650,FMLib:17.12.28.16
 definitions=2024-05-30_06,2024-05-28_01,2024-05-17_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 malwarescore=0
 spamscore=0 adultscore=0 mlxscore=0 phishscore=0 suspectscore=0
 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2405010000 definitions=main-2405300067
X-Proofpoint-GUID: mDtSSoaSZ_u6nLD2UaY-u6KB61QnQ50A
X-Proofpoint-ORIG-GUID: mDtSSoaSZ_u6nLD2UaY-u6KB61QnQ50A


Peter Zijlstra <peterz@infradead.org> writes:

> On Mon, May 27, 2024 at 05:34:56PM -0700, Ankur Arora wrote:
>> Use __tif_need_resched(RESCHED_NOW) instead of need_resched() to be
>> explicit that this path only reschedules if it is needed imminently.
>>
>> Also, add a comment about why we need a need-resched check here at
>> all, given that the top level conditional has already checked the
>> preempt_count().
>>
>> Cc: Peter Zijlstra <peterz@infradead.org>
>> Cc: Andy Lutomirski <luto@kernel.org>
>> Originally-by: Thomas Gleixner <tglx@linutronix.de>
>> Link: https://lore.kernel.org/lkml/87jzshhexi.ffs@tglx/
>> Signed-off-by: Ankur Arora <ankur.a.arora@oracle.com>
>> ---
>>  kernel/entry/common.c | 11 ++++++++++-
>>  1 file changed, 10 insertions(+), 1 deletion(-)
>>
>> diff --git a/kernel/entry/common.c b/kernel/entry/common.c
>> index bcb23c866425..c684385921de 100644
>> --- a/kernel/entry/common.c
>> +++ b/kernel/entry/common.c
>> @@ -307,7 +307,16 @@ void raw_irqentry_exit_cond_resched(void)
>>  		rcu_irq_exit_check_preempt();
>>  		if (IS_ENABLED(CONFIG_DEBUG_ENTRY))
>>  			WARN_ON_ONCE(!on_thread_stack());
>> -		if (need_resched())
>> +
>> +		/*
>> +		 * Check if we need to preempt eagerly.
>> +		 *
>> +		 * Note: we need an explicit check here because some
>> +		 * architectures don't fold TIF_NEED_RESCHED in the
>> +		 * preempt_count. For archs that do, this is already covered
>> +		 * in the conditional above.
>> +		 */
>> +		if (__tif_need_resched(RESCHED_NOW))
>>  			preempt_schedule_irq();
>
> Seeing how you introduced need_resched_lazy() and kept need_resched() to
> be the NOW thing, I really don't see the point of using the long form
> here?

So, the reason I used the lower level interface here (and the scheduler)
was to spell out exactly was happening here.

Basically keep need_resched()/need_resched_lazy() for the none-core code.

--
ankur