Received-SPF: pass (google.com: domain of linux-kernel+bounces-195134-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
References: <20240528003521.979836-1-ankur.a.arora@oracle.com>
 <20240528003521.979836-10-ankur.a.arora@oracle.com>
 <20240528161316.GE26599@noisy.programming.kicks-ass.net>
User-agent: mu4e 1.4.10; emacs 27.2
From: Ankur Arora <ankur.a.arora@oracle.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Ankur Arora <ankur.a.arora@oracle.com>, linux-kernel@vger.kernel.org,
        tglx@linutronix.de, torvalds@linux-foundation.org, paulmck@kernel.org,
        rostedt@goodmis.org, mark.rutland@arm.com, juri.lelli@redhat.com,
        joel@joelfernandes.org, raghavendra.kt@amd.com, sshegde@linux.ibm.com,
        boris.ostrovsky@oracle.com, konrad.wilk@oracle.com,
        Paolo Bonzini
 <pbonzini@redhat.com>,
        Andy Lutomirski <luto@kernel.org>
Subject: Re: [PATCH v2 09/35] entry/kvm: handle lazy rescheduling at
 guest-entry
In-reply-to: <20240528161316.GE26599@noisy.programming.kicks-ass.net>
Date: Thu, 30 May 2024 02:04:02 -0700
Message-ID: <87jzjb7jst.fsf@oracle.com>
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?oftGqJKYtNKzvMkfjqV6/bHwvJj47IQPT76OJBN0HtjCFSUQvrP7Q4z/jTrP?=
 =?us-ascii?Q?5kuQhblhLpOaqDc3lhc4oKB63cS9UHVqFlmwD7GvcDN+Uq3WciFN6ja7e3T9?=
 =?us-ascii?Q?Vl149jTWZ5jE3XTB9aLew0UiX05N56dFIWw4FYFhktYZIAyJJvKXHMRpj5I7?=
 =?us-ascii?Q?qp81pHSPcR4SuQ9sqcqWFn65pmxRswNKEOqcjozIrZh2x3n3FQ5jWoeQYiqq?=
 =?us-ascii?Q?1oK8SYUOPhpgULYGLT4hHRwG1jka0XtNcWNlCocTtPBxGYx7hB/Tu4JDMxVe?=
 =?us-ascii?Q?x0tRpFSjKJS9v/jISAD5oRUwvRANOnG9aviVPHe6+YUccBOME0azcSxd7QMK?=
 =?us-ascii?Q?7Ir1zeCKS6n2UOqZ1R6j294z+F6Bwd2pJyIveHyurIgjNXUDKyoIHgYj9++K?=
 =?us-ascii?Q?wv7DuaVoJnsLqGanD1GmNhAv1mSAKEnZOo++YaEdYMHXECkB1cM5EsHE90nB?=
 =?us-ascii?Q?tWR+mXojhDRltB+6efisfeOyTWg/qbzyx0LFO+i6YrFc/txj/9WjE47DSo7O?=
 =?us-ascii?Q?TKFZff+Op1nYa9hAwHYvBUCwJs2Rzgx9UTyjbfjcCDzvxtqiAgXWOawvwzjX?=
 =?us-ascii?Q?WEnxKHE0wqardhpEpinGMr7xWQcKjLW3a3gwm1Z0GOO8WwxnJhJPULanlD+b?=
 =?us-ascii?Q?p3jlhWBWgGB/h+V7tbjlUzcpwlUUX3qB++65J+MlPj6cX400AbYWaRz9oDdf?=
 =?us-ascii?Q?Ek2xyD+yBbK7XbeXxEaMmnk/6Rknzj/7CbmytWxCV80lfSZvoVGvTg+Gn1Tv?=
 =?us-ascii?Q?8sefsHRd0EKSLz+bVaJ5S0c8JVG+m5RK2rP8fI9Qk6fsqg2Qwoj0f+tryGaz?=
 =?us-ascii?Q?Fd14dQ7nB7ahUpqWdbk98XcMsIU3N/rSa4EwgMmcqh5uoYLQURE2Uf2Ipk/M?=
 =?us-ascii?Q?OgCPZFJrvR8vMUC2qQl1c8SMn/nmvDU6ACEPVIBXgPWXpBcaxsCOOvcsOACg?=
 =?us-ascii?Q?4DdWWWPxpxRFfa0/K20uggvCEcHzWkFI+ZiFjphko50diH/6DnWCjYhlhzQ3?=
 =?us-ascii?Q?qWMzujR0hVcCABmZm33LKrKjytNm6H/Vto4d0uXC96mXCsZwWh5+Bg+T8NMf?=
 =?us-ascii?Q?0yVNPRVQ8bhEDmC0ODm/th1RyJTwEHuwsEaUs5n9nrkJa5DN4o+t006GFJTA?=
 =?us-ascii?Q?BYgkPm/2OhjZWG1LyQ0adq4szvK87cYEpBHTdEDDkIAntYGM1sjzeJJORuMG?=
 =?us-ascii?Q?1KfYjo0rnUipuHzTp7+xCp8BQT8ThLX2685ZG1L/22x7ZuNa40OCH+Tt57xV?=
 =?us-ascii?Q?XMjApuPZyea8il2gVEei7DsraKUprrfLo1hFQ4+LKhGZWmmvt44KMT9/JaLA?=
 =?us-ascii?Q?8rTOX+15+PuTfRs5ftkuVuQXH1dl42JsKEzfPcXiOrHCiamIWjruzbbpg2uC?=
 =?us-ascii?Q?tmNhHo/K04yxMqjEOMoyrcVxUNt1T9HEu+bRvUU76Rg7yhpgal+SaUW3RLrn?=
 =?us-ascii?Q?e81aJLYgof2FsVlFtdgGCrbCOVAltzBsCv+UZrT2Jl0+3NPbz0zUZ735Uic0?=
 =?us-ascii?Q?35N01Lf4k7o7N4xeoLzHoAXR4m62eqota3UPPEIRUtOy/AGhFxQ+IcHnQcXC?=
 =?us-ascii?Q?JtL6swHBNEJizW9wsRBUSqw1CKEByHKHkIitziTvmeVOb+PezyB24aMfT/Cd?=
 =?us-ascii?Q?DQ=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	+j61NAcz55pyhs2d+KYV9GadYMH8cQLRZ3YO3nGnTSWneHUUEyvKaNSvv66lACYcq2J67Jsc+vaC7iTuwVewkDJbHtNYtAftiQxRNGAydqWQWBssQrv1nyGa09pAx7ah97XGiyo3qL1SEQLYXpjcnGVkZNeMMM0ai2a/rVaLBbRkkFMHVuGEeOfNTyXAjroMsYtqRVHof6NCEBVInQdmGPn7YkX4Ijzf7OMG8TWPmjlRDcdkJY1AhZkO8/kFb8gBu4gVxrJQmZ3x3OyyhwUWiNlqoIuKSKUCUVStllT9B1/bJFq6x9njvkvDiLLz61FJDL4noDzgRRJ1qxSL8NtLD2787DsQlqkycm1AqC0oEcAMMUgtiTC15kPY0dqYrTb9A5F54AJRV5jPV1lr5KPZWT/9nF/mJ8C/QCLElJhqy7nIj7FacLiheTYZ7VlW4x7/4gjllVDjXOdZ0gZfCUmjs/YZtsRujwzgGFnH/d6T8I8yN9y1nvLNIoS+HUKqB1QW3VS5Yy/fWORseAFxb0ltF31GvCxBN1viaO4ci4i1tPH9C/IIxPGPhXjR3dpcV4z6pHz5Fpl3/4jX5/I9UJQwAUUmUYqvSYbTF5BSvVWOxX0=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 154df3a5-a268-468c-51a8-08dc808777fc
X-MS-Exchange-CrossTenant-AuthSource: CO6PR10MB5409.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 May 2024 09:04:10.8275
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: GZP7l6F4WzAMeVhQpeDH/ugRwXcIVo8eX39q6RXjdp+HzNnCaKhFtrcfWejPP3Q3vBhcgBUrFrHfCk6g/RAqDfcNPN3G7Gv8iWFiPPLihEM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN4PR10MB5656
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.650,FMLib:17.12.28.16
 definitions=2024-05-30_06,2024-05-28_01,2024-05-17_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 malwarescore=0 mlxscore=0
 mlxlogscore=770 phishscore=0 spamscore=0 adultscore=0 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2405010000
 definitions=main-2405300067
X-Proofpoint-ORIG-GUID: f_WjORVGy9ys-IUMnSLtf-gvFQZBm4eH
X-Proofpoint-GUID: f_WjORVGy9ys-IUMnSLtf-gvFQZBm4eH


Peter Zijlstra <peterz@infradead.org> writes:

> On Mon, May 27, 2024 at 05:34:55PM -0700, Ankur Arora wrote:
>> Archs defining CONFIG_KVM_XFER_TO_GUEST_WORK call
>> xfer_to_guest_mode_handle_work() from various KVM vcpu-run
>> loops to check for any task work including rescheduling.
>>
>> Handle TIF_NEED_RESCHED_LAZY alongside TIF_NEED_RESCHED.
>>
>> Also, while at it, remove the explicit check for need_resched() in
>> the exit condition as that is already covered in the loop condition.
>>
>> Cc: Paolo Bonzini <pbonzini@redhat.com>
>> Cc: Peter Zijlstra <peterz@infradead.org>
>> Cc: Andy Lutomirski <luto@kernel.org>
>> Originally-by: Thomas Gleixner <tglx@linutronix.de>
>> Link: https://lore.kernel.org/lkml/87jzshhexi.ffs@tglx/
>> Signed-off-by: Ankur Arora <ankur.a.arora@oracle.com>
>> ---
>>  include/linux/entry-kvm.h | 2 +-
>>  kernel/entry/kvm.c        | 4 ++--
>>  2 files changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/include/linux/entry-kvm.h b/include/linux/entry-kvm.h
>> index 6813171afccb..674a622c91be 100644
>> --- a/include/linux/entry-kvm.h
>> +++ b/include/linux/entry-kvm.h
>> @@ -18,7 +18,7 @@
>>
>>  #define XFER_TO_GUEST_MODE_WORK						\
>>  	(_TIF_NEED_RESCHED | _TIF_SIGPENDING | _TIF_NOTIFY_SIGNAL |	\
>> -	 _TIF_NOTIFY_RESUME | ARCH_XFER_TO_GUEST_MODE_WORK)
>> +	 _TIF_NOTIFY_RESUME | _TIF_NEED_RESCHED_LAZY | ARCH_XFER_TO_GUEST_MODE_WORK)
>
> Same as last patch, it seems weird to have both RESCHED flags so far
> apart.

True. Will fix this and the other.

--
ankur