Received-SPF: pass (google.com: domain of linux-kernel+bounces-195143-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
References: <20240528003521.979836-1-ankur.a.arora@oracle.com>
 <20240528003521.979836-6-ankur.a.arora@oracle.com>
 <20240528155543.GA26599@noisy.programming.kicks-ass.net>
User-agent: mu4e 1.4.10; emacs 27.2
From: Ankur Arora <ankur.a.arora@oracle.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Ankur Arora <ankur.a.arora@oracle.com>, linux-kernel@vger.kernel.org,
        tglx@linutronix.de, torvalds@linux-foundation.org, paulmck@kernel.org,
        rostedt@goodmis.org, mark.rutland@arm.com, juri.lelli@redhat.com,
        joel@joelfernandes.org, raghavendra.kt@amd.com, sshegde@linux.ibm.com,
        boris.ostrovsky@oracle.com, konrad.wilk@oracle.com
Subject: Re: [PATCH v2 05/35] thread_info: selector for TIF_NEED_RESCHED[_LAZY]
In-reply-to: <20240528155543.GA26599@noisy.programming.kicks-ass.net>
Date: Thu, 30 May 2024 02:07:42 -0700
Message-ID: <87bk4n7jmp.fsf@oracle.com>
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?bwxwy8/q0GE5ptLU8GznyhCosI8GApFZjJcRFfsGsjbiD8fPOke8ydI973nK?=
 =?us-ascii?Q?zBiUCctA0KQcUIzSu3St8N3nhlv2sdW96mPkc/RzknSkmkHGcsIxLeuCs0sP?=
 =?us-ascii?Q?aF/IocQDB9DUJQlWVrRbHy7KpiUo/CNAIphaGEHCoi09Oct85Cigg/r8ylp8?=
 =?us-ascii?Q?4xbWbLStmb2vkSSE9LQP8XnWC3OtoAaadEe1i7ZJKjn1AN623loVdnZrYcMV?=
 =?us-ascii?Q?VODUxofbYzXhuQwDv9l0vE5KU9MJ943XllY5UCYjO1blmxtYh9le5vGtymjU?=
 =?us-ascii?Q?1QpyBRZPUV5B49WKBH6XddR0xJFqhwayImRi6kbzsUfn9CrtJBSBhZ3bGCFR?=
 =?us-ascii?Q?1KB1F22rQraNHbQnXfUQQ7P+8tBrHEJHKu8CXHYykkiNb5AFaETyVbzdvxfy?=
 =?us-ascii?Q?l0kwYOwhbdK3oj5QVOgXPxhtQ9vOqVVOaj+FFG56e3TqsA8L7Y/lg0sHvNXB?=
 =?us-ascii?Q?DNnNPzKRPfb8myszZzrMkKCnq5d+0hfqZPJvTuYc+1KXAHf/Cbj5nAnO5fip?=
 =?us-ascii?Q?b+LiYjK8h/dsNAtO+0axHnou3X5ZNSe9DwdG3ORMXn7eWcaq0+sULlbIeV7g?=
 =?us-ascii?Q?SbVZp2tPYRRNLoczZaaDZZ8LqZ3cUA5HKo1kK3Cr2Yc94WyaFb3UeiiqUR1v?=
 =?us-ascii?Q?LjjVh5TVTTPfVl6irgPhDo2Q1sJuxwI0BK/oQnR7HiE+UQPuVQS6zA+Aaprz?=
 =?us-ascii?Q?/d9gs+M2mb2v6fwnx4oiGPeszyaUbvelaFNQ87hab1JFFJmbmX5pmzCH9Mij?=
 =?us-ascii?Q?5OROJLdZwqd9FImNtYwQRquwq0relhJEAH3wnF3nLGkgWjIvm5Le0ft6neGb?=
 =?us-ascii?Q?G+ZRgQV8aRHk7UL3zxfGh6I8wJEgRjBeb4Wn5kvonJki1A2SRgUAPrBt/lbt?=
 =?us-ascii?Q?IAHOwEkeD7c8dPS2BphzJ8/rXK5cZwf10+iq23hI7u/vR3ETcs3V7R67bmri?=
 =?us-ascii?Q?bCxPCVOX/iKGj3wdT/SW75VL/tVcQJGOG1On/8JazAF7Ht0d62sm8ykJA7Cw?=
 =?us-ascii?Q?zUoDD3d5ZSe4eCnuFjcRPywZyYySpDoDj2Oej8S6xe0gYEa9+O63vkjzUnKm?=
 =?us-ascii?Q?iuyUZJ3Ale7VGJfgE7co5mEeqibHMOBNFmQL1CRasq0iXy6YlbUFJDw5Q3u+?=
 =?us-ascii?Q?UhRuXqlZUuR96WVEmrXuiMal2H5qfLuSaivkN3qK+8uE7rICltYmoFB/hxsv?=
 =?us-ascii?Q?hZcyJISsG9j3YDLqvHkFAfFL5yLf1m3JK2iOM9dOOGxLh7uwVOvPqAYB98W8?=
 =?us-ascii?Q?6/QyvDT29xOSguDmX8ZKGHLtKUql23ngT3MDaJq9kByVqT+MuVE4yAJrgswu?=
 =?us-ascii?Q?WHRGKN5YPtllracm6PmU3Xnt17AHeEzUcNUjHCibt/Gr3SJD5b81i3fwjxkl?=
 =?us-ascii?Q?TtV8Yrqba72QV9Ar5cARTlYt2j8vY2TOVFq7sn1pbUfXdwL3aRox90P6q6gc?=
 =?us-ascii?Q?UibYQBR5A1sHMBqtsu/mIH3b0TfzOxRwNz32C/t/SEEppQ/ar0kGp7aKWtcb?=
 =?us-ascii?Q?Z/kVDWvP2blxDVsRk4TYdHbphpyBRFPIy06IIBju6QVuNjQF9bZ6OzCLe2JD?=
 =?us-ascii?Q?N6M8ahKdcwlEDi/xEX6IGMjuFcNGIV9LrvGLScgRXkMnlzeI3zYVti882w44?=
 =?us-ascii?Q?3w=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	N77pVMZI9BCKhLGYhWt1MUts+hcFN2MIFaOerzvE8cjhzb+8VCcoJc9k5j4lK8H1k9MaQ8yQ5an/p+TYUxl/sbLv+90ixItUcF4iYamy26w5Q2A2bJbD4WcOnDKY47g/X6s6iLDGLfFlh/UUU/0KTx563zc9NLrm52RJ5PhxwYI1jtzW1NfNfHy2pO2Q5G64GmeVRy+PvWOa3jRU7S3yKrrNmQ+4OpjAa5ml8wzngbDDbl4jo8rsHgu1FKjvcPWSQxEChQ77fTFKeBrl/r3kNUtt/JQxa12DNafckxQtO0BRdaLtyghcFuqRPdxaGFfNXmFJ/i7FcHiLbozEp/H+lmBvzDmA3M81T3zZ5fBDs+es0yB44e2OGwVLqFrgjkk/9ZaksGQnDKBuRkUCnoAtXeitEJUggpKnyz/GFTOtLIe/l41Yo3+V+b5hmPi6/zNm9U5JjQCv2gd+fBqkf2u4AMQaw7kJ08zCOx48DZcetn4IWaRcdiM2qIUnzHg/skbxYCNaGCZI3ovdiKu2mSh8pz9U49QtUMi6dP4zpc1/5m7iK/UgDLADNTokPLp83P257qi+wwPMxxxT6zFiD1b1BhpQoLuwp3irr2wuFrBlyLc=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cc2e409e-dfec-44d6-c0f7-08dc8087fae8
X-MS-Exchange-CrossTenant-AuthSource: CO6PR10MB5409.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 May 2024 09:07:50.3430
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 2VUXRvmYVFw9eBzvE+s8AR1cC/5c0odxeJ9DMLZvai4QAKDRIuzLs1HRIsEL4AZCEU0SCB3FLAoyltq+JeMpxaalEZjdWQEbL2K30SdqXjk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR10MB5898
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.650,FMLib:17.12.28.16
 definitions=2024-05-30_06,2024-05-28_01,2024-05-17_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 malwarescore=0 bulkscore=0
 suspectscore=0 mlxscore=0 adultscore=0 spamscore=0 mlxlogscore=999
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2405010000
 definitions=main-2405300067
X-Proofpoint-GUID: 1Ywl9d4zcn_MNCtGBu1x8IRwhBSeRHcV
X-Proofpoint-ORIG-GUID: 1Ywl9d4zcn_MNCtGBu1x8IRwhBSeRHcV


Peter Zijlstra <peterz@infradead.org> writes:

> On Mon, May 27, 2024 at 05:34:51PM -0700, Ankur Arora wrote:
>> Define tif_resched() to serve as selector for the specific
>> need-resched flag: with tif_resched() mapping to TIF_NEED_RESCHED
>> or to TIF_NEED_RESCHED_LAZY.
>>
>> For !CONFIG_PREEMPT_AUTO, tif_resched() always evaluates
>> to TIF_NEED_RESCHED, preserving existing scheduling behaviour.
>>
>> Cc: Peter Ziljstra <peterz@infradead.org>
>> Originally-by: Thomas Gleixner <tglx@linutronix.de>
>> Link: https://lore.kernel.org/lkml/87jzshhexi.ffs@tglx/
>> Signed-off-by: Ankur Arora <ankur.a.arora@oracle.com>
>> ---
>>  include/linux/thread_info.h | 25 +++++++++++++++++++++++++
>>  1 file changed, 25 insertions(+)
>>
>> diff --git a/include/linux/thread_info.h b/include/linux/thread_info.h
>> index 06e13e7acbe2..65e5beedc915 100644
>> --- a/include/linux/thread_info.h
>> +++ b/include/linux/thread_info.h
>> @@ -71,6 +71,31 @@ enum syscall_work_bit {
>>  #define _TIF_NEED_RESCHED_LAZY _TIF_NEED_RESCHED
>>  #endif
>>
>> +typedef enum {
>> +	RESCHED_NOW = 0,
>> +	RESCHED_LAZY = 1,
>> +} resched_t;
>> +
>> +/*
>> + * tif_resched(r) maps to TIF_NEED_RESCHED[_LAZY] with CONFIG_PREEMPT_AUTO.
>> + *
>> + * For !CONFIG_PREEMPT_AUTO, both tif_resched(RESCHED_NOW) and
>> + * tif_resched(RESCHED_LAZY) reduce to the same value (TIF_NEED_RESCHED)
>> + * leaving any scheduling behaviour unchanged.
>> + */
>> +static __always_inline int tif_resched(resched_t rs)
>> +{
>> +	if (IS_ENABLED(CONFIG_PREEMPT_AUTO))
>> +		return (rs == RESCHED_NOW) ? TIF_NEED_RESCHED : TIF_NEED_RESCHED_LAZY;
>> +	else
>> +		return TIF_NEED_RESCHED;
>> +}
>
> Perhaps:
>
> 	if (IS_ENABLED(CONFIG_PREEMPT_AUTO) && rs == RESCHED_LAZY)
> 		return TIF_NEED_RESCHED_LAZY;
>
> 	return TIF_NEED_RESCHED;

This and similar other interface changes make it much clearer.
Thanks. Will fix.


--
ankur