Received-SPF: pass (google.com: domain of linux-kernel+bounces-195184-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
From: Peng Fan <peng.fan@nxp.com>
To: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>, "sudeep.holla@arm.com"
	<sudeep.holla@arm.com>, "cristian.marussi@arm.com" <cristian.marussi@arm.com>
CC: "linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>
Subject: RE: [PATCH V2] firmware: arm_scmi: power_control: support suspend
 command
Thread-Topic: [PATCH V2] firmware: arm_scmi: power_control: support suspend
 command
Thread-Index: AQHamT+2kPkNNu1tdEe0xkM7CL1Pt7GvtVBg
Date: Thu, 30 May 2024 09:34:03 +0000
Message-ID:
 <DU0PR04MB9417CE9DE7AE18A7FB2D381A88F32@DU0PR04MB9417.eurprd04.prod.outlook.com>
References: <20240428075105.2187837-1-peng.fan@oss.nxp.com>
In-Reply-To: <20240428075105.2187837-1-peng.fan@oss.nxp.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?ZHcny79EtzLsUtHi/dREw8ZmEtTjZo4+MpLxWJOyQCkTurKKaY9i2rsNbOBP?=
 =?us-ascii?Q?a10/aH1JoDF2Q7Q1lLGz2+S8RccIGrEenvuGoQGxwHPdJOp0FYypXowqKmUQ?=
 =?us-ascii?Q?5JViXGkEbzICFizwMlBgNdABaEXpYZAN/SrwfKXMKd7cCYvfZbXTwkQT3jBe?=
 =?us-ascii?Q?2b+Cavmwy9KJR1Jk78kpS5XNNWHwpKhQK2iKF4dibtNolkl6OrLyVYnaNUc2?=
 =?us-ascii?Q?rNHhgGAyZmPlEk5ouwHT7H7PLs9x7z5ROiimqCNDc0NoIljqSdKh4LHciHEC?=
 =?us-ascii?Q?+er3T4y6gdWOfOdgW7cG8RcYM/7w8iq1B8wJ9jg6vMQzmPZNYXhF9ZxtJHrb?=
 =?us-ascii?Q?putA5NriClPhHYLic6ire8ttEuNB8H81o+qbx+V9p3uubbsfJNtL91m97lKj?=
 =?us-ascii?Q?LjJXCSoHW/SIsbKCNQNDpDDPTqvusNOu0KXGq2pn7t8t429NjP22Rag9gMMq?=
 =?us-ascii?Q?BhTWCzU9yM9XNeaIfZKF2qerjsOD8TgCZdXVIrjnAtdAg5me6oSjwC6TYgZR?=
 =?us-ascii?Q?oC6TZ4NTiBWH+PvFjojasUVK1woH9pr6I3qO4mmYMtAAdffekIRorDmWbdQu?=
 =?us-ascii?Q?JeJ0rj2qEHVS3SAAW0F5gqlG+x2jbIj4mbEZfO44x7aNKa0ppjDymEaIDufV?=
 =?us-ascii?Q?Cp8H33EFotAm7hvtfQ3761E4xCeib0mFRSo5mJmxuGzA35wffeHqVeJoyb97?=
 =?us-ascii?Q?Q1lUiWzF103JuPM2/juMKWUEBxB5cK2H8CduZjujSxqZDb6tKbRFCsI99VzO?=
 =?us-ascii?Q?opyEiW9Jghfof+JZ4WkMxzJfkTZkfG2BvB+drM18V0VjQCyFC5LEzHYlpbjs?=
 =?us-ascii?Q?zH4yPpU5Hh1ETT7OBphjxBRlRhgkf18e/0ICvpn50PsCJptp8ML5Gnn8nj4S?=
 =?us-ascii?Q?fVkEsHwoNZp9hQzaIb++wcuops0vK+o2NWVKcC5cO+EiUuKNPXDBEyTCJWJf?=
 =?us-ascii?Q?bPKENJqneJVVBweV/WLWmJUDBWksKKmetF7RVXVM7GIuyPFF/LcEj9INtdXX?=
 =?us-ascii?Q?w9QSIOEq6q3EPQ42RAxsFnSjloynyS+ryzyrhY9isvNs5QKq0MzFU+DAuVfm?=
 =?us-ascii?Q?vHFVFtqAdwSgdi5K6SKSGsSxSJ0AERFOh9/U4uXpRcbSq/5F+Q82QF+8KrmJ?=
 =?us-ascii?Q?9LHvMSaqlS6kE9hxs9c4JG2h5QGI6JKUUEFjcLcMx32Apzskm8h/654/0zxD?=
 =?us-ascii?Q?PPGaP+nud0XwiKg/jXjkjMN6KUkU7DWS74ydfbDy7SW+elbVJ7+ZtPHLXe97?=
 =?us-ascii?Q?A8H/n0ve0HitiIVTfkaf2vkaAmSc/gZ63Vt5PtiCUQtYtxQ4opLR1s3AFlnJ?=
 =?us-ascii?Q?jNenELSwXsvjxC72OcP+dZDe+l/Lr4LK8wupNJa2F2tqjJ3fx7XVEs+Pgixf?=
 =?us-ascii?Q?RMKphjtDNqB/rn45xYT8ty8JspfzYM07sZVGKWfM+G8PbLBvqrh3JHd5zQ1j?=
 =?us-ascii?Q?cRXLb8h+MTnYq7ryY/lZCAulmrgxSuvXzJBCysivjHY/B4kbyYqB4CGR3JLu?=
 =?us-ascii?Q?FBOKsGmzuVZu5p5lirWcnSyDf/DdmOpWIK6HvnAMNXo4l55lYyYvnMNfiiAs?=
 =?us-ascii?Q?XBsvUge+TKNiKmDi4Fg=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d900155c-4d00-4792-b08a-08dc808ba4f7
X-MS-Exchange-CrossTenant-originalarrivaltime: 30 May 2024 09:34:03.5671
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: j5KnexiflE/AZdsowitQkOOp1mwVtYyQsbZvUBOTEpHwIViPeCaOvdUxA0Ks7UmUhK6jA55Y2SipiwBTgkJyZQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU4PR04MB10887

Hi Sudeep,

> Subject: [PATCH V2] firmware: arm_scmi: power_control: support suspend
> command

Is this patch good for you to pick up?

Thanks,
Peng.

>=20
> From: Peng Fan <peng.fan@nxp.com>
>=20
> Support System suspend notification. Using a work struct to call pm_suspe=
nd.
> There is no way to pass suspend level to pm_suspend, so use MEM as of now=
.
>=20
> - The choice of S2R(MEM) by default. The userspace can configure whatever
>   default behaviour expected as S2R, if issuing suspend from userspace.
>=20
> - The userspace needs to keep the wakeup source enabled, otherwise the
>   system may never resume back.
>=20
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
>=20
> V2:
>  Update commit log
>  Add comment for suspend_work
>=20
>  .../firmware/arm_scmi/scmi_power_control.c    | 21 ++++++++++++++++++-
>  1 file changed, 20 insertions(+), 1 deletion(-)
>=20
> diff --git a/drivers/firmware/arm_scmi/scmi_power_control.c
> b/drivers/firmware/arm_scmi/scmi_power_control.c
> index 6eb7d2a4b6b1..21f467a92942 100644
> --- a/drivers/firmware/arm_scmi/scmi_power_control.c
> +++ b/drivers/firmware/arm_scmi/scmi_power_control.c
> @@ -50,6 +50,7 @@
>  #include <linux/reboot.h>
>  #include <linux/scmi_protocol.h>
>  #include <linux/slab.h>
> +#include <linux/suspend.h>
>  #include <linux/time64.h>
>  #include <linux/timer.h>
>  #include <linux/types.h>
> @@ -78,6 +79,7 @@ enum scmi_syspower_state {
>   * @reboot_nb: A notifier_block optionally used to track reboot progress
>   * @forceful_work: A worker used to trigger a forceful transition once a
>   *		   graceful has timed out.
> + * @suspend_work: A worker used to trigger system suspend
>   */
>  struct scmi_syspower_conf {
>  	struct device *dev;
> @@ -90,6 +92,7 @@ struct scmi_syspower_conf {
>  	struct notifier_block reboot_nb;
>=20
>  	struct delayed_work forceful_work;
> +	struct work_struct suspend_work;
>  };
>=20
>  #define userspace_nb_to_sconf(x)	\
> @@ -249,6 +252,9 @@ static void scmi_request_graceful_transition(struct
> scmi_syspower_conf *sc,
>  	case SCMI_SYSTEM_WARMRESET:
>  		orderly_reboot();
>  		break;
> +	case SCMI_SYSTEM_SUSPEND:
> +		schedule_work(&sc->suspend_work);
> +		break;
>  	default:
>  		break;
>  	}
> @@ -277,7 +283,8 @@ static int scmi_userspace_notifier(struct
> notifier_block *nb,
>  	struct scmi_system_power_state_notifier_report *er =3D data;
>  	struct scmi_syspower_conf *sc =3D userspace_nb_to_sconf(nb);
>=20
> -	if (er->system_state >=3D SCMI_SYSTEM_POWERUP) {
> +	if (er->system_state >=3D SCMI_SYSTEM_MAX ||
> +	    er->system_state =3D=3D SCMI_SYSTEM_POWERUP) {
>  		dev_err(sc->dev, "Ignoring unsupported system_state:
> 0x%X\n",
>  			er->system_state);
>  		return NOTIFY_DONE;
> @@ -315,6 +322,16 @@ static int scmi_userspace_notifier(struct
> notifier_block *nb,
>  	return NOTIFY_OK;
>  }
>=20
> +static void scmi_suspend_work_func(struct work_struct *work) {
> +	struct scmi_syspower_conf *sc =3D
> +		container_of(work, struct scmi_syspower_conf,
> suspend_work);
> +
> +	pm_suspend(PM_SUSPEND_MEM);
> +
> +	sc->state =3D SCMI_SYSPOWER_IDLE;
> +}
> +
>  static int scmi_syspower_probe(struct scmi_device *sdev)  {
>  	int ret;
> @@ -338,6 +355,8 @@ static int scmi_syspower_probe(struct scmi_device
> *sdev)
>  	sc->userspace_nb.notifier_call =3D &scmi_userspace_notifier;
>  	sc->dev =3D &sdev->dev;
>=20
> +	INIT_WORK(&sc->suspend_work, scmi_suspend_work_func);
> +
>  	return handle->notify_ops->devm_event_notifier_register(sdev,
>=20
> SCMI_PROTOCOL_SYSTEM,
>=20
> SCMI_EVENT_SYSTEM_POWER_STATE_NOTIFIER,
> --
> 2.37.1