Received-SPF: pass (google.com: domain of linux-kernel+bounces-195215-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <bd00b65f-d0ab-415a-ad5c-41bcb079ecc1@heusipp.de>
Date: Thu, 30 May 2024 11:47:52 +0200
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
From: =?UTF-8?Q?J=C3=B6rn_Heusipp?= <osmanx@heusipp.de>
Subject: Re: [PATCH] x86/cpu: Provide default cache line size if not
 enumerated
To: dave.hansen@linux.intel.com
Cc: andriy.shevchenko@linux.intel.com, bp@alien8.de,
 linux-kernel@vger.kernel.org, stable@vger.kernel.org, tglx@linutronix.de,
 x86@kernel.org
References: <20240517200534.8EC5F33E@davehans-spike.ostc.intel.com>
Content-Language: en-US
In-Reply-To: <20240517200534.8EC5F33E@davehans-spike.ostc.intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:A21ACE0awT8=;+WxS8Gk3pzlSMgHqO4tQHxZW+Pk
 irbpDGyh4mYLDGiUedcSzbYQsw8QIZgITR8uJROlefgFowpsZnRH2PsizspdupUk0dvodFceC
 fcacXVEBM+hm+ewRZbtIvIReL0lvWyF1efaPRLI/bVY1edUhR7WxbzqNZhbN5SbLGOOW7WVgq
 G/KqOY+UllmBXsCo2yW4MJrZdDm9gB2qSffRLtEL0OpEK81lkb08qlbjfNyefOG4gZRP31LTb
 sLVn8PnsTeseZBbddDkgW5UH+8VpSv258HLJ4ePsUlJWXT5xyqqjT6lqlNJBTNRbvU91sS8Zi
 7oHzgTtvBo8YPt0+aPfQq//wjP+Jt7ZtPNqWjzyw8x6xcioGknw3iTljOZWKzMUHnopYWFX1B
 Nx+bQDuOTcBgJf8T2ME1B7AZ5qQM0Ykw1Od3vFl9Bn6NeCQJF577JUv/AHKQvskqjlP+krTuq
 EaRDoDVbCGPoCE+zsXhtVYTfYDJUkOz+LmSJ2lEu06se26LGxgZDSt5Ha7/O06/+gMPQPe57z
 hcyx3sTNYB+SfRYW6/ah4xgE1b/HE9xJIkCF60w++kt/jLPRBwje+Leykwd205yBzX84CNCu7
 v7q5FNauVlWZ4h2/cIa3ANFh5KYtNPxivrdkzTsffdhjm9A6FWbI7UlH6X5g5F+ZQoowHv2gS
 PbNMTpEm5LAE3LtxioQfKsbeEhco97Uee2OxfsFi3/8UZ32wN1ypuGjjNi4y7g9aKxY1YGXpS
 vDfQ0NpSJtTJV0/S4vBTTDuNQwbLHbWLgkYMEcwDe6bBIkONrI2uF8=


Hello!

> From: Dave Hansen <dave.hansen@linux.intel.com>
>
> tl;dr: CPUs with CPUID.80000008H but without CPUID.01H:EDX[CLFSH]
> will end up reporting cache_line_size()=3D=3D0 and bad things happen.
> Fill in a default on those to avoid the problem.
>
> Long Story:
>
> The kernel dies a horrible death if c->x86_cache_alignment (aka.
> cache_line_size() is 0.  Normally, this value is populated from
> c->x86_clflush_size.
>
> Right now the code is set up to get c->x86_clflush_size from two
> places.  First, modern CPUs get it from CPUID.  Old CPUs that don't
> have leaf 0x80000008 (or CPUID at all) just get some sane defaults
> from the kernel in get_cpu_address_sizes().
>
> The vast majority of CPUs that have leaf 0x80000008 also get
> ->x86_clflush_size from CPUID.  But there are oddballs.
>
> Intel Quark CPUs[1] and others[2] have leaf 0x80000008 but don't set
> CPUID.01H:EDX[CLFSH], so they skip over filling in ->x86_clflush_size:
>
> 	cpuid(0x00000001, &tfms, &misc, &junk, &cap0);
> 	if (cap0 & (1<<19))
> 		c->x86_clflush_size =3D ((misc >> 8) & 0xff) * 8;
>
> So they: land in get_cpu_address_sizes(), set vp_bits_from_cpuid=3D0 and
> never fill in c->x86_clflush_size, assign c->x86_cache_alignment, and
> hilarity ensues in code like:
>
>         buffer =3D kzalloc(ALIGN(sizeof(*buffer), cache_line_size()),
>                          GFP_KERNEL);
>
> To fix this, always provide a sane value for ->x86_clflush_size.
>
> Big thanks to Andy Shevchenko for finding and reporting this and also
> providing a first pass at a fix. But his fix was only partial and only
> worked on the Quark CPUs.  It would not, for instance, have worked on
> the QEMU config.
>
> 1. https://raw.githubusercontent.com/InstLatx64/InstLatx64/master/Genuin=
eIntel/GenuineIntel0000590_Clanton_03_CPUID.txt
> 2. You can also get this behavior if you use "-cpu 486,+clzero"
>    in QEMU.

Tested-by: J=C3=B6rn Heusipp <osmanx@heusipp.de>

See
https://lore.kernel.org/lkml/5e31cad3-ad4d-493e-ab07-724cfbfaba44@heusipp.=
de/


Best regards,
J=C3=B6rn