Received: by 2002:a05:6500:1b8f:b0:1fa:5c73:8e2d with SMTP id df15csp1185659lqb; Thu, 30 May 2024 02:57:39 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVZ3+xbWMUANJhuqt8UQ6n5hl8lHuNhUPzptkfyoyT9HSvatl6IWer7VJg9Jk99ZM3CW2cmm8wBXDhUp0dcaTKiEy6mNbNSEWX4kQo2Tw== X-Google-Smtp-Source: AGHT+IHNL/ximI9o+TnMHkZZ3bVj5BgRZeKBa/KLS9Xj0qp142gFwhu5FOABlZrM8AKLRr7sQc/y X-Received: by 2002:a05:6214:2f86:b0:6ad:75ac:8cd7 with SMTP id 6a1803df08f44-6ae0ccd470fmr14332476d6.61.1717063059650; Thu, 30 May 2024 02:57:39 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1717063059; cv=pass; d=google.com; s=arc-20160816; b=lb4wKtfKg4ANf00svOv1SI2gBP/cR7aspbRDmB8o4u6VwXgRp174g2GcQ3h5Y5dCnG qJW7t+tcA2LGX3jIAyKH6DwAHwpMmCn1GzQiDf3xXQSvEP+V0X1ltKSo115pdVewO54O 2i+f8+g3EWbxzklN3i+WRpyRdbANzew+jPZNL/l21inh+LX1BkyURh1LDXhziOw7jVRQ hm4a/Uc9THa8LZyQFwxp8OcItKLj/2j3snCuJaoZYUYB2bOB8KRL/8BTLe32uo5PbHwc eSeuNeFPXkh3YzJ+dn3y+Vu+1/MJBPXAm2CFBhq2l1SLO6cUwY3Q18OQMOnso77xYJ/X xmcA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=subject:cc:to:from:date:references:in-reply-to:message-id :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :user-agent:feedback-id:dkim-signature:dkim-signature; bh=o9RjPAa9HEpajKmAsJmm5sKFuh+vn34PA2zIfnayZfc=; fh=nn6YpM1RJpDkoHLpshBUvzmbsofXfCQZm7n15BVBSDI=; b=sI1IP7d205ysUCfAZxs8NCwuTRfr3JX2jHhGsBVENZsbqD43JioGvZrCH9idv0sXhA kqvnnYE42D0oJb4Mbv+37EEqT65KPrYvp6zg8WQsciZf8jltPk+/2fLfHeK9XsymCh5f +88zN1nj9qZdGOPCfb0/O9QF4c3t7gT0Pt3UbPxudYxDiFJp5dKm2+7lOUsaOosorciv 58vWDOWl2fzq3V32TserIBFHsfcjLVR8/eikceCUnz/9+BjahYc5o2XiJFMSlLHoPmEZ ZE1dvqM4RP9nficFzS/+YXaDo/7fg1ZkHMndev43sZavpeFeJvnpuqU9W8zvaI3JuoRl ymUA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@arndb.de header.s=fm3 header.b=X5b6b1au; dkim=pass header.i=@messagingengine.com header.s=fm1 header.b=g9imyt2P; arc=pass (i=1 spf=pass spfdomain=arndb.de dkim=pass dkdomain=arndb.de dkim=pass dkdomain=messagingengine.com dmarc=pass fromdomain=arndb.de); spf=pass (google.com: domain of linux-kernel+bounces-194430-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-194430-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=arndb.de Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id 6a1803df08f44-6ad7527ac7dsi9754886d6.187.2024.05.30.02.57.39 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 May 2024 02:57:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-194430-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@arndb.de header.s=fm3 header.b=X5b6b1au; dkim=pass header.i=@messagingengine.com header.s=fm1 header.b=g9imyt2P; arc=pass (i=1 spf=pass spfdomain=arndb.de dkim=pass dkdomain=arndb.de dkim=pass dkdomain=messagingengine.com dmarc=pass fromdomain=arndb.de); spf=pass (google.com: domain of linux-kernel+bounces-194430-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-194430-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=arndb.de Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 82FBA1C2472E for ; Wed, 29 May 2024 16:22:15 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id BEA541836E6; Wed, 29 May 2024 16:22:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=arndb.de header.i=@arndb.de header.b="X5b6b1au"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="g9imyt2P" Received: from wfhigh1-smtp.messagingengine.com (wfhigh1-smtp.messagingengine.com [64.147.123.152]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 41AA8181B91; Wed, 29 May 2024 16:22:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=64.147.123.152 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716999728; cv=none; b=Hp1/cHH04w4dKDZYzy2lmWxPKnKXglw0iLU98BQFiQs0vPRRZelYve7wKh1ri38MJ/EJRG0z+jCicj6j2pFspBEKgAyaOylSquASHJK9G1ZV4sWnJDY+JERjfStuxtDqdN3rybkbYNxRCnPv9KxXN3JQuRbx1vlBwUImdRMPdSU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716999728; c=relaxed/simple; bh=EDIXZx3IPrf64VApzbWtoRjjXMxwcz0IlemDKC5Su68=; h=MIME-Version:Message-Id:In-Reply-To:References:Date:From:To:Cc: Subject:Content-Type; b=dBfv3CCcE6ykCxKFAtV13BC0SZXvodKb6bnjCEKcXYqdoGv0tsep4TtAixxtWsZNYBY8MBPjXYmehC4VjC8Bf3QpSr+fCvM938QVb5SnWttsugWwfhB7TTcAhl0dZ/znMY8vZtcMvyIc8g4pcCJrolL9Zi/bGfswYcEHeKZ4ZDQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arndb.de; spf=pass smtp.mailfrom=arndb.de; dkim=pass (2048-bit key) header.d=arndb.de header.i=@arndb.de header.b=X5b6b1au; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=g9imyt2P; arc=none smtp.client-ip=64.147.123.152 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arndb.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arndb.de Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailfhigh.west.internal (Postfix) with ESMTP id AC4EA1800141; Wed, 29 May 2024 12:22:05 -0400 (EDT) Received: from imap51 ([10.202.2.101]) by compute5.internal (MEProxy); Wed, 29 May 2024 12:22:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm3; t=1716999725; x=1717086125; bh=o9RjPAa9HE pajKmAsJmm5sKFuh+vn34PA2zIfnayZfc=; b=X5b6b1auT1fWZ1GdeIXIsQFsaF ndeJr4MGDDAW8792Fq4GZBaNDE9Qwei/7M2MS9Zz285fvgcG0VAPy2qcoP1kVUdH Xvp1ww1n9ugpkau2ObDrSw5P41RtudOXqlpG9J6Uz3hGC07UF3VFxaaI1uWQaM0l bUupqB3nkYlCwZu5PI2nhjBHtR3fklZPPAFKEIvixQcEJGjqq3FSaOLQBbxQwT6o ZkdTLQ3ElzuqTqDwew+XTDPKvxeBk9sEJb3rz1EGzp0eb66U2GxgTHfN9roocaDW xdSvvzO1sBWrpEAJbGxYeTwWOwUo5hk2rgLR/6u02W4uqQen6TveWRNlIFsw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1716999725; x=1717086125; bh=o9RjPAa9HEpajKmAsJmm5sKFuh+v n34PA2zIfnayZfc=; b=g9imyt2PGyu3k6F1VPXdxZnB8CvqDXOt0FxCbpnVx1Oo tillRsdjwIMlJ5N2NwiBjd4qkjIlPQ45KnaFo+f6IhOyvKd4T08W8emLzraCaUFY 0muyjOklxh87atj51BwcMc4fTWBY1F9K5QfphuKNA0nkUKzvDgL1yVz986R+YAJd Bd2cExyPmLtqsng2m2BZxP4U3wg/b06iGfXV19L5opcj4bvKIB9b2sSi1nEf2bHM sMhRUTcOH6lKz78esv+q5NgyGmU6Kkv1gzp/202yN2r3muJDiHkwG3FZSQddRJgl MfHJQwTMBvFXS0CA5yayJqm00nf349ef5Pkz7gTSUw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrvdekuddgleekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvfevufgtsehttdertderredtnecuhfhrohhmpedftehr nhguuceuvghrghhmrghnnhdfuceorghrnhgusegrrhhnuggsrdguvgeqnecuggftrfgrth htvghrnhepffehueegteeihfegtefhjefgtdeugfegjeelheejueethfefgeeghfektdek teffnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprg hrnhgusegrrhhnuggsrdguvg X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id BEBD6B6008D; Wed, 29 May 2024 12:22:04 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.11.0-alpha0-491-g033e30d24-fm-20240520.001-g033e30d2 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: In-Reply-To: References: <20240529095132.1929397-1-arnd@kernel.org> Date: Wed, 29 May 2024 18:21:44 +0200 From: "Arnd Bergmann" To: "Tony Luck" , "Arnd Bergmann" , "Borislav Petkov" , "Zhuo, Qiuxu" Cc: "James Morse" , "Mauro Carvalho Chehab" , "Robert Richter" , "Marvin Lin" , "Shubhrajyoti Datta" , "Sai Krishna Potthuri" , "linux-edac@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] EDAC, i10nm: make skx_common.o a separate module Content-Type: text/plain On Wed, May 29, 2024, at 18:14, Luck, Tony wrote: >> Linking an object file into multiple modules causes a warning: >> >> scripts/Makefile.build:236: drivers/edac/Makefile: skx_common.o is added to multiple modules: i10nm_edac skx_edac > > In this case there is no practical problem from this double link. The > two modules created: skx_edac.ko and i10nm_edac.ko > are mutually exclusive. A system may load neither, either, but not both > (enforced by the x86_match_cpu() check in each > modules init function). One of the problems here is that each compilation unit implicitly knows the name of the module it gets linked into, via the KBUILD_MODNAME macro. If it gets linked twice, the macro is wrong for at least one of the two, and this can lead to incorrect printk formats and other macro expansions using that as an identifier. A particularly bad case happens when one of the two is built-in while the other one is a loadable module. In this case, the module infrastructure assumes it's always built-in, which can mess up e.g. __exit annotations and THIS_MODULE references. Arnd