Received: by 2002:a05:6500:1b8f:b0:1fa:5c73:8e2d with SMTP id df15csp1250713lqb; Thu, 30 May 2024 05:13:44 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCV4TgP/sQulYXLzSY2ycM6ghrDfx/bEPobnu3F+c8iBE64155NPIsAf3hCFapphRYBqGieNAaoXZMUN2GIXpsrV19afhnTl70v77T9Rjg== X-Google-Smtp-Source: AGHT+IEdbKIQWTlIfGG4zuL4ssml5jdvQTamU19We3kI4Gvz4f63Gx5xVzLtztHhbf+dHroiomQd X-Received: by 2002:a50:d6d4:0:b0:574:eb0f:df9b with SMTP id 4fb4d7f45d1cf-57a17833cb5mr1800195a12.14.1717071223970; Thu, 30 May 2024 05:13:43 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1717071223; cv=pass; d=google.com; s=arc-20160816; b=PZLO5pRy3iomOczrQ1xSLcjaLBqh1nB0QQGDfZbWs/ZhGA3SgPFeHUR+UBU2Nlbq1/ O/C0FbTBz9F8jrQBSXeQAUsFTIDAHgbDu7QTAfnC51DoB7ZiIsLOlpQLQtfShpV4yKTp M/fYgRb59C63jdthhLbkmBziiup1vukShsqT/hKZl1o42ZH76l6gHYPWt/e8oR5MRwe8 85anyVEq5V4moRLwp97j7v22CUi0vQfsU7u+FHPuFdL13ETlxYt8xHIEyXxcHUqX4I1Z 05WIYLaryv7Io7RZJHGfZ//GSBM3meWOsDdVyajrYKK82Z5pCx/3YFAP2Fli6g7RVVgF 1CRA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=kagvJUvLZ8HGDcrz3C6I73rh/WuqRfvQQKO8Bga9nvc=; fh=bzzldG8QF8BhG8AABpDsx7tF2Nk4hkzdIFjXjePIfG8=; b=KCv+WUejs5kTB8UTn/IU3pYAxUdv+IAgeZ3CAng61AJcZviqNvu5KZJ8jotqymzNWf KXuyPXcf4FG+eirZA4jR9D1ZK655GpEgchGdolKhk6n3613X1T58VUCxICCsRrm6SBiE +o8DkDYGGQa1VpE3w9CGRgXc/Ixn2yKVqpY2ijMBvpu9c18mzSRLBmTcOv8By02yZWRP ohAzjAQkx8WTedTMKenbv07PNXUJZk8mgOEo1nD7Vrl9QG4eMuCWO9Dp6RZL8KMO4wfq mjcPoNisGTHqm0tV45/u/nBpMXWbp5z/iA05wiH0tgpjLpqb8fFPA06/oWNdsVrZaMUi FktQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=D7KoizyL; arc=pass (i=1 spf=pass spfdomain=lunn.ch dkim=pass dkdomain=lunn.ch dmarc=pass fromdomain=lunn.ch); spf=pass (google.com: domain of linux-kernel+bounces-195347-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-195347-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id 4fb4d7f45d1cf-57855caf203si7599871a12.190.2024.05.30.05.13.43 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 May 2024 05:13:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-195347-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=D7KoizyL; arc=pass (i=1 spf=pass spfdomain=lunn.ch dkim=pass dkdomain=lunn.ch dmarc=pass fromdomain=lunn.ch); spf=pass (google.com: domain of linux-kernel+bounces-195347-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-195347-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 981971F26BF9 for ; Thu, 30 May 2024 12:13:43 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id B60701822ED; Thu, 30 May 2024 12:13:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="D7KoizyL" Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C92BF15B979; Thu, 30 May 2024 12:13:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717071216; cv=none; b=ETfkEwg4Tv6gW3Kd3Ptqqh/WQaZr6hjIicGiQasSoYzAjJW3/7fLfp49CqUOaWlXniN/638wffAChbBJvxsQ7i7aLSQN6H8tJQK9QCOXXd7hQrDIOIKeloxbscxPTe2kKh2yWmnVL9xHwii9auiATn0mxVemTQ736K0g9imt++Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717071216; c=relaxed/simple; bh=FhjFGspdyvHbjBhX6O/1GSnPkUuNlBcQYSFV7ga+EmM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=SctyLYxBKZ0W3YQwDjC52dpqUVC/C71G0Js+p7DCHt0C0GN5Y6Q13KIHgGz3yvEbkaRaOtBa1PNzpW1QiNz3U1i6zPZHzBAQ4KGIGKj1Qh5XWBogaB7FFghCOfY58B3SapbEi030WKUrn368I5jUkj+ExcU0iBksuFACx1NexdQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=D7KoizyL; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=kagvJUvLZ8HGDcrz3C6I73rh/WuqRfvQQKO8Bga9nvc=; b=D7KoizyLmXhOvLhPvQLB47tnmt Zr7Pd9pHd/ysaLl6n7GeXaPSdDk2z7vg5VhRqYs6ddABQVhoeXQ+WRtot71Rosxc23CbHHoQTRKSZ vz9vCxx/l25jRuu5orIiWdRWGThqmq/a++iZI8Bk2VlKmUbr6W13iCHu7M/yR6FD7wJ4=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1sCeer-00GLNR-4M; Thu, 30 May 2024 14:13:25 +0200 Date: Thu, 30 May 2024 14:13:25 +0200 From: Andrew Lunn To: Matthias Schiffer Cc: Dan Carpenter , Linus Walleij , Bartosz Golaszewski , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Gregor Herburger , linux@ew.tq-group.com Subject: Re: [PATCH 8/8] gpio: tqmx86: fix broken IRQ_TYPE_EDGE_BOTH interrupt type Message-ID: References: <2c265b6bcfcde7d2327b94c4f6e3ad6d4f1e2de7.1716967982.git.matthias.schiffer@ew.tq-group.com> <8689fbcd-3fa3-410b-8fc9-7a699bf163b8@moroto.mountain> <0e971f0b885bd360e33ef472d96e3d9e0ab56405.camel@ew.tq-group.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0e971f0b885bd360e33ef472d96e3d9e0ab56405.camel@ew.tq-group.com> > Currently, the driver only supports COM Express modules, where IRQs 0-3 correspond to GPIOs 4-7, > while GPIOs 0-3 don't have interrupt support. We will soon be mainlining support for our SMARC > modules, which have up to 14 GPIOs, and (on some families) IRQ support for all GPIOs (IRQs 0-13 > correspond to GPIOs 0-13). > > New interrupt config and status registers have been introduced to support more IRQs - up to 4 config > registers (2 bits for each IRQ) and 3 status registers (IRQs 0-3 in the first one, 4-11 in the > second one, 12-13 in the third one... so this part is a bit more convoluted than just "hwirq % 4") Depending on how different it is, you could consider a second driver, rather than make this driver more complex. Andrew