Received-SPF: pass (google.com: domain of linux-kernel+bounces-195391-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Thu, 30 May 2024 14:53:50 +0200
From: Kory Maincent <kory.maincent@bootlin.com>
To: Sai Krishna Gajula <saikrishnag@marvell.com>
Cc: Florian Fainelli <florian.fainelli@broadcom.com>, Broadcom internal
 kernel review list <bcm-kernel-feedback-list@broadcom.com>, Andrew Lunn
 <andrew@lunn.ch>, Heiner Kallweit <hkallweit1@gmail.com>, Russell King
 <linux@armlinux.org.uk>, "David S. Miller" <davem@davemloft.net>, Eric
 Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, Paolo
 Abeni <pabeni@redhat.com>, Richard Cochran <richardcochran@gmail.com>, Radu
 Pirea <radu-nicolae.pirea@oss.nxp.com>, Jay Vosburgh
 <j.vosburgh@gmail.com>, Andy Gospodarek <andy@greyhouse.net>, Nicolas Ferre
 <nicolas.ferre@microchip.com>, Claudiu Beznea <claudiu.beznea@tuxon.dev>,
 Willem de Bruijn <willemdebruijn.kernel@gmail.com>, Jonathan Corbet
 <corbet@lwn.net>, Horatiu Vultur <horatiu.vultur@microchip.com>,
 "UNGLinuxDriver@microchip.com" <UNGLinuxDriver@microchip.com>, Simon Horman
 <horms@kernel.org>, Vladimir Oltean <vladimir.oltean@nxp.com>, Thomas
 Petazzoni <thomas.petazzoni@bootlin.com>, "netdev@vger.kernel.org"
 <netdev@vger.kernel.org>, "linux-kernel@vger.kernel.org"
 <linux-kernel@vger.kernel.org>, "linux-doc@vger.kernel.org"
 <linux-doc@vger.kernel.org>, Maxime Chevallier
 <maxime.chevallier@bootlin.com>, Rahul Rameshbabu <rrameshbabu@nvidia.com>
Subject: Re:  [PATCH net-next v13 12/14] net: ptp: Move ptp_clock_index() to
 builtin symbol
Message-ID: <20240530145350.6341746f@kmaincent-XPS-13-7390>
In-Reply-To: <BY3PR18MB47074528CBB38F55A3F58A19A0F32@BY3PR18MB4707.namprd18.prod.outlook.com>
References: <20240529-feature_ptp_netnext-v13-0-6eda4d40fa4f@bootlin.com>
	<20240529-feature_ptp_netnext-v13-12-6eda4d40fa4f@bootlin.com>
	<BY3PR18MB47074528CBB38F55A3F58A19A0F32@BY3PR18MB4707.namprd18.prod.outlook.com>
Organization: bootlin
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Hello Sai,

On Thu, 30 May 2024 11:23:10 +0000
Sai Krishna Gajula <saikrishnag@marvell.com> wrote:

> > Move ptp_clock_index() to builtin symbols to prepare for supporting get=
 and
> > set hardware timestamps from ethtool, which is builtin.
> >=20
> > Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>

> >  }
> > +
> > +int ptp_clock_index(struct ptp_clock *ptp) {
> > +	return ptp->index;
> > +}
> > +EXPORT_SYMBOL(ptp_clock_index);
> >  =20
> Please check the "build_clang - FAILED", "build_32bit - FAILED" build err=
ors.

Could you be more explicit? Which config are you using?
What is the build error?

I don't really see how this patch can bring a 32bit or clang build error.=20

Regards,
--=20
K=C3=B6ry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com