Received-SPF: pass (google.com: domain of linux-kernel+bounces-195420-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Thu, 30 May 2024 13:27:40 +0000
From: "Dr. David Alan Gilbert" <linux@treblig.org>
To: Hans Verkuil <hverkuil@xs4all.nl>
Cc: mchehab@kernel.org, ming.qian@nxp.com, eagle.zhou@nxp.com,
	digetx@gmail.com, jonathanh@nvidia.com, linux-tegra@vger.kernel.org,
	linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] media: tegra-vde: remove unused struct
 'tegra_vde_h264_frame'
Message-ID: <Zlh-zGV7U5rheUbY@gallifrey>
References: <20240525000146.282500-1-linux@treblig.org>
 <20240525000146.282500-4-linux@treblig.org>
 <4496bc6e-e5c0-4f86-b9c1-37ad2d2b687d@xs4all.nl>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
In-Reply-To: <4496bc6e-e5c0-4f86-b9c1-37ad2d2b687d@xs4all.nl>
User-Agent: Mutt/2.2.12 (2023-09-09)

* Hans Verkuil (hverkuil@xs4all.nl) wrote:
> On 25/05/2024 02:01, linux@treblig.org wrote:
> > From: "Dr. David Alan Gilbert" <linux@treblig.org>
> > 
> > 'tegra_vde_h264_frame' has been unused since
> > commit 313db7d235a0 ("media: staging: tegra-vde: Remove legacy UAPI
> > support").
> > 
> > Remove it.
> > 
> > Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
> > ---
> >  drivers/media/platform/nvidia/tegra-vde/h264.c | 5 -----
> >  1 file changed, 5 deletions(-)
> > 
> > diff --git a/drivers/media/platform/nvidia/tegra-vde/h264.c b/drivers/media/platform/nvidia/tegra-vde/h264.c
> > index cfea5572a1b8..d8812fc06c67 100644
> > --- a/drivers/media/platform/nvidia/tegra-vde/h264.c
> > +++ b/drivers/media/platform/nvidia/tegra-vde/h264.c
> > @@ -19,11 +19,6 @@
> >  #define FLAG_B_FRAME		0x1
> >  #define FLAG_REFERENCE		0x2
> >  
> > -struct tegra_vde_h264_frame {
> > -	unsigned int frame_num;
> > -	unsigned int flags;
> > -};
> > -
> >  struct tegra_vde_h264_decoder_ctx {
> >  	unsigned int dpb_frames_nb;
> >  	unsigned int dpb_ref_frames_with_earlier_poc_nb;
> 
> There is one more reference to this, that also can be dropped:
> 
> $ git grep tegra_vde_h264_frame
> drivers/media/platform/nvidia/tegra-vde/vde.h:struct tegra_vde_h264_frame;

Thanks! v2 just sent (where I also fixed a typo in the first patch
in the series's title).

Dave

> Regards,
> 
> 	Hans
> 
-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/