Received-SPF: pass (google.com: domain of linux-kernel+bounces-195474-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
From: Diederik de Haas <didi.debian@cknow.org>
To: David Woodhouse <dwmw2@infradead.org>,
 Lu Baolu <baolu.lu@linux.intel.com>, Joerg Roedel <joro@8bytes.org>,
 Will Deacon <will@kernel.org>
Cc: Robin Murphy <robin.murphy@arm.com>, iommu@lists.linux.dev,
 linux-kernel@vger.kernel.org, Diederik de Haas <didi.debian@cknow.org>
Subject:
 device_def_domain_type documentation header does not match implementation
Date: Thu, 30 May 2024 15:57:38 +0200
Message-ID: <14311965.TaHA55BQu8@bagend>
Organization: Connecting Knowledge
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="nextPart3343604.Wtvs3CB2mS";
 micalg="pgp-sha256"; protocol="application/pgp-signature"

--nextPart3343604.Wtvs3CB2mS
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"; protected-headers="v1"
From: Diederik de Haas <didi.debian@cknow.org>
Date: Thu, 30 May 2024 15:57:38 +0200
Message-ID: <14311965.TaHA55BQu8@bagend>
Organization: Connecting Knowledge
MIME-Version: 1.0

Hi,

While looking into ``drivers/iommu/intel/iommu.c::device_def_domain_type`` 
function I noticed a discrepancy between the documentation header and the 
implementation.

``@startup: true if this is during early boot``
0e31a7266508 ("iommu/vt-d: Remove startup parameter from 
device_def_domain_type()")
removed the ``startup`` function parameter

returns ``IOMMU_DOMAIN_DMA: device requires a dynamic mapping domain``
28b41e2c6aeb ("iommu: Move def_domain type check for untrusted device into 
core") 
moved the possible return of ``IOMMU_DOMAIN_DMA`` to ``drivers/iommu/iommu.c``

But neither updated the documentation header.

Cheers,
  Diederik
--nextPart3343604.Wtvs3CB2mS
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part.
Content-Transfer-Encoding: 7Bit

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQT1sUPBYsyGmi4usy/XblvOeH7bbgUCZliF0gAKCRDXblvOeH7b
bn8AAQCiDxcxgUIErkiC9QpJNmPLh6SlxKa2ytIrBp/fqzJBpAD+OOGPlgXUq0ch
pUs535Ep1y8OsfvhKt16hBWvJC2dIAM=
=/+oC
-----END PGP SIGNATURE-----

--nextPart3343604.Wtvs3CB2mS--