Received-SPF: pass (google.com: domain of linux-kernel+bounces-195522-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Precedence: bulk
MIME-Version: 1.0
References: <20240528113243.827490-2-maennich@google.com>
In-Reply-To: <20240528113243.827490-2-maennich@google.com>
From: Masahiro Yamada <masahiroy@kernel.org>
Date: Thu, 30 May 2024 23:30:09 +0900
Message-ID: <CAK7LNAS-sCFCh6Hyrj4qra6b-Bx4HjQLt_FfJb=FB2xUWE_YiA@mail.gmail.com>
Subject: Re: [PATCH] kheaders: explicitly define file modes for archived headers
To: =?UTF-8?Q?Matthias_M=C3=A4nnich?= <maennich@google.com>
Cc: linux-kernel@vger.kernel.org, kernel-team@android.com, gprocida@google.com, 
	stable@vger.kernel.org, linux-kbuild@vger.kernel.org, 
	Joel Fernandes <joel@joelfernandes.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, May 28, 2024 at 8:33=E2=80=AFPM Matthias M=C3=A4nnich <maennich@goo=
gle.com> wrote:
>
> From: Matthias Maennich <maennich@google.com>
>
> Build environments might be running with different umask settings
> resulting in indeterministic file modes for the files contained in
> kheaders.tar.xz. The file itself is served with 444, i.e. world
> readable. Archive the files explicitly with 744,a+X to improve
> reproducibility across build environments.
>
> --mode=3D0444 is not suitable as directories need to be executable. Also,
> 444 makes it hard to delete all the readonly files after extraction.
>
> Cc: stable@vger.kernel.org
> Cc: linux-kbuild@vger.kernel.org
> Cc: Masahiro Yamada <masahiroy@kernel.org>
> Cc: Joel Fernandes <joel@joelfernandes.org>
> Signed-off-by: Matthias Maennich <maennich@google.com>
> ---

Applied to linux-kbuild.
Thanks!


--=20
Best Regards
Masahiro Yamada