Received-SPF: pass (google.com: domain of linux-kernel+bounces-195532-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
From: Kalle Valo <kvalo@kernel.org>
To: "Nemanov, Michael" <michael.nemanov@ti.com>
Cc: Krzysztof Kozlowski <krzk@kernel.org>,  Johannes Berg
 <johannes.berg@intel.com>,  Breno Leitao <leitao@debian.org>,  Justin
 Stitt <justinstitt@google.com>,  Kees Cook <keescook@chromium.org>,
  <linux-wireless@vger.kernel.org>,  <linux-kernel@vger.kernel.org>,
  Sabeeh Khan <sabeeh-khan@ti.com>
Subject: Re: [PATCH 08/17] Add main.c
References: <20240521171841.884576-1-michael.nemanov@ti.com>
	<20240521171841.884576-9-michael.nemanov@ti.com>
	<cfe33bf1-9df3-4d02-b4ed-e29a430b106d@kernel.org>
	<456c8076-1e3a-4cc9-895c-e707e68fe610@ti.com>
Date: Thu, 30 May 2024 17:37:41 +0300
In-Reply-To: <456c8076-1e3a-4cc9-895c-e707e68fe610@ti.com> (Michael Nemanov's
	message of "Thu, 30 May 2024 14:54:26 +0300")
Message-ID: <87bk4nwekq.fsf@kernel.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain

"Nemanov, Michael" <michael.nemanov@ti.com> writes:

> On 5/22/2024 12:46 PM, Krzysztof Kozlowski wrote:
>> ... > +} > + > +static int read_version_info(struct cc33xx *cc) > +{
>> > + int ret; > + > + cc33xx_info("Wireless driver version %s",
>> DRV_VERSION); Drop > + > + ret =
>> cc33xx_acx_init_get_fw_versions(cc);  > + if (ret < 0) { > +
>> cc33xx_error("Get FW version FAILED!"); > + return ret; > + } > + >
>> + cc33xx_info("Wireless firmware version %u.%u.%u.%u", > +
>> cc->all_versions.fw_ver->major_version, > +
>> cc->all_versions.fw_ver->minor_version, > +
>> cc->all_versions.fw_ver->api_version, > +
>> cc->all_versions.fw_ver->build_version); > + > +
>> cc33xx_info("Wireless PHY version %u.%u.%u.%u.%u.%u", > +
>> cc->all_versions.fw_ver->phy_version[5], > +
>> cc->all_versions.fw_ver->phy_version[4], > +
>> cc->all_versions.fw_ver->phy_version[3], > +
>> cc->all_versions.fw_ver->phy_version[2], > +
>> cc->all_versions.fw_ver->phy_version[1], > +
>> cc->all_versions.fw_ver->phy_version[0]); > + > +
>> cc->all_versions.driver_ver = DRV_VERSION; Drop
>
> You mean drop the trace? Will exposing FW/PHY versions via debugfs be
> OK?

I'm guessing the comment was about DRV_VERSION. We don't use any version
strings for drivers as they are useless.

BTW please check your quoting style, it is hard to read your replies.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches