Received-SPF: pass (google.com: domain of linux-kernel+bounces-195569-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <3b0baf88-c9cb-49c0-a6e1-acb581403f52@intel.com>
Date: Thu, 30 May 2024 08:08:52 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v4 02/16] selftests/resctrl: Calculate resctrl FS derived
 mem bw over sleep(1) only
To: =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>
CC: <linux-kselftest@vger.kernel.org>, Shuah Khan <shuah@kernel.org>, "Babu
 Moger" <babu.moger@amd.com>, =?UTF-8?Q?Maciej_Wiecz=C3=B3r-Retman?=
	<maciej.wieczor-retman@intel.com>, LKML <linux-kernel@vger.kernel.org>,
	Fenghua Yu <fenghua.yu@intel.com>, Shuah Khan <skhan@linuxfoundation.org>
References: <20240520123020.18938-1-ilpo.jarvinen@linux.intel.com>
 <20240520123020.18938-3-ilpo.jarvinen@linux.intel.com>
 <04d0a5d6-82fa-4cc7-bd80-ee5cbd35f0c3@intel.com>
 <ea0c86b9-ae77-c2d9-b52b-239ae42603e8@linux.intel.com>
 <d8063ee7-1744-45a2-b6b9-506e68106baf@intel.com>
 <b029db88-2e09-0b4a-f46a-84b5e535f178@linux.intel.com>
 <904aa442-9fc5-c6dd-f367-07b197085f7b@linux.intel.com>
 <700e3df4-4e10-4870-a1df-49d4616cbc45@intel.com>
 <0f294d43-e704-d1de-06ee-97bb81ebb9cb@linux.intel.com>
From: Reinette Chatre <reinette.chatre@intel.com>
Content-Language: en-US
In-Reply-To: <0f294d43-e704-d1de-06ee-97bb81ebb9cb@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?M0VPRjdvdHRqd0I2aldmQkd1MjhqZHdlS1VjY1hCQURWbHN0eUFHNXFwYktJ?=
 =?utf-8?B?V3FkbVZUUytncjVEdUdtSkpENmxIZnRGV1U2anI5T2VTb0xoZXcyWGxKcWF4?=
 =?utf-8?B?NUhyMVJia0IvRXpKRFVQdGpCUEhBR1dDYzJ4QVNBd0M2WDhxcm5xMmUwNzNa?=
 =?utf-8?B?RmxhVzlYbFlZeUt3a05xdk9iTWdjTUV2b3hLNU5ZUUM1Z1I4ajNCUDN0cEE2?=
 =?utf-8?B?aXRla0dCWkM4T3VzQzd2L1JxUUZiZGpOT2tjYUdQUUFuUFRUZDR4YjZJUitT?=
 =?utf-8?B?T3VWUWNoamRzUHRBaUc3U3h0YlcyTXhGblNWazFoZHIvcnJNUllmaXJXeVdq?=
 =?utf-8?B?a1g4K0Q5cjhLMGZIc0FIbm9rbGR3bXhrcXA3aUdwY0cxU082Mk9OZi9MT1dk?=
 =?utf-8?B?aEdJR2kreWhUdStqQzA2S0NCTWszLzhXZlFoSHhyTm1PdGxaSkVmeWtuMmQ0?=
 =?utf-8?B?RmMySEkwUnNlS2VVV2tPcWRxb0RKUmhJNGNYZEtwUyt1OHV0Yk1sOHZLdEI3?=
 =?utf-8?B?QTlwQldLTWp2Qzg1ZWpZNjZheHhjQzFhSDFqSXA3Y0E0WWtoODNiTFduak9W?=
 =?utf-8?B?Vkx3azhEZEFjKzh1YU1TVWdOdXVCOU1LSWFrUUhuR2dEZjlidTNHSk1XVmYx?=
 =?utf-8?B?NEFxb2l1UG9jdGVFRm1Hcm1ldE9QcmsvS1hVQWlYWUdiYnZzcE9kaU5lZ3NP?=
 =?utf-8?B?UjFNUUcxbmZML3JBZHE5ZThnTDdQMWN2MVBkSStQaEpjc0hpc0xTNnp2RkE1?=
 =?utf-8?B?b2YyUkdjMmVyMHFtVS9Wci9QM2l5ZE9xOGFYdDhHcFhqQU4ySEc5S2kxamtB?=
 =?utf-8?B?T3RWcjc3UU5PVUZ3T1U4b0pvbUpHNzVybmo5R0N0dFZacWhJT2dRUWdWOGdH?=
 =?utf-8?B?WjNhMiszZGtycEk5SHprNXhuZXlac1BwZDFvbEhOQ2NBbmVWbE1HVWxubnN6?=
 =?utf-8?B?ZFJ3Q01TN2hKYXRmWWo2QzNIczRDb3llRTZFUXIxWkoya3dudWJ0WUFDQjB5?=
 =?utf-8?B?RkYxdGM2RHNoNndsYnh1Vk05NWVOWUw5dHRrY2lhajczcStHOURxQm41bkF6?=
 =?utf-8?B?UnNzZmhTUHBzc095WGxZZzQ4WUpWN0k2V2NXSS8xYUNUZmtLNkxwY3hRNGFO?=
 =?utf-8?B?RGsxN0hIS0NlalNGbWppbTBhZnFTeHZjakk2SHk1RHlNWlMvYkZOQXFoNGdq?=
 =?utf-8?B?MWkvZmlndG8xalhqV0JmQitXLzFqbHVuUXVjdDVselF1L0MyVzhWU25YUGVK?=
 =?utf-8?B?N1ZqK1I2WVZnSDlFQUZ6TUxTcHh5VFdoc25OSm53T1Z2NWhNSnBEbTdMcWM2?=
 =?utf-8?B?c3ZhZjF6UWNQaThYS1hZYlRPQWUzcXdHY0swZ2VIUGt4a2I0YktsUXlFL3Ix?=
 =?utf-8?B?enhOeTVHTWpDMFBHQ1RCVi9CRU1HYkQxbSs3cUdJK3V1VnJCWjIvZFVGYlU3?=
 =?utf-8?B?Q24rcFVLakw0K2F5djZVWE9RZmttdlFtM0wxbnNjYmlLVXAwa3l0MHNxRUhX?=
 =?utf-8?B?bEsxY3cxZGJTc2E0bjQ3QndRMlM4d20wTGl4Ym5oYUp2T0Fid2dhUU1PajZ3?=
 =?utf-8?B?b0VEWCtudlVDbUVQNGJNcU9JQnVGclduVUU4Zy9xUlF5aENTdVFTeU1IYUVx?=
 =?utf-8?B?RmZhMHRnRThDNm1KdzBHc2FJWkFHUXlqdnZJaEVzSkZrVnhwaTY5WVh0VE1O?=
 =?utf-8?B?VlZPM25HcDUrb0NxOEV6SjJoTWhMNEtia2UvNzBIUElsSi9qTloxK1lpTGkz?=
 =?utf-8?B?TmJjZTF4TFRQdCtrbksvSjh6enRrcVNPSnhKeVhMYmljRFg5ZDJ4dVV1Wits?=
 =?utf-8?B?bTUrU2VtcTVoU1lCSGRnQkppdWRMcUt1a1F2UVE4R2tJcHBvWWxPcVVMbjdI?=
 =?utf-8?B?ZVM1VGVtazhPUHVmZlFsK1FYMmxkVjZWS0ZHM1pvK0JjTVAzcFUzOWZmUjA4?=
 =?utf-8?B?N2ZKdlpHbHNOVm5kZUo0SFdCZ2cyZ1d1MWQwck00M3BGeGs4RHM4NnBCLzJr?=
 =?utf-8?B?cjNJUnFoU21lanVPRFQ4a1BlNFBlbWtHbkNVZUsvMVl0aE5NOVVGWjRiTFdC?=
 =?utf-8?B?YXdYa3FtODdyU1g5V1A5bVlrekI4QXRyUWw3dWo0Zk9rSGNMaDZwbGJQTHVx?=
 =?utf-8?B?cHpqUWNYTnU4cGw2TmMrYkQwWXg2bWVPVzJIYWlzb2Q0YzhCSGdSY05wbGR1?=
 =?utf-8?B?Ync9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 89e9ad6f-8fee-4b89-ef43-08dc80ba6bbf
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 May 2024 15:08:54.0977
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: O91OMZK7lrgEXfzRhM+y4fD3UEiRuja4iL8AQFSvWdrPwqvwO+FQyQHqWmmWHCxANx3uyz5iSWyYeuCBvcmXE6W5kz+A1/8tX5J4VXyq1ts=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB4788
X-OriginatorOrg: intel.com

Hi Ilpo,

On 5/30/24 4:11 AM, Ilpo Järvinen wrote:
> On Tue, 28 May 2024, Reinette Chatre wrote:
>> On 5/28/24 3:19 AM, Ilpo Järvinen wrote:
>>> On Fri, 24 May 2024, Ilpo Järvinen wrote:
>>>> On Fri, 24 May 2024, Reinette Chatre wrote:
>>>>> On 5/24/24 12:57 AM, Ilpo Järvinen wrote:
>>>>>> On Thu, 23 May 2024, Reinette Chatre wrote:

..

>>>>> It is not necessary to open and close the file every time a value needs
>>>>> to be read from it.
>>>
>>> I'm bit unsure where to go with this. While I could change the code to
>>> match what you described, I realized with the two files approach there's
>>> no need to do even review/lseek() call during the measurement. It might
>>> not be very significant compared with the open that was there initially
>>> but it's still extra.
>>
>> We are discussing the resctrl selftests that will accompany the resctrl
>> filesystem in the kernel. When in doubt on how to interact with resctrl users
>> use the selftests as reference. Needing to open and close a resctrl file
>> every time a value needs to be read from it is not the correct guidance.
> 
> That's actually a different goal from the earlier, but I've no problem
> adjusting to it.
> 
> Initially, this open/close() refactoring was made because of another goal
> which was to avoid doing extra syscalls during the test.
> 

It is not clear what you hint at here. Reading twice from an open file
should not be a huge adjustment so it is not clear to me how this results
in a big change to this work. As I understand this does match with original goal
of reducing syscalls since the file need not be opened and closed twice.

Reinette