Received-SPF: pass (google.com: domain of linux-kernel+bounces-195570-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <851fd0e0-17d5-4b2e-b99a-d14b49161ca5@intel.com>
Date: Thu, 30 May 2024 08:09:02 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v4 14/16] selftests/resctrl: Remove mongrp from MBA test
To: =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>
CC: <linux-kselftest@vger.kernel.org>, Shuah Khan <shuah@kernel.org>, "Babu
 Moger" <babu.moger@amd.com>, =?UTF-8?Q?Maciej_Wiecz=C3=B3r-Retman?=
	<maciej.wieczor-retman@intel.com>, LKML <linux-kernel@vger.kernel.org>,
	Fenghua Yu <fenghua.yu@intel.com>, Shuah Khan <skhan@linuxfoundation.org>
References: <20240520123020.18938-1-ilpo.jarvinen@linux.intel.com>
 <20240520123020.18938-15-ilpo.jarvinen@linux.intel.com>
 <f2a8e8ad-311c-4302-a200-03fc9f02b20b@intel.com>
 <feec5ce3-cad9-6ace-3588-67e7da9641d6@linux.intel.com>
Content-Language: en-US
From: Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <feec5ce3-cad9-6ace-3588-67e7da9641d6@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TDl0QTV0SUhnSnZwcTJwdHNDcVM2V2NOM3pjYlZaRkhqbVJ5RFIzYWRJQk83?=
 =?utf-8?B?UzNFL3lzMHUzVTU0b25wRHBURGhka295YkJFMkhpWngyZk1YR2p5YmZTV3F4?=
 =?utf-8?B?anlXenoxTjRFZllKMWdZZmtMNkFCZ2syTm9peFlRamFKOEVkMjZua3lJNUZo?=
 =?utf-8?B?OGZJelZiTElkRXlxcmt1UGNQRkJuSXFlbm5vaGdyUHNKa0hNUG1XQ1BqQVNp?=
 =?utf-8?B?YnpneDZmUFA2SnZRLzFHOHErMTk0S2V2cnpMeTlYbG1yMGE0S1p3V09oTFIz?=
 =?utf-8?B?T3RsbXNJekx4V2lQcHBvQVpOZ00yM09HU29hYlB1eWE0c3ErQitkVFBNQWJr?=
 =?utf-8?B?bksyb056dmFqb3doVGU5aTdRQ0lteDRsdE9TNnJqekdwVVZRM0MvL2lIU0Fv?=
 =?utf-8?B?VXpKRm9sbHovYUkxNG8yTm8vc1lXRGt3Qm9xbG05ektkZ1RISU04ditwaFk0?=
 =?utf-8?B?WHZablJrdzc5RmdIK2ZmejRFTWVrWmlGL1JIb0U5Y0ZpVDhxL1NBQi9zMWRw?=
 =?utf-8?B?TVhWazhhTkpKaEtFOW5seFJBaDFEVS9JQjcreTYzUVhNM3NBSUhGZ0tBYTl2?=
 =?utf-8?B?RVc3ZEtWWkc2KytkSis1MERsQXZjY1k1c0VDK08yd0FwU2Irb01YV0dQWXlw?=
 =?utf-8?B?aDdvR0ZyY1ZNZDZWNHdjQUdyOVkyUEk4NnR3eGVXeW04SWFRTW5mNEFCSE9D?=
 =?utf-8?B?aEtuUHBDZ0lDM05iV1djenc5WWpjWkNwa0ZMMFhiQm5GYzB4S2V2bENodWxG?=
 =?utf-8?B?RlJjM0xpdDJUNkt5SzYrTjBKVW1kY2k5RndxQ0JGSU02cWVKaytCOXBHRjdM?=
 =?utf-8?B?NUJFR3BSaEdXdjA5OFl0clUxUHV5YUtSajM3R0hMazJpTkdOVG5vZE4rM0FK?=
 =?utf-8?B?ZnlSbGV4eXpQZzdmR3NRTmxTdGJ1L0JIRHpEQW1DUURYYTZZTFZ3TXJhblV4?=
 =?utf-8?B?M3hlalJZVDRlTWdmMHgxYko5UEdyU0NRUHZNeW0xOFhXUmxqMXI3L0xCWDhr?=
 =?utf-8?B?UUdUYXhrY29LcEdlWWFCRVhVRDBydjNod2hjRWl4dnV0c2ZqdUY4YWUzbm9X?=
 =?utf-8?B?c3YvYW45TnZXZGlwRkYvNk1lSU9pVndBdE5Fck9yNnh5K0NlSE5zM296NDRY?=
 =?utf-8?B?SHk5LzdPeHZCK0dXcFBMa2lwL2VJL2pqbjBKVHFla0tFSlVObHdBd1IxUjNW?=
 =?utf-8?B?aUJxK09oNEJxUnBMZUk1bUxpdTFPTGo4OXUrMDEyYVpFN3Fjd3BCNFA4Z0tr?=
 =?utf-8?B?bWhORjhQR0JWaFJvU28rcUZRbXRoZnB5Rk8rdHhHeGxxbVhQNmRZbU5MOWll?=
 =?utf-8?B?akFuN2ZHMU9XRWJHdDEwditpVFhxMGY5NWpYaThYZG0rUUJWcmJUN2dEU1pa?=
 =?utf-8?B?RFJ2bzRKVTQ3d25DeVRuM0EwTXhuVXJYWElaOThGQTZhZ0lQdFNVblliZE1Q?=
 =?utf-8?B?OFE2d0hEdFZwT1F1em5JamtDRmI0WXBTeTJNSFhDK3AyN1hsK0lwc2xJV2pu?=
 =?utf-8?B?YjZ6R3FjMEk1dUFrUWVxbG9XbnY0UHNxTkZ6R09EV3d6S2VYbmExQWUvY2ty?=
 =?utf-8?B?WllyMXY1Um5rcVdvNjE1ZXNuK2VjL1ptNy9kenZGd0pQKzA2UDRIRUxER1Nl?=
 =?utf-8?B?OUJiY2F4Q0lIWW9OR05McXBPOTBWbjFPNHlRSVRDRjJzd1BWZ2ZuWHlCazJH?=
 =?utf-8?B?UzBMYktxOGpPbDFBM25neE9kTnBIdFpvVkl1RFcwdE00UFVPa1lpTStmWmk1?=
 =?utf-8?B?NDlkVkZwek9iRlZuZmVlYm5Qb0Rnc2JVUHkyT0VrQ1FRV0g2OUxmb0RZQlF6?=
 =?utf-8?B?S21DV011ZXljb0lsT0lmd3FQcG1YZmZ2WFk3U053RFZObXlQbEpRNGhOeGlm?=
 =?utf-8?B?bFROT0YrTDVqRTBFaWVvZE5EK3FIS21zVlQxN0xNTDdPeVRaK2QrUFJ4VUg2?=
 =?utf-8?B?OHZCdEwrTThISk1vbTdvTFVyaHJqUUg5aUpHRTZQMDYzcDFTYjFMcGwxVCtF?=
 =?utf-8?B?dm9UU0wyTzdMLzVFVjJkKzE5V1RwcitHU1ZYNmVpaFNCS042VEs5bG1pU3R6?=
 =?utf-8?B?SXcwV01KamxGb3ZXcnhuL0tvQ2U2TTByTUl6dkZqL0FYVXBDdDJLNksvSktr?=
 =?utf-8?B?RHU5aEU4K1QrN29BaUpYWXZjMVZ0NWxlV3lYeUlXb0FmSGlVLzNYYWhONFpp?=
 =?utf-8?B?cGc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 0f06854d-b989-48b4-4a68-08dc80ba7251
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 May 2024 15:09:05.1016
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: AzZDyufiP/tSlEu6SlQYVC9CcAlY0DvJEPozq5ak29ps5eKaY6fwrR9jPcy0beRhQopbBf0Y6puBddSM3pwu4RwN3oSVAeqOuZlComdMUbw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB4788
X-OriginatorOrg: intel.com

Hi Ilpo,

On 5/30/24 4:56 AM, Ilpo Järvinen wrote:
> On Wed, 29 May 2024, Reinette Chatre wrote:
>> On 5/20/24 5:30 AM, Ilpo Järvinen wrote:
>>> Nothing during MBA test uses mongrp even if it has been defined ever
>>> since the introduction of the MBA test in the commit 01fee6b4d1f9
>>> ("selftests/resctrl: Add MBA test").
>>>
>>> Remove the mongrp from MBA test.
>>>
>>> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
>>> ---
>>>    tools/testing/selftests/resctrl/mba_test.c | 1 -
>>>    1 file changed, 1 deletion(-)
>>>
>>> diff --git a/tools/testing/selftests/resctrl/mba_test.c
>>> b/tools/testing/selftests/resctrl/mba_test.c
>>> index 9c9a4f22e529..5e0b1e794295 100644
>>> --- a/tools/testing/selftests/resctrl/mba_test.c
>>> +++ b/tools/testing/selftests/resctrl/mba_test.c
>>> @@ -166,7 +166,6 @@ static int mba_run_test(const struct resctrl_test *test,
>>> const struct user_param
>>>    	struct resctrl_val_param param = {
>>>    		.resctrl_val	= MBA_STR,
>>>    		.ctrlgrp	= "c1",
>>> -		.mongrp		= "m1",
>>>    		.filename	= RESULT_FILE_NAME,
>>>    		.init		= mba_init,
>>>    		.setup		= mba_setup,
>>
>> This may explain the unexpected checks that are removed in final patch?
> 
> While possible, I just have gotten a feeling that not much thought has
> been put on generality until now. Because of that, the solution had always
> been adding new ifs, no matter the place, instead of thinking how to
> parametrize things properly instead. It has lead to fully overlapping
> checks, dead code, and incomplete error handling which is hopefully now
> slowly getting less and less.
  

Ack. Your work is greatly appreciated.

Reinette