Received-SPF: pass (google.com: domain of linux-kernel+bounces-195592-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <85805c71-c94a-4518-a32d-1ffc2cbf61e7@amd.com>
Date: Thu, 30 May 2024 20:47:58 +0530
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] iommu/vt-d: Fix panic accessing amd_iommu_enable_faulting
To: Dimitri Sivanich <sivanich@hpe.com>, Yi Zhang <yi.zhang@redhat.com>,
 "Tian, Kevin" <kevin.tian@intel.com>, Baolu Lu <baolu.lu@linux.intel.com>,
 Joerg Roedel <joro@8bytes.org>,
 Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>,
 Will Deacon <will@kernel.org>, Robin Murphy <robin.murphy@arm.com>,
 David Wang <00107082@163.com>,
 Shinichiro Kawasaki <shinichiro.kawasaki@wdc.com>, iommu@lists.linux.dev
Cc: linux-kernel@vger.kernel.org, Steve Wahl <steve.wahl@hpe.com>,
 Russ Anderson <russ.anderson@hpe.com>
References: <Zlh3nz2Ij06TY4cr@hpe.com>
Content-Language: en-US
From: Vasant Hegde <vasant.hegde@amd.com>
In-Reply-To: <Zlh3nz2Ij06TY4cr@hpe.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?b1F5OGhQN1hUckU4LytnU2xYTWdjVkRPbmdVM1VTRzZENnFaNzgyMDNyaEZz?=
 =?utf-8?B?M3djMmNqN0V5QmYvQm82bXB0ZTlMazJXUlRpcjB1SUVnTElZOGdUK1MybkQw?=
 =?utf-8?B?U3JmS1d6dTZ5NWhLU0JLdE5VR0gzb2lHVTVyL1M2U1J5dDhKUWdCM3hHTGIw?=
 =?utf-8?B?TlI2aEJDUVpYMG9YNVJKejVnVFhidTVYeEM4OTk1SDVTQ3VDWkZvcE1vZ09U?=
 =?utf-8?B?aW1GTWEyQWJLT2NidHZMWlFqZ0I1WU9IbE93dXZXS1FFWWJNakFDcXdSU1JP?=
 =?utf-8?B?b3c5UGVaN0xBaUlKYWNOZzNyUmdOaTFBVjU5ZmI0SDUxUCs5UnFCTkp4Wm03?=
 =?utf-8?B?RkRadU03TWN2V1JGZXhvZ1NCdUtSbVFGTGYvYVJPUHVTZUZPNS84TzNUMGxK?=
 =?utf-8?B?c0VRdGMzRWxwei9iMWx5eEp3TTJwMEdYV3ZvbDZmMXArd1BtWUEyQm1wQkw3?=
 =?utf-8?B?Z2dpUjJoS21pSUdrTVp0Q25sSTVCQ3lLN2FhakEySW53QW1Zd2hESGFOM2Zx?=
 =?utf-8?B?TE1jVldyYncvN0thQzRjUGRNWmt5TFhBTXJjOHFSUitqa24xVzNxNmpBOVdP?=
 =?utf-8?B?aDE4VmtNUnE5R2V5eThVWUdVRW1JL1E1L2N4T201OW42SEdURW9IR2RQb3dJ?=
 =?utf-8?B?T25CSmhpdmFCZnlkdmJWVlRMcXlRc0ZtZ2RzNkNsdytEUm93emRIYXdiSFRN?=
 =?utf-8?B?L3FybG5Lc3lLVExsOFJHWGdneVFmSlhNd3RUV0Rvb2Q0RXRmUEw2SzdXa0Vj?=
 =?utf-8?B?WElRWGMxajlJZEVoUnd2UUIyNlAyZmVUSWNXRHlJNTY2SEhTSWZDclI3Mmxt?=
 =?utf-8?B?VXF4RG42RVZsSVVqKytkeHdjaDdKVGZVREoxRFFLM3pkdUhNVCszRU05dVdJ?=
 =?utf-8?B?MXZBbHlTS0cwU1VZTHRyMFlqRTExeVk0WlhRRUNaVzdNaFErajNOME5iR2t3?=
 =?utf-8?B?QXFLa1pmc1JtcEFZeSttVTJ6N3FkOHRhU28zaFViYVpYQkFoWitXQmNnWm9J?=
 =?utf-8?B?dWo2SWdFSkxMYTJxZXRHOCtKOUtvMk1RUlJMdFlFeDRmM29kOFdvNGVwbXdo?=
 =?utf-8?B?OE9jV09MZEJzQndnRytDRk4vRitlaEtuNGZXRUI5T2lDWnduS2FhZ0J3Vk9X?=
 =?utf-8?B?V2xCVGRFOGlvTWpvQUEvYTVHY29RRSszSm9CRjJyVE5QWmozTjhyM2dYbDBk?=
 =?utf-8?B?R09oWGJueSt0aFJTK3N4K1o5Wm1YN3AzMmtFK1ZrMFl1MjZNaWZOZm1GN1c0?=
 =?utf-8?B?aHNRejA3aEVDWDBGZXZYYnNuOTRtQ3dTck4rdTJ1WUhtTFZlZit4TWZYVDFN?=
 =?utf-8?B?NUNyWmM1N0c0RHZuMlRDZVFBcjQ3Rk1TRDgvOU9kZWZkMlhkS1RQbTBzSFhC?=
 =?utf-8?B?c1M5dkcrSjRRdUtoNEVaUTdBTTBJNzBNc3NoS1JTSGNRVjFMQzNFL3dPNHFp?=
 =?utf-8?B?dzVWWjRpd2VmNjN5K1dhREhDd24xV2hYU240VytickZoa0RwM2NUYjl0Mmdz?=
 =?utf-8?B?QUpUOXZJSzZHTDEvR0NETVpkNWJ0TEJkaHR4SjBTQTBtRVdnV0dOV1BRYWc3?=
 =?utf-8?B?eGdGQm41WVFSeXZGSkFOdGY4Nnh2Tm9NVlV4OEx1ZCtORUJabm5DUktiZmU1?=
 =?utf-8?B?aGtUQlZSNC9WSzdaNCszTnV4VTZKZ0tqYm1mb2NQL2NLVGUvRHd0aEE1aU80?=
 =?utf-8?B?NGR0YlpES01UMVQxdnJ5TGJXY1FuMElibkcyOEdsSmI0dEJPVkpwY3ladG9T?=
 =?utf-8?B?Y3E4bzVFR1MxNXliNFU3ckQwTE9zc3E4UUs5Zzh6Wno3TEtiSFZkT2xJaGhn?=
 =?utf-8?B?MkF4YkEzTTVrU0Jydk80NzRKNk9uT2kxNFpaSVp4c1Z3ZjdJaHdJbVI5WFE1?=
 =?utf-8?B?a1hFZGZrYzFSVFV2L0JhRm1CV1YraWcyRXJoMmltV3JjajduZUdtY01uVlVo?=
 =?utf-8?B?a0xKcHc4UEhxZzNsT251alBhQThkQVFUdTg1SVRvVFlKTkdzaVp3Y2p1c2lB?=
 =?utf-8?B?V1NNc3RXQStFaGZwWUpnbjUyQkJwMEpOOEJqUXBMdzdYL0l5bjRjS2tNNDdP?=
 =?utf-8?B?eGFReFBSWXp3amNmNVV6d05ETEVEa0tZMEs3amNwdGlQWjBOYXFvOHk5T0pY?=
 =?utf-8?Q?adG0zTMA55BAWX7dAFrdSz1lM?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5f76d073-9e95-4e31-0f18-08dc80bbb609
X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB6048.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 May 2024 15:18:08.4836
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: YOvyzcjA9u16NpEKd2uxQMNVyvzX8WNpSlZpXoD4wOAl5U2Q1hfwgFwlZdJTQakMHBTwPYn0gskL98ClKXyhng==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB5880

Hi Dimitri,


On 5/30/2024 6:27 PM, Dimitri Sivanich wrote:
> This fixes a bug introduced by commit d74169ceb0d2 ("iommu/vt-d: Allocate
> DMAR fault interrupts locally").  The panic happens when
> amd_iommu_enable_faulting is called from CPUHP_AP_ONLINE_DYN context.

Issue is happening on AMD system. Can you please change subject line. s/vt-d/amd/ ?

Also may be add "Fixes" tag as well.

-Vasant


> 
> Signed-off-by: Dimitri Sivanich <sivanich@hpe.com>
> Tested-by: Yi Zhang <yi.zhang@redhat.com>
> ---
>  drivers/iommu/amd/init.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iommu/amd/init.c b/drivers/iommu/amd/init.c
> index a18e74878f68..b02b959d12af 100644
> --- a/drivers/iommu/amd/init.c
> +++ b/drivers/iommu/amd/init.c
> @@ -3353,7 +3353,7 @@ int amd_iommu_reenable(int mode)
>  	return 0;
>  }
>  
> -int __init amd_iommu_enable_faulting(unsigned int cpu)
> +int amd_iommu_enable_faulting(unsigned int cpu)
>  {
>  	/* We enable MSI later when PCI is initialized */
>  	return 0;