Received-SPF: pass (google.com: domain of linux-kernel+bounces-195633-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Thu, 30 May 2024 12:06:16 -0400
From: Frank Li <Frank.li@nxp.com>
To: Animesh Agarwal <animeshagarwal28@gmail.com>
Cc: Vinod Koul <vkoul@kernel.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>, Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>, dmaengine@vger.kernel.org,
	devicetree@vger.kernel.org, imx@lists.linux.dev,
	linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: dma: fsl,imx-dma: Convert to dtschema
Message-ID: <Zlij+FgY4ul7ZwbA@lizhi-Precision-Tower-5810>
References: <20240530072113.30410-1-animeshagarwal28@gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240530072113.30410-1-animeshagarwal28@gmail.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?q6t7sVHYJzMgIXGjaEzmaMMQEg7uM/ftibxp/KJYTmBPrq7DOI857/U5y8ZH?=
 =?us-ascii?Q?00a0Oupjrat9MXP+JMvxfcuLBE+8Gr+feuNjRZl3owl1YmXdZuq0zgGUBHWM?=
 =?us-ascii?Q?TkTl94Cu+XDdCUpRT5bAZA+DJHK5yQ5CQOJrdYTuuo7ZerLP4LVsCE7WDi0p?=
 =?us-ascii?Q?Jy0Tv/+GG62mNVLX4qXNeTdF87WncXBFQ4TSdHXxvyS3YKoYYMFAz8EJ+gfW?=
 =?us-ascii?Q?0kz34GCqa6WZYOO3Lu+6+4NvbUJUOZ/iClHB/z03emHHj9iZvM45MFvu/4ST?=
 =?us-ascii?Q?BS0Gm07o6JlPAr3fCcwgzfLfbJlgwOgGniGXEyQ4M0toj+wOJRLdW9JGfrJb?=
 =?us-ascii?Q?oTe7MkqK6+VxC0fF29AIqP9Lo/6EVVfOz4XOu2EK9DCvhxe8m/jvOAr5JT96?=
 =?us-ascii?Q?Fnxe99iwMaL4Sajs/dOwqxuE+Hhcc9WIsjj1FOPZjNTNCvWEuvytb8D9FrwT?=
 =?us-ascii?Q?dI9kMLk/W7RehGuO3PHPuYzmEZcyglO6q4WyFS6vAb0mQyJs/OBzMYtNb/wY?=
 =?us-ascii?Q?cinzgyP2Ug5/pFcjci2dcPtiPjiseQITK2ScFdndGuV2eS59wrVmUZXbW2ya?=
 =?us-ascii?Q?M/MWHBQQN6DUWl4xmHFqCbJCRbcIA1XQf14wPoFoOJk0sS3bcCo+Qw+8Q3SX?=
 =?us-ascii?Q?sUHulDaulYgmpr36239lpeLtGV7L/LBWnhoWr5xH0mhcK3bXVDGfFbn/Bzzo?=
 =?us-ascii?Q?VSauabnMbGYU+Zl7ktp16PgvbO8pIpzTrrzeyFLxiSas4GLeq/em8yjs5Oqa?=
 =?us-ascii?Q?IPckKlVlt4dYQsBJwrDaznI8nqvzB5tXCWrzFQBe7qxZ9DLYk9u5ZkVdnrjb?=
 =?us-ascii?Q?ZEVk+TWQnsbJAVE4IRDYvN5tyiet7/5SDSmsPgtx2ZGlkITGWvtRUeldy4O8?=
 =?us-ascii?Q?9kh08Rj5uO3DK7BlonQY/itzg1W48gtTeG+P00qANQchuT11pgS82/sDW1Hm?=
 =?us-ascii?Q?4frg/NE5LJvENtZFmeIMHugufyUw0OPrJiX/idIKOHZsc5nM/WCi3ped9j6X?=
 =?us-ascii?Q?gQvsj3AUaiz2doC/zPSA5x/AU2/alIhq4+hItSahTbdD+MLAiqubQ/nIc2uP?=
 =?us-ascii?Q?aR1UEcBeYKVXVG/wlnUNGBIb+EIz2G6Qid+pgq5mtsnbVavT+0X0juwea1n5?=
 =?us-ascii?Q?mSzH6AnkCdus1jZBIL8shUeNlaBWS7lNVWApuIqBiba0XvUW8/5P3cN0Q+R9?=
 =?us-ascii?Q?Wh/qu0a8/miJ3WMraURXG3KLXTRAvgqoM8zE844I7PBxwWXkc0lZaH1pYU36?=
 =?us-ascii?Q?8XyNxH5Yj7/IRvYBViUHSn+bYhJqcdjUc7Yji82JiLSbC6kMi2X2YooXPd7g?=
 =?us-ascii?Q?RI4/A7bpwwS4d3m/1MG8JiEZTZFTI2Zs4t9eT2T3HtME8WSibq2Co3yx9go+?=
 =?us-ascii?Q?n4KGGYBROG50y87HidezUkd8aE8Yse99Py7s5tFrCKzDgg3zF7xUXsw6KEzF?=
 =?us-ascii?Q?adNwqmT7hCNB/u5kzNEQGraQBl/CgzfFXMiEDkgs6Edq0mctGGkcczUvye7B?=
 =?us-ascii?Q?usOYV058X4U0sdHJGOIfd3vBTDA99Ajz2hJZVzyFGewgwKPt3nNxZzERLCg3?=
 =?us-ascii?Q?LjeZAuz4/a0/aC0r3+dUC7A59gVMYCMtdbcYkwP7?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bc2d2531-d04f-4860-f8b6-08dc80c274c7
X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 May 2024 16:06:25.1952
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: MXn/IJZK5Ix7+M5wltFGUNm2s92c2DZHFwFcyBg65HXhXO2xcCRtJ+DV+c834gCEtUp81vd1qhYUniTo0mz0Vg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8749

On Thu, May 30, 2024 at 12:51:07PM +0530, Animesh Agarwal wrote:
> Convert the fsl i.MX DMA controller bindings to DT schema

nit: need "." after sentence.

> 
> Signed-off-by: Animesh Agarwal <animeshagarwal28@gmail.com>
> ---
>  .../devicetree/bindings/dma/fsl,imx-dma.yaml  | 58 +++++++++++++++++++
>  .../devicetree/bindings/dma/fsl-imx-dma.txt   | 50 ----------------
>  2 files changed, 58 insertions(+), 50 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/dma/fsl,imx-dma.yaml
>  delete mode 100644 Documentation/devicetree/bindings/dma/fsl-imx-dma.txt
> 
> diff --git a/Documentation/devicetree/bindings/dma/fsl,imx-dma.yaml b/Documentation/devicetree/bindings/dma/fsl,imx-dma.yaml
> new file mode 100644
> index 000000000000..f36ab5425bdb
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/dma/fsl,imx-dma.yaml
> @@ -0,0 +1,58 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/dma/fsl,imx-dma.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Freescale Direct Memory Access (DMA) Controller for i.MX
> +
> +maintainers:
> +  - Animesh Agarwal <animeshagarwal28@gmail.com>
> +
> +allOf:
> +  - $ref: dma-controller.yaml#
> +
> +properties:
> +  compatible:
> +    enum:
> +      - fsl,imx1-dma
> +      - fsl,imx21-dma
> +      - fsl,imx27-dma
> +
> +  reg:
> +    maxItems: 1
> +
> +  interrupts:
> +    description: |
> +      First item should be DMA interrupt, second one is optional and
> +      should contain DMA Error interrupt.

items:
  - description: DMA complete interrupt
  - description: DMA Error interrupt

> +    minItems: 1
> +    maxItems: 2
> +
> +  "#dma-cells":
> +    const: 1
> +
> +  dma-channels:
> +    const: 16

I think it should be maximum: 16

> +
> +  dma-requests:
> +    description: |
> +      Number of DMA requests supported.

No "|" need here.

> +
> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +  - "#dma-cells"
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    dma: dma-controller@10001000 {

needn't label "dma".

> +      compatible = "fsl,imx27-dma";
> +      reg = <0x10001000 0x1000>;
> +      interrupts = <32 33>;
> +      #dma-cells = <1>;
> +      dma-channels = <16>;
> +    };
> diff --git a/Documentation/devicetree/bindings/dma/fsl-imx-dma.txt b/Documentation/devicetree/bindings/dma/fsl-imx-dma.txt
> deleted file mode 100644
> index 1c9929d53727..000000000000
> --- a/Documentation/devicetree/bindings/dma/fsl-imx-dma.txt
> +++ /dev/null
> @@ -1,50 +0,0 @@
> -* Freescale Direct Memory Access (DMA) Controller for i.MX
> -
> -This document will only describe differences to the generic DMA Controller and
> -DMA request bindings as described in dma/dma.txt .
> -
> -* DMA controller
> -
> -Required properties:
> -- compatible : Should be "fsl,<chip>-dma". chip can be imx1, imx21 or imx27
> -- reg : Should contain DMA registers location and length
> -- interrupts : First item should be DMA interrupt, second one is optional and
> -    should contain DMA Error interrupt
> -- #dma-cells : Has to be 1. imx-dma does not support anything else.
> -
> -Optional properties:
> -- dma-channels : Number of DMA channels supported. Should be 16.
> -- #dma-channels : deprecated
> -- dma-requests : Number of DMA requests supported.
> -- #dma-requests : deprecated
> -
> -Example:
> -
> -	dma: dma@10001000 {
> -		compatible = "fsl,imx27-dma";
> -		reg = <0x10001000 0x1000>;
> -		interrupts = <32 33>;
> -		#dma-cells = <1>;
> -		dma-channels = <16>;
> -	};
> -
> -
> -* DMA client
> -
> -Clients have to specify the DMA requests with phandles in a list.
> -
> -Required properties:
> -- dmas: List of one or more DMA request specifiers. One DMA request specifier
> -    consists of a phandle to the DMA controller followed by the integer
> -    specifying the request line.
> -- dma-names: List of string identifiers for the DMA requests. For the correct
> -    names, have a look at the specific client driver.
> -
> -Example:
> -
> -	sdhci1: sdhci@10013000 {
> -		...
> -		dmas = <&dma 7>;
> -		dma-names = "rx-tx";
> -		...
> -	};
> -- 
> 2.45.1
>