Received-SPF: pass (google.com: domain of linux-kernel+bounces-195634-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
From: Diederik de Haas <didi.debian@cknow.org>
To: David Woodhouse <dwmw2@infradead.org>,
 Lu Baolu <baolu.lu@linux.intel.com>, Joerg Roedel <joro@8bytes.org>,
 Will Deacon <will@kernel.org>, Robin Murphy <robin.murphy@arm.com>
Cc: iommu@lists.linux.dev, linux-kernel@vger.kernel.org
Subject:
 Re: device_def_domain_type documentation header does not match implementation
Date: Thu, 30 May 2024 18:06:28 +0200
Message-ID: <4190999.HFuNgkhpQd@bagend>
Organization: Connecting Knowledge
In-Reply-To: <32921840-43d6-4ad9-99eb-aac32e67e04c@arm.com>
References:
 <14311965.TaHA55BQu8@bagend> <32921840-43d6-4ad9-99eb-aac32e67e04c@arm.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="nextPart1915108.mHXZh0l9D7";
 micalg="pgp-sha256"; protocol="application/pgp-signature"

--nextPart1915108.mHXZh0l9D7
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"; protected-headers="v1"
From: Diederik de Haas <didi.debian@cknow.org>
Cc: iommu@lists.linux.dev, linux-kernel@vger.kernel.org
Date: Thu, 30 May 2024 18:06:28 +0200
Message-ID: <4190999.HFuNgkhpQd@bagend>
Organization: Connecting Knowledge
In-Reply-To: <32921840-43d6-4ad9-99eb-aac32e67e04c@arm.com>
MIME-Version: 1.0

On Thursday, 30 May 2024 17:49:17 CEST Robin Murphy wrote:
> > But neither updated the documentation header.
> 
> TBH it could probably just be deleted now, since the
> iommu_ops::def_domain_type callback is properly documented in iommu.h,
> so individual implementations shouldn't need to repeat that. It's also
> never been actual kerneldoc either, since it's a regular "/*" comment.
> Feel free to send a patch :)

I leave that to people who actually know what they're doing (I'm not a C dev).

Cheers,
  Diederik
--nextPart1915108.mHXZh0l9D7
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part.
Content-Transfer-Encoding: 7Bit

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQT1sUPBYsyGmi4usy/XblvOeH7bbgUCZlikBAAKCRDXblvOeH7b
bsBxAP47912RndyJocsLNJoEMtgERD+mtcFij9xDHF+dH6cfXgEAjHH7PN3HG1To
57bH4sJEkpYWrgJAGoLMm8LJRjfkwg8=
=3PQZ
-----END PGP SIGNATURE-----

--nextPart1915108.mHXZh0l9D7--