Received-SPF: pass (google.com: domain of linux-kernel+bounces-195637-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <11449a50-c207-4cd6-875a-f2a5ffe8a6d9@amd.com>
Date: Thu, 30 May 2024 11:08:04 -0500
User-Agent: Mozilla Thunderbird
From: "Moger, Babu" <babu.moger@amd.com>
Subject: Re: [PATCH v2 2/4] selftests/resctrl: Pass sysfs controller name of
 the vendor
Reply-To: babu.moger@amd.com
To: Reinette Chatre <reinette.chatre@intel.com>, fenghua.yu@intel.com,
 shuah@kernel.org
Cc: linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
 ilpo.jarvinen@linux.intel.com, maciej.wieczor-retman@intel.com,
 peternewman@google.com, eranian@google.com
References: <cover.1708637563.git.babu.moger@amd.com>
 <cover.1714073751.git.babu.moger@amd.com>
 <406d1fbe6b480fbe13fd0b8c432cdc517a7bd8c1.1714073751.git.babu.moger@amd.com>
 <eb80df2b-d6ba-4171-ad05-c76c218b0e3a@intel.com>
Content-Language: en-US
In-Reply-To: <eb80df2b-d6ba-4171-ad05-c76c218b0e3a@intel.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?dFRiMXh3UzdJTCtuclREeTFXVS95czVzVGpsYmg1TzUvSUpTQVVpQWpyNmxm?=
 =?utf-8?B?SjBndDhvMGtwNThka01razIrOG5KVzRoMlZaSENDUGRlb1U1N0V4UTBEYmdh?=
 =?utf-8?B?cWNOaGtHZmNPaWNubk0zQW1wUjN3TTduRXJjRGJiMDZHbmx5cVEwZHEwNFQr?=
 =?utf-8?B?a01HU3NBSzluWlBnVmVmTjZRYkhHWTRYc0lYM1NLWVhPc2sxd01POFJ3c0hC?=
 =?utf-8?B?Sy9kTDhCSUVzMVJSYzNMUDZ2YkdTdTYrajRuYXQ0ZkdaYlVoaERQbERFa1Vm?=
 =?utf-8?B?aUgyL0hGZmc1bVNUNlNlRW14a2RVOTh2enlZWUpyUFovTU0xTmdGY05rQnNv?=
 =?utf-8?B?a3lRV1RBeGNjTHJlbzE0a2pOWGxsNVBOemYwTnNNc0VvTUFIYVhHN25WWVgy?=
 =?utf-8?B?eng3dUhFZXd4a1BlNDBuUjJoNWlvRkMxSzlsQmhKVXkvU3NUd1g2MjJacm9m?=
 =?utf-8?B?ZkJVajlobkNzNE9mcUpZN0JncUY5Q3NMVXlncXFsMkxCeWFKT1JaZnRtREl4?=
 =?utf-8?B?MzgwU3d5cks4Q1h1TU5YOTdLNndtYTFqVkY5cVZ6VEppUG0wQk53VDRNdU4w?=
 =?utf-8?B?Q2trcEthYWpOa3ZHK1laOHBSeGZndzA1YlZXUU41MEdKL1hBTnNSOFY5aEhB?=
 =?utf-8?B?TDI5VExkVVNQMHBRTEVWTjlKbWtTQzdiVXJaNENaUzRBbUFTTFJmS003SlVD?=
 =?utf-8?B?ZjY0bVNCN2ptSGNlajVlWEFWNXZLY0xFcWRnQ3ppZyttS0hNMTZFWWczanVH?=
 =?utf-8?B?Y29LYnVhcmJEZStIVjVYSDZoa1ZKY2g5UjlITGlXNGlyVVFLZmpvK1FnOThq?=
 =?utf-8?B?MjI1ajFLZUxzLzVmZ0R3Sm5zYWFld2tlTWZBTEo3d0N5cm9EUGtTbGNEdm5H?=
 =?utf-8?B?cnB6QXJWNERDcnZPQjQ4QUdFMWtFUTRFcDNGUWJpL1ZrS0xQK3BGa0sxN2lQ?=
 =?utf-8?B?OWdMNkNGQ0cyWjN1bnJGZ2NURHJEUTFWMVRFNHNnSVhUMEozcVY1b2s3bVV5?=
 =?utf-8?B?M0NYaE1ueXl5UHB0dzA0TDUzOWNjK0VUTTVQbjlVamtVM05GVy95a3RmVW1h?=
 =?utf-8?B?emIxeFVGVExYMkZZS2RUVS82b295MitlS0V1OHVFVE1HUjJuc01oMTY2OUh2?=
 =?utf-8?B?UkFlT25IN0VlNUhDZVlHRFROTlpQeHVHUVd5clNOTDR5Yzljeml3TGQ1bW5F?=
 =?utf-8?B?RDhHRDFUQlkzMy8xOE5xalpoOU1sT3E4RXhtN2FEMGFyVFRwZ095Z0FoU09S?=
 =?utf-8?B?aEowaHZJOFhyckQ0Z1p1YWJWUkJIbDVlZWEwYWEwTEdQSUtsWUxTajA3ZFM3?=
 =?utf-8?B?VENnL0xsV05rZU5sZE4rbkNRTGI1UkFVOUZwNDc0bGJHQ3c5OGh6ZzRTenM3?=
 =?utf-8?B?dnVqZVByVW5OVU5EQzJnajk4RlVXY056ZFBGb1BQR0syVEpmTTRFcE51M3FU?=
 =?utf-8?B?cXlZQWE4emRRaG4wbUhsTjFQaFFyRlgrWVI4cE1JSjl4aDF3UjMwd05vMTBx?=
 =?utf-8?B?anJidEpTU2hhMFhhNnVMWmk2LzBVZnlXcDFOVTgxbUtFejMwSi9ZRmhIR3lm?=
 =?utf-8?B?NkVrVzRnSXdrcm5ZZjhVa0VHOEplN3hRSU4rMnNBbGJLYldibmRZZk5BZ2FD?=
 =?utf-8?B?M0xnb0NveGswaGVCU28vYlkrSFp6d1h3bUkvTWxmb2s1bG56Ym56REZNSUpj?=
 =?utf-8?B?WVBhZHpPWis3VVpTSTlkZndBbDQxRGEyS2tMRVJkM050bHpDK0JXNDRyQXBa?=
 =?utf-8?B?NFNqWnR2T0ZNTldON0E5bTdGclFaNUNBOWVGQkQzS3Q4Tm9icC9rT2RuWDAr?=
 =?utf-8?B?bG1wV08wNXU0dlBaU2s3czhUd0FRbUR0VmwvQWQ2ZCtleDF5U0JZSDlnRU5G?=
 =?utf-8?B?MkNUS1p1R0F6dmZ0bU1zWVZ2RWlNTnRmblc4WCtMb0lTVnlyQW1Ib2dwamov?=
 =?utf-8?B?ZVlYemYzUEJmbVNZN2Q0SHNtOHZKMHlQNEtPVnBiMWV5N1dSeXpYVEVVaStu?=
 =?utf-8?B?TWQ2RnlUWXkxQndxSTlQamtWK2dsWTRFVEdaT1JzemFEQXhvWXB0QVNsVWZr?=
 =?utf-8?B?b2g3TjRVL3VyT1BaQVFJdEkrUGNuLy9SeE1sWC9aYnE3a2JSd0hQcG5RTG5M?=
 =?utf-8?Q?eYK0=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c1f932bd-25d8-49dd-7170-08dc80c2b1cc
X-MS-Exchange-CrossTenant-AuthSource: MW3PR12MB4553.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 May 2024 16:08:07.6043
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 1eAqOcAVaPzgxSff1EIWEXNQ9qRk71un4SCJbxzj9qYDr4hBsNH87xh4wTX73fg9
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB6930

Hi Reinette,

On 5/9/24 16:11, Reinette Chatre wrote:
> Hi Babu,
> 
> On 4/25/2024 1:17 PM, Babu Moger wrote:
>> Detect the vendor and pass the sysfs name for the vendor for searching
>> the controller information.
> 
> Could you please write a proper changelog?

Sure. Will do.

> 
>>
>> Signed-off-by: Babu Moger <babu.moger@amd.com>
>> ---
>>  tools/testing/selftests/resctrl/resctrl_val.c | 16 +++++++++++++---
>>  1 file changed, 13 insertions(+), 3 deletions(-)
>>
>> diff --git a/tools/testing/selftests/resctrl/resctrl_val.c b/tools/testing/selftests/resctrl/resctrl_val.c
>> index a30cfcff605f..e3b09128ec3d 100644
>> --- a/tools/testing/selftests/resctrl/resctrl_val.c
>> +++ b/tools/testing/selftests/resctrl/resctrl_val.c
>> @@ -224,14 +224,24 @@ static int num_of_mem_controllers(void)
>>  {
>>  	char imc_dir[512], *temp;
>>  	unsigned int count = 0;
>> +	int ret, vendor, size;
>>  	struct dirent *ep;
>> -	int ret;
>> +	char *sysfs_name;
>>  	DIR *dp;
>>  
>> +	vendor = get_vendor();
>> +	if (vendor == ARCH_INTEL) {
>> +		sysfs_name = UNCORE_IMC;
>> +		size = sizeof(UNCORE_IMC);
> 
> Why is separate size needed? Can strlen() just be used when needed?

Yes.

> 
>> +	} else {
>> +		perror("Unsupported Vendor!\n");
> 
> ksft_perror()?
> 
> In the message, "Vendor" need not start with capital. It may also
> help to print the vendor value in this unlikely case.

ok. Sure.

> 
>> +		return -1;
>> +	}
>> +
>>  	dp = opendir(DYN_PMU_PATH);
>>  	if (dp) {
>>  		while ((ep = readdir(dp))) {
>> -			temp = strstr(ep->d_name, UNCORE_IMC);
>> +			temp = strstr(ep->d_name, sysfs_name);
>>  			if (!temp)
>>  				continue;
>>  
>> @@ -242,7 +252,7 @@ static int num_of_mem_controllers(void)
>>  			 * well and hence the last underscore character in
>>  			 * uncore_imc'_' need not be counted.
>>  			 */
>> -			temp = temp + sizeof(UNCORE_IMC);
>> +			temp = temp + size;
> 
> strlen()? (Keeping in mind the adjustment for the "_" character).

Sure.
> 
>>  
>>  			/*
>>  			 * Some directories under "DYN_PMU_PATH" could have
> 
> Reinette
> 

-- 
Thanks
Babu Moger