Received-SPF: pass (google.com: domain of linux-kernel+bounces-195639-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <76bd2937-4f47-4203-97c8-517c337014a4@amd.com>
Date: Thu, 30 May 2024 11:08:40 -0500
User-Agent: Mozilla Thunderbird
From: "Moger, Babu" <babu.moger@amd.com>
Subject: Re: [PATCH v2 4/4] selftests/resctrl: Enable MBA/MBA tests on AMD
Reply-To: babu.moger@amd.com
To: Reinette Chatre <reinette.chatre@intel.com>,
 =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>
Cc: fenghua.yu@intel.com, shuah@kernel.org,
 LKML <linux-kernel@vger.kernel.org>, linux-kselftest@vger.kernel.org,
 =?UTF-8?Q?Maciej_Wiecz=C3=B3r-Retman?= <maciej.wieczor-retman@intel.com>,
 peternewman@google.com, eranian@google.com
References: <cover.1708637563.git.babu.moger@amd.com>
 <cover.1714073751.git.babu.moger@amd.com>
 <e3bf1fbbe3ab2d9c2dc1d9669a791de140dea248.1714073751.git.babu.moger@amd.com>
 <911547f7-e952-f771-867a-57c1de738c39@linux.intel.com>
 <b5b081a1-9e80-4173-8449-36d5c93185a6@intel.com>
Content-Language: en-US
In-Reply-To: <b5b081a1-9e80-4173-8449-36d5c93185a6@intel.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?TmFOdUw0akFab1hoLzNIYTZ1d1VtajdvSTRER3lnRGx1U0h4RzlPTkVPNXN1?=
 =?utf-8?B?eTBNU3JhSTVYQjRnQ1VmQmtvbmZMNHZEaE9yWlFHTS8zeE1aME5kdXhuU0Yx?=
 =?utf-8?B?OTRMYTBBa2o2TW9DSEtudSsrenhwNUVNTFF1TFBGcllrZ0dINTloUG1CU0Vm?=
 =?utf-8?B?YXNUQWtFWEVHbm5XMHFVVTJ5MytWRjloVkN3RUJ1T2ZMYzNPOWxWZVI3aU1q?=
 =?utf-8?B?WmszdGcxMEFqb3lwTnJiNzdlNEUzM0drd1BSak1Lb1h5Mzd0UkdCYlg3M0NK?=
 =?utf-8?B?ZHZZN0wydnhFSjlYK0kxQktkNHY5WGZxbWt5ck8zMW1PZThjbiszNk50NXdJ?=
 =?utf-8?B?VzFCcHgyOFdwNHhBZStVVWpkUGdaOFI5T28vbFkyWVhiNDJpTnRkaVVSbXFR?=
 =?utf-8?B?Y0tNV0s1b2hwZmM5eDFQbFBvdXBGb1NGM1VoRFQ5OC92cGF1dTU5c2tBVytj?=
 =?utf-8?B?U0FrMENnQWZlczVyU2U2SGY4YXdEcGE2YVU3ekJOd3RvbzJ3ZzRyRnZhWTJy?=
 =?utf-8?B?SUFZZEUzSlBsWk9wdS83UWRINVRlN1hHRW9rcjFLa3pPVUppNmVDQTZ2RWF3?=
 =?utf-8?B?bnFaRXFKclFLSGNsZWRSZFlaQWoyUzhQRlIyTDlpOWdJRTVFSzVzSUhURFFY?=
 =?utf-8?B?aHhLNUhDUUV6NDJnQ3hKYWVlZ3dwaEJ1ZitBVkZVRkdwQmlCWmZxelF4d25i?=
 =?utf-8?B?bjR0RUFDY2I1UE5pVk5xY3h4aTRRRUFuR0ljd0pGQUtqelhUY1V3ZkpSMmlH?=
 =?utf-8?B?TlplMzMxNGtQeE5iaGtscStvU1FyTDIvSmJYODBndlRvM1dURmJ1REMwalZn?=
 =?utf-8?B?TWdQUkJySnJaOUloWDdCbExNSm5tZ1hNL09KWFhKZ1d2akc3UXErZUlyWlE1?=
 =?utf-8?B?bFdjZElVQ2JyNzRLc3JxVTV4aThsOUlaNTlheHBXZksxWGJ5REdFaGJYSWhR?=
 =?utf-8?B?ZmJlbEU4TFlJWVRacU1CbmFOUUl3RUhHdGpteDhxcDdvaWhZbFMvZkJrZWJi?=
 =?utf-8?B?UFdtdnNORG5MZjZ1U3N0Y2N6bTNObGRkMkx5cW0yQ25zakFvalVVMDNDK3Rt?=
 =?utf-8?B?cm03R2RxaEZRSmh3Q1ppQmdBazFmazFwenZ6dzRWU3RUUU8ybHRBaFBYYXhh?=
 =?utf-8?B?NnRueEZocjFNTVZXZUVvOFM3bVpyQjUxM2x0R2NoZWJzMkQzYXlvQk1ldCsx?=
 =?utf-8?B?UVBFcVJpTldxUHNKa3FoSFZkTGF5eUtDbkZQMHorN0kzaUQzUjAyamVkY2Zk?=
 =?utf-8?B?VFhJdWZ0VzE2a3hXRDdIbDNyb1BsakN6TWdkS2c1MmpMQjNYSnpYSTdFdDVh?=
 =?utf-8?B?M1FGZXRFMDFFQmJRTlhaNFpKbmJlM0p5cWtvRFZpcGFxcVFJZ0h2VWJjb1Rz?=
 =?utf-8?B?dzdXUUd4YU5xTldMYXM0dFB5ajFuSVRwTDE2NjhsbUh6R0wxMXk3QVRxR0N1?=
 =?utf-8?B?YWxhTjhEL2tEZFhtUDhydERXL1U5aGhXaFA2SFd3NCtIbTJQR0t6amUrQ1RB?=
 =?utf-8?B?c2NtQnNxSE5TUWE2bHYyL21HbEN1LzQ4UlA0OFVud0dDd1JTOWpVLzZFajI3?=
 =?utf-8?B?NC9vQUU0ejJ6QXllMjNzVEs4U05mQXBjd2Ura3A4d2l0Um5LUGZBWUJDZ0ZO?=
 =?utf-8?B?TzNKaGZ0UWFaY2pMbXl0WkY1VjR4aHErbCs1MkpPdHFDQm5UVmRzcWJ5cjFH?=
 =?utf-8?B?M0pBR0YzYVQ5aG8vT1BDcCsrRzM4WVVaMjE1NXUwYThleFJkZWUrT3pBeEo1?=
 =?utf-8?B?ZXBOMHRmN1RUODVHOTBFdTFqenhHNmxZNkh5UFRmM1A3Q2Y2UWF6VUpBMG44?=
 =?utf-8?B?VTZEWk5pZWwzMi9CQVd0TUdHZGI4MHBGYy85T2loaldVZ2pRb1dWcVFiMGpD?=
 =?utf-8?B?S1FmVmFzRVZudDhWSzZTTVFON2hFaDRQcUxWNE5YZDhxNlZENW1wVSsrZG0y?=
 =?utf-8?B?L0NOdUd4bmxPZnhVdVRmN3pGYStkQnFWQmcybUh1ZmJtODMyRUNPUUtDd1ZD?=
 =?utf-8?B?NVdqdzZ4Zk10ejh2UWRjN2psUGR5SDRYbndqWEpIR0Z1SmlhWEpmKzZFWmJ6?=
 =?utf-8?B?U0VPR1Q1aGwxSXZScWtWeUE1dUkvWG90cStSbkFLRHo4d1VaOVZMYk1XSjBy?=
 =?utf-8?Q?oBeQ=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ed4220a2-34c9-47f8-8c9a-08dc80c2c7ac
X-MS-Exchange-CrossTenant-AuthSource: MW3PR12MB4553.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 May 2024 16:08:44.3019
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: mMSEqy2jPt+o+m8ZRHL0o6/ciRYIGRpRMQ9dXYnrwddMDfU51wBgYlIEUC2bbRvv
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV3PR12MB9119

Hi Reinette,

On 5/9/24 16:11, Reinette Chatre wrote:
> 
> 
> On 4/26/2024 12:06 AM, Ilpo Järvinen wrote:
>> On Thu, 25 Apr 2024, Babu Moger wrote:
>>
>>> Enable MBA/MBM tests if UMC (Unified Memory Controller) support is
>>> available on the system. Tests will be skipped otherwise.
>>>
>>> Update noncont_cat_run_test to check for vendor. AMD supports
>>> non contiguous CBM masks but does not report it via CPUID.
>>>
>>> Signed-off-by: Babu Moger <babu.moger@amd.com>
>>> ---
>>>  tools/testing/selftests/resctrl/cat_test.c | 2 +-
>>>  tools/testing/selftests/resctrl/mba_test.c | 1 -
>>>  tools/testing/selftests/resctrl/mbm_test.c | 1 -
>>>  3 files changed, 1 insertion(+), 3 deletions(-)
>>>
>>> diff --git a/tools/testing/selftests/resctrl/cat_test.c b/tools/testing/selftests/resctrl/cat_test.c
>>> index 4cb991be8e31..b682eaf65bfd 100644
>>> --- a/tools/testing/selftests/resctrl/cat_test.c
>>> +++ b/tools/testing/selftests/resctrl/cat_test.c
>>> @@ -314,7 +314,7 @@ static int noncont_cat_run_test(const struct resctrl_test *test,
>>>  	else
>>>  		return -EINVAL;
>>>  
>>> -	if (sparse_masks != ((ecx >> 3) & 1)) {
>>> +	if ((get_vendor() == ARCH_INTEL) && sparse_masks != ((ecx >> 3) & 1)) {
>>
>> This looks independent change to me which should be put into own patch.
>>
> 
> Own patch that is separate from this series. This should go in
> as a fix with
> Fixes: ae638551ab64 ("selftests/resctrl: Add non-contiguous CBMs CAT test")
> 

Sure. Will do.

-- 
Thanks
Babu Moger