Received-SPF: pass (google.com: domain of linux-kernel+bounces-195654-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <75d4b180-206e-4d48-9506-f0f602b46eca@amperemail.onmicrosoft.com>
Date: Thu, 30 May 2024 12:24:53 -0400
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 2/3] mctp pcc: Allow PCC Data Type in MCTP resource.
To: Ratheesh Kannoth <rkannoth@marvell.com>, admiyo@os.amperecomputing.com
Cc: Robert Moore <robert.moore@intel.com>,
 "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>, Len Brown
 <lenb@kernel.org>, netdev@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20240513173546.679061-1-admiyo@os.amperecomputing.com>
 <20240528191823.17775-1-admiyo@os.amperecomputing.com>
 <20240528191823.17775-3-admiyo@os.amperecomputing.com>
 <20240529032541.GA2452291@maili.marvell.com>
Content-Language: en-US
From: Adam Young <admiyo@amperemail.onmicrosoft.com>
In-Reply-To: <20240529032541.GA2452291@maili.marvell.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?V1VJekRuYTNDWFpmd1RWSTcvUGxlOWI5bFc4NDBITTIwbDZ6REt6dGFmSTcx?=
 =?utf-8?B?T1pPR09MdlY5SG80VDZjKzBkZGRJbENmMXo0YWRPVFFxa2hWeFJSeEEvcVJC?=
 =?utf-8?B?T3VrbGx0Vk9ZYTBpeXVPMUJ0NjNjWlQvS3ByZ1FUblpMOVF1NkNENlR1dm1L?=
 =?utf-8?B?TGdIMmxSQWRGemNWK1FMdFRSQkpxYjNVSzdidUFzZUxNeE1YTmc4dHVmYUY4?=
 =?utf-8?B?VkozRkF4ZHlObE5OK3VZSDU0Y3RDaE9nYnVMczlNRW42NGpyVE01NCt0bGtJ?=
 =?utf-8?B?K3hRcnd1YkRmV3pLZlFaZkNQQXlvYkUvWkhlNUtYS2p1WElSdzZHYno0aGJ0?=
 =?utf-8?B?NG1FODhjeFB1a3c4RDkySVVvOGJmL1B4VDc2LzY5Rzh5aWZLMjFTd2M1c0hh?=
 =?utf-8?B?em56OCtzR0N3Y01FZnJkZFFtOWxsVHZxZ0lyRWN3ZzBDbTJCS0FkcGQ1SVEz?=
 =?utf-8?B?Tms4Q3JUOFliS0Mzc0FySkF3eGdVOUg4c2hNZ2EwaXp4a1RpRkltWU9GbGYy?=
 =?utf-8?B?M3huTWFWb2ZRVnR0bHltT3lXd1Q2QkxvQzZ5WGphdFJ1TkU0eWU4V1hLdVJo?=
 =?utf-8?B?VHFwSXRZTXV5aGw4TFdLTXhHL1Rocm4wait5Sy9mY08xRGpVem15cGEyNXpD?=
 =?utf-8?B?dmJGVGhqaENmYmh4TmpVS2drbi9KVUQxSnV0WmQzVEZGTHpuQ2txOUZRUVJt?=
 =?utf-8?B?U2FQTk5INkNlc2xiK21GeCtyL3RrSTNUQWV3bllCdnk2WFJSSUpqb0l2bzN1?=
 =?utf-8?B?YUV2SGV1VGpMYkE1SkhyZlRtT3NwSUFuZVl4VEdTcjdwQ3FhNm9UWTNkSDVO?=
 =?utf-8?B?VWlRV2dOSHBhUjhvejIyS1RwN1BEZlhBMTQ2eXdoM2xhVldRMXdJUVVqN0w0?=
 =?utf-8?B?SDBTd1pIWXRiREQ5dWc3SUlJbnFUWitVa05yV3hIazBjYldONFR4QVlNNm5N?=
 =?utf-8?B?UVNQSVQ5RTE1dGFJUkNrTXFiK3d2RmtYVUZMSTFFRHU2bDdMaHVpbWJqSTNB?=
 =?utf-8?B?bkhLM0IxOTRZa3BReW8vRldHMDZHVGY5ZG5yc3MzbFh4T0JUNHA1YmtZbnJ2?=
 =?utf-8?B?Z0J1eFVVanhBZFRKUmc0Mkh3bnpUaFkwNVAwQmJkQ3FJUE9kQ2MrVlBXUTlK?=
 =?utf-8?B?UEt0T2pHTU9WMFlhbGJkY3NKZFdUSlJoYjhuR0hvTXAvcXNNMHNLbFo0c3NT?=
 =?utf-8?B?cjNkN3RNbWYreWNLdFI3UEZNdXJKTnRsTWVUMkpmSC9oRUsvUjVyRTZ5Y1JG?=
 =?utf-8?B?S2JaVW93WUVnZGcwTVFxV3JudkpXRUJpcG9tVTNiQzRLRExKYi9UVFpiNUxn?=
 =?utf-8?B?cGhVR3JqYUE3cW1aR2drcDVhVEt1RWV1dG9hako1R2o2czVmN3cxWFBibFVF?=
 =?utf-8?B?aU4xYW5jeGFwSUdaTDd4K0dyVUtmWXd5RnR2emlYN3ZUN05NR3B2UHBYbmx1?=
 =?utf-8?B?SHJhLzBNSnB2RmE1UVJGVDhMRHhqREFYSHRtemtjVGk2bnI2OTE0bFgxcHJB?=
 =?utf-8?B?aEVsaFc2bi9EWkI2UUZTaWtreWVNYjI0a2szMk1nMGpPalFFMHFoRmV3dk80?=
 =?utf-8?B?eTFDcWJaSVFFNVpmbWdjaDFjbDIwTU4wRkZlRnFoVlRkWFJiZE9ZcXpGWS9r?=
 =?utf-8?B?MWRIM3YvOXR3cEd2RllJUDhtbHhpRk5NN1lWWTRuWUZDdnhEanV5MU9zTnR6?=
 =?utf-8?B?bmM3cHNkRlJTbWRvQ3VaVHNxS3lOL1NpaUZOcVovZmFjV0hIeVQvRm5LdmpJ?=
 =?utf-8?B?RUVRelpsaXVQK2g5Vm83cyt4OTBBblJWMitlU1BWZTRqejkyQXdJdzVid0Zp?=
 =?utf-8?B?SVBwMVJWbndKeHNJWHlYMlI0UXRVMnB5RkdUeXJpM01HcEVPc0p4OFVZc25k?=
 =?utf-8?B?aGN5Q2czTEg5cldtOW9JME9aQzBDc3FvZzh4YlVLOEswaXVxSndHRDZ3d1o2?=
 =?utf-8?B?T1JwQlVvWFJtcXRTbUhpbDlLWjgzTC81dGFmY3dsK3pwY1RsNDRseVZwb0xw?=
 =?utf-8?B?Nmt4NDJhNjVEelc1bnlTVWFlQkZtVGwveUgxNVBrRGRMTE5Ta1JZUjBJRXFT?=
 =?utf-8?B?c2hXeFpleDhjYm9qcHFuSWVvckM1UzlwTnlrb3VnYmExVUllZnRJVjlhZ1J5?=
 =?utf-8?B?aUZuODhZMkV4dnF0SFNwcWpkTXpQemNqN2ZJQ1lPQjN3d2QwRzdxMktMZ2Vo?=
 =?utf-8?B?dThaWXRjclFnVGpHSExYcDhDQ2J2Ry85TDV6eFJvcWgvZUUyd1NYVk9FMTJD?=
 =?utf-8?Q?0ymStmzYenZhPA8vPHQKNlKK9iGlfiA1jamsDoZQFQ=3D?=
X-OriginatorOrg: amperemail.onmicrosoft.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d4ae5bfa-68ce-4ea1-808a-08dc80c50c33
X-MS-Exchange-CrossTenant-AuthSource: SA0PR01MB6171.prod.exchangelabs.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 May 2024 16:24:58.1954
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 76YBSCjZyu8FzfZZK89JU+UbjlXeOkw1oIiO27IoFQzbKG7yvqPWyGnnCrHDc0mi8UnWKzRadA8G5vva/qxMCgDe3XRPxg3EEaUJrGTPRD/bM75q4yqLV3W5GkkgeG+W
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR01MB7680


On 5/28/24 23:25, Ratheesh Kannoth wrote:
> On 2024-05-29 at 00:48:22, admiyo@os.amperecomputing.com (admiyo@os.amperecomputing.com) wrote:
>> From: Adam Young <admiyo@amperecomputing.com>
>> --- a/drivers/acpi/acpica/rsaddr.c
>> +++ b/drivers/acpi/acpica/rsaddr.c
>> @@ -282,7 +282,7 @@ acpi_rs_get_address_common(struct acpi_resource *resource,
>>
>>   	/* Validate the Resource Type */
>>
>> -	if ((address.resource_type > 2) && (address.resource_type < 0xC0)) {
>> +	if ((address.resource_type > 2) && (address.resource_type < 0xC0) && (address.resource_type != 10)) {
> use macros or enums instead of hard coded numbers. That will improve code readability.

In general I agree, but this code is generated  from ACPICA and will not 
be directly commited.  The corresponding patch to acpica has already 
merged. What you see here is what the code will look like post-process 
from ACPICA conversion.


>
>>   		return (FALSE);
>>   	}
>>
>> --
>> 2.34.1
>>