Received-SPF: pass (google.com: domain of linux-kernel+bounces-195670-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Thu, 30 May 2024 18:46:39 +0200
From: Borislav Petkov <bp@alien8.de>
To: Jeff Johnson <quic_jjohnson@quicinc.com>,
 Nikolay Borisov <nik.borisov@suse.com>, Thomas Gleixner <tglx@linutronix.de>,
 Ingo Molnar <mingo@redhat.com>, Dave Hansen <dave.hansen@linux.intel.com>,
 x86@kernel.org, Kees Cook <keescook@chromium.org>,
 "H. Peter Anvin" <hpa@zytor.com>
CC: linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org,
 kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] x86/boot: add prototype for __fortify_panic()
User-Agent: K-9 Mail for Android
In-Reply-To: <e42c4984-d4a2-45b1-b93d-7471000766b7@quicinc.com>
References: <20240529-fortify_panic-v1-1-9923d5c77657@quicinc.com> <0d3f7c58-7fc0-4e8b-b6fb-c4d0d9969ce7@suse.com> <e42c4984-d4a2-45b1-b93d-7471000766b7@quicinc.com>
Message-ID: <5658B525-6642-43A2-B14C-BC4AA916FBCC@alien8.de>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable

On May 30, 2024 6:23:36 PM GMT+02:00, Jeff Johnson <quic_jjohnson@quicinc=
=2Ecom> wrote:
>On 5/30/2024 8:42 AM, Nikolay Borisov wrote:
>>=20
>>=20
>> On 29=2E05=2E24 =D0=B3=2E 21:09 =D1=87=2E, Jeff Johnson wrote:
>>> As discussed in [1] add a prototype for __fortify_panic() to fix the
>>> 'make W=3D1 C=3D1' warning:
>>>
>>> arch/x86/boot/compressed/misc=2Ec:535:6: warning: symbol '__fortify_pa=
nic' was not declared=2E Should it be static?
>>=20
>> Actually doesn't it make sense to have this defined under =2E=2E/string=
=2Eh ?=20
>> Actually given that we don't have any string fortification under the=20
>> boot/  why have the fortify _* functions at all ?
>
>I'll let Kees answer these questions since I just took guidance from him =
:)

The more important question is how does the decompressor build even know o=
f this symbol? And then make it forget it again instead of adding silly pro=
totypes=2E=2E=2E


--=20
Sent from a small device: formatting sucks and brevity is inevitable=2E