Received-SPF: pass (google.com: domain of linux-kernel+bounces-195685-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240526182212.544525-1-sesse@google.com> <CAM9d7chY7CzMx9sSYeagDK81PsE=soGmn4AUxXAE7rHp=jmx3Q@mail.gmail.com>
 <ZlczO4D8J1lgWBZj@x1>
In-Reply-To: <ZlczO4D8J1lgWBZj@x1>
From: Namhyung Kim <namhyung@kernel.org>
Date: Thu, 30 May 2024 09:55:37 -0700
Message-ID: <CAM9d7ch5YSYEadbVV+LRGvppUr76rjfxMnOp2Q2AqgTBAff7Xg@mail.gmail.com>
Subject: Re: [PATCH v7 1/4] perf report: Support LLVM for addr2line()
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: "Steinar H. Gunderson" <sesse@google.com>, linux-perf-users@vger.kernel.org, 
	linux-kernel@vger.kernel.org, irogers@google.com, 
	Arnaldo Carvalho de Melo <acme@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, May 29, 2024 at 6:53=E2=80=AFAM Arnaldo Carvalho de Melo
<acme@kernel.org> wrote:
>
> On Tue, May 28, 2024 at 08:56:47PM -0700, Namhyung Kim wrote:
> > On Sun, May 26, 2024 at 11:22=E2=80=AFAM Steinar H. Gunderson <sesse@go=
ogle.com> wrote:
> > > +#elif defined(HAVE_LIBBFD_SUPPORT)
>
> > Hmm.. it's unfortunate that we have only one addr2line
> > implementation at a time.  Maybe we can do the same thing
> > like in annotate with objdump so that it can fallback to another
> > method when failing.  But it'd require more changes beyond
> > this work and I'm not sure if it's really worth it.
>
> Right, I think we shouldn't delay processing these patches because of
> that, we can do it as follow up patches, both for fallbacks in case we
> can detect problems like we did with capstone -> objdump disasm and also
> to be able to compare outputs in 'perf test' shell scripts, discounting
> known/expected minor differences.

Yep, I don't want to delay it unnecessarily.  But I just want more
people to review and/or test the patches. :)

Thanks,
Namhyung