Received-SPF: pass (google.com: domain of linux-kernel+bounces-195764-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <22de594e-2e2b-4659-b88b-3d0e4c99e4fa@intel.com>
Date: Thu, 30 May 2024 10:58:57 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] hns3: avoid linking objects into multiple modules
To: Arnd Bergmann <arnd@kernel.org>, Yisen Zhuang <yisen.zhuang@huawei.com>,
	Salil Mehta <salil.mehta@huawei.com>, Jijie Shao <shaojijie@huawei.com>
CC: Arnd Bergmann <arnd@arndb.de>, "David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, "Paolo
 Abeni" <pabeni@redhat.com>, Leon Romanovsky <leon@kernel.org>, "Masahiro
 Yamada" <masahiroy@kernel.org>, Hao Lan <lanhao@huawei.com>, Peiyang Wang
	<wangpeiyang1@huawei.com>, Jie Wang <wangjie125@huawei.com>, Michal Kubiak
	<michal.kubiak@intel.com>, Kalesh AP <kalesh-anakkur.purayil@broadcom.com>,
	Guangbin Huang <huangguangbin2@huawei.com>, <netdev@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
References: <20240528161603.2443125-1-arnd@kernel.org>
Content-Language: en-US
From: Jacob Keller <jacob.e.keller@intel.com>
In-Reply-To: <20240528161603.2443125-1-arnd@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UnUvenl5aE1kZGEyaDQ0TlZTZ2NwUEpEdEYyYzRycnVGNWxYS1M5SFV4aFUw?=
 =?utf-8?B?ellYaXd6WXlWSHRISURmL3ZqZkxXT2d3U2RTTWlZWG5lbWw0aVRwY25uVjgw?=
 =?utf-8?B?UG42UlJESkk4ZDlXdnpxZXkrMnBsQ1pXMWFLN3d3TjlMblZpYS9MaTY1TUVD?=
 =?utf-8?B?S2tmNmFFanFBRjRTa2V2RkRpWVBwaC9QUVdWdjViYXZoTCt0NUhNTVBVWmFW?=
 =?utf-8?B?S0xKQjVlTm1NbUZNS3VSQUlLa1FEN0YvNkRxbEEwOEREOEsvWnEweW1hWWc4?=
 =?utf-8?B?MXVjNEl6NmFLdk15eU1PVDRXNnMvenB4azY4ZS9OdUs5MDJWaWpyRDBvWlZ6?=
 =?utf-8?B?SnQrb2JjeHRQY05MbUt4cmVMNUxEM3VKdDhPeGNLd2FZc0dtQ0JUbnhJWmll?=
 =?utf-8?B?SVV5TjdyZ0FIdUx1T3I5NDN6R3hXSVZGU1ZxSDdxSEVUcGFSY20zN2hwTXZ4?=
 =?utf-8?B?UGNWbHB6TEs3UFM1TjBldzRFTzh3VUMrWXRlRi9LeEd0WnZtcU1nc3FEUjNY?=
 =?utf-8?B?cmdJRWlkYk5RemZVK3RmdDlIYlVuQ1c4R0k0SjBUQ2JheVc2WlFFSEdLVXhi?=
 =?utf-8?B?UXE2a0kwcUFYM3d4M0dyMis2Q2NmcDNORW1od3Z2cHhmZ3JmNjNFQ2dCRjVR?=
 =?utf-8?B?Vk9HS0NIQlNtVFhjVkl1T1V2OURqME92QWM0QjJZbkZoQ2lRMDFTdUFkMndo?=
 =?utf-8?B?RDFnTVJDSmpja3dScHZBUnBCTVZWc2VWMmNObDROMWVOOGNad3RIa1U1bm5n?=
 =?utf-8?B?QzRmZ3VRNkNTemd0cncyNTFCYTAvK3lWYXp5Z05Vc2lDd1NING93NkRlbzV0?=
 =?utf-8?B?NWM5amVWaGs4a05vNDkvWjFjZ0gvQmEvZ1QyUmtYVlY4NWQzc1U4VmFnNzBs?=
 =?utf-8?B?UmNGWm5kdFdSSjZFRzZMVnpadnBiU1ZaenREaXdGQjd4aWVYbytsOGRlT1dS?=
 =?utf-8?B?NkF2OHVaaEhYTzhjMFRtMEhtTnNuSXZVZjQydUhtNDdmZHRUTnJzN2hveVlE?=
 =?utf-8?B?OE13d29NYkU3bFp3SWJpUGJjVzdWT1AvbVlOS0JVZ1FTWHN1Z1lGODJ0bzd3?=
 =?utf-8?B?OU90U3RiaHczUUlxNjNpWm02RjdmSTBIUnFYQm9Sb3hDKzk5aktvdzFQQlYz?=
 =?utf-8?B?L1I2TW45eGoyOFlKTE1pZW1ITS9hVWluSlFVRytORFZ5QWtBeW9SQkhyRU9t?=
 =?utf-8?B?bHNZbEtwRU5wZmxJU2thY3c4VnN5MkpRalJibS9Id1JaMUFDZ2hqNVVKNG1l?=
 =?utf-8?B?akl0OTg4aVhJdndLbURHQXlhM2FnQWM1cHNua1hPSThHcHVLRm8zaVY5NzB4?=
 =?utf-8?B?WC84YTJLUDVVUXk4WGhQRUMxcHI1cU16Qno3OVJNaDFFWUlGUG9hSEhNUnFS?=
 =?utf-8?B?ODIyYkRENG1oWEY2aWFDemlXcW54S2ZJeFE1R1FZNlNPbXFRc2N2aHNMT1hh?=
 =?utf-8?B?Wmp0SFZYdU5lMVhmUlZkN0RuMFBSZzg3NU9uV3hlWHJneEtwRlA1SnlPM2dJ?=
 =?utf-8?B?WlNZOWxVczZnMHNMQXEwTWFVZGZkVHRFZmlCd1pTZDFNRnJQNzdTMWdVcFEw?=
 =?utf-8?B?Zk1LUWhRbGk4K1o0Yzlva0ZicllaVGR2L3g3dmhKUnFuOEVtT0JYNW5PNWFu?=
 =?utf-8?B?ZmhtL1dYbUQ1bmZJYitwM0U0WHZXaksyN0xMcVVqTDR4RlVxRStjZlhxb1RE?=
 =?utf-8?B?QTFVMVplbmhycStDV282KzVsdStSR3NmODRkYXc0S2NjRzlFTVJQT3NkMDFx?=
 =?utf-8?B?Ry95bVhESW9sUDhMUEllU1JZV2dpUCtIYlFlQlZOUXBSODZuckRMbi9JZXJE?=
 =?utf-8?B?V1ZhR3ovRFk0V0dkbm9aZjFsbWpoOUYvaXgrMi9wbmF2dUFKSHNwQ2poRkRo?=
 =?utf-8?B?a2o1SEtsb0srMkVqL0hQYlU0NllsMHEzY29xUjZmR0hPQlhZRUEyUnVSY20y?=
 =?utf-8?B?c3pjYlZvQlQrU0RkNEs3TU5ySEZraWVCRU5reUVsQWxJcC96UVpPVmhjcExl?=
 =?utf-8?B?S2w4S21Ndm8zNHFKcFByaGMveHc0ZmVNV3BPa2U1anI3Uk1IeHlnVldPNXpB?=
 =?utf-8?B?bURNbElxdklJT0RWRTNNVldnL3FMNm9uV1lld09tNUlzUnVYQlNqdmhvb3FM?=
 =?utf-8?B?ZmFzblR6MHA0akFPWnhFZW84NXo3VWsvTzRnVUs0YnFiZDUycDkvVVR0Znkw?=
 =?utf-8?B?amc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: e5b045a0-56c5-4457-8c65-08dc80d22ed5
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB5089.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 May 2024 17:58:59.7779
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 3XBunaK/sX3YWw5i5WMD9ndcMM4t1VG5w9gLPgrACV03vhQo7DLShLWTBLPNIqYTMry0Kvog0621v3WURJjxXWqmA4+u/UGTnj3VCD+o9eU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB5140
X-OriginatorOrg: intel.com


On 5/28/2024 9:15 AM, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> Each object file contains information about which module it gets linked
> into, so linking the same file into multiple modules now causes a warning:
> 
> scripts/Makefile.build:254: drivers/net/ethernet/hisilicon/hns3/Makefile: hns3_common/hclge_comm_cmd.o is added to multiple modules: hclge hclgevf
> scripts/Makefile.build:254: drivers/net/ethernet/hisilicon/hns3/Makefile: hns3_common/hclge_comm_rss.o is added to multiple modules: hclge hclgevf
> scripts/Makefile.build:254: drivers/net/ethernet/hisilicon/hns3/Makefile: hns3_common/hclge_comm_tqp_stats.o is added to multiple modules: hclge hclgevf
> 
> Change the way that hns3 is built by moving the three common files into a
> separate module with exported symbols instead.
> 
> Fixes: 5f20be4e90e6 ("net: hns3: refactor hns3 makefile to support hns3_common module")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---

This one has a savings of ~72Kb on my system.

Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>