Received-SPF: pass (google.com: domain of linux-kernel+bounces-195771-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <7143f846-623d-465f-a717-8c550407d012@intel.com>
Date: Thu, 30 May 2024 11:15:53 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH net-next v8 2/2] net: ti: icssg_prueth: add TAPRIO offload
 support
To: MD Danish Anwar <danishanwar@ti.com>, Jan Kiszka <jan.kiszka@siemens.com>,
	Dan Carpenter <dan.carpenter@linaro.org>, Andrew Lunn <andrew@lunn.ch>, Simon
 Horman <horms@kernel.org>, Diogo Ivo <diogo.ivo@siemens.com>, "Wolfram Sang"
	<wsa+renesas@sang-engineering.com>, Randy Dunlap <rdunlap@infradead.org>,
	Niklas Schnelle <schnelle@linux.ibm.com>, "Vladimir Oltean"
	<vladimir.oltean@nxp.com>, Vignesh Raghavendra <vigneshr@ti.com>, Richard
 Cochran <richardcochran@gmail.com>, Roger Quadros <rogerq@kernel.org>, Paolo
 Abeni <pabeni@redhat.com>, Jakub Kicinski <kuba@kernel.org>, Eric Dumazet
	<edumazet@google.com>, "David S. Miller" <davem@davemloft.net>
CC: <linux-arm-kernel@lists.infradead.org>, <netdev@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <srk@ti.com>, Roger Quadros <rogerq@ti.com>
References: <20240529110551.620907-1-danishanwar@ti.com>
 <20240529110551.620907-3-danishanwar@ti.com>
Content-Language: en-US
From: Jacob Keller <jacob.e.keller@intel.com>
In-Reply-To: <20240529110551.620907-3-danishanwar@ti.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RkNJbEVLTXNSQnlDTy80d0ZBekVVUUxNQW1KdG5jMzVvcGpFRXNtYlZIYWRX?=
 =?utf-8?B?QWxkcmQ4RVpoZ1o3czZJRUZUWlFpTkE2NUorc25XRGtTRFVEWWxIWDVoVy9Y?=
 =?utf-8?B?RHFhOUhIRng0UitwZXFSZ0FBOHR3aVZUMDJaTERxRitYRm5DU0dxSzY4RU52?=
 =?utf-8?B?MksrZENMdnJPVTgzN2V0Ky9XL0Q1NWs2S0RlM3luT05nMG1DY1JyREdSS1dj?=
 =?utf-8?B?cXVVb0p4SVh3RG1LNGJvUXBLSWFkZ2JKbEh2OU11NytvclM1NjAzdkpHQkFU?=
 =?utf-8?B?MTBXOC9GYmlhSmpkRzI5b3NnbEdaeGRUM1JTc011YWQ0aEFvK1RFRVhIMzZi?=
 =?utf-8?B?R2s3ajdKTDNBdU5KM3Y5TFh3empCY0dLY2gwQTIzeVJXbjdhRUhYQ0lTS0xO?=
 =?utf-8?B?amV2RUVnUkxyTk5mazRwWjBTcnFPbEhpTkJJRXVrdnAwN3VsSld3SzF4U3Zo?=
 =?utf-8?B?dnpWMTdZQWZQWVVHYTlJU213ZU1hVFM1U1RkZlZSRy9RSE0rK0pSdytpYjVM?=
 =?utf-8?B?SkZDM016N1M4dFUrWUdTMjd5Vys3SDJkTlp5WEthamtXNDk5ZjQ2WXpKRWJM?=
 =?utf-8?B?SThwU3MrcEU4VVkyYjRqb0MrT3BTREVZNVZlN05yUUpFWkd0UUhvc0syS0hn?=
 =?utf-8?B?MnphRk5ZL1BqZGJ4MGFDbFBsYk54VVBCcExuUHlGb0dsUzNqRXczNVFnLzZL?=
 =?utf-8?B?Z0RNcmFpQjNHNVpwZzVYRFFHWGR1dXZZcG1VU21jTnVKM3F5Wm5LMVMzdkdh?=
 =?utf-8?B?eHQ3eHV4K0IxYWhyaWd3ZnNmLyt4WHRaZHZIbVVwKzRlVHZFV0lDbGtCOG15?=
 =?utf-8?B?N3hXNk9hTVJab1FWOU84TFhpdXZEK0FvNllYUThCa0l5UlhGZkF5SkdSZ1ha?=
 =?utf-8?B?c2pQM2drYjNlVzZyRTBHL3BJbDROWFgyNDYzeFQ0TU5ZWVhaWGFzRC9uUEJv?=
 =?utf-8?B?STZyOGF1dEQxK2F6dENWcUl2THBEVVlQWFZ5L01yK1ljMnRVQU9EUEJyRzlw?=
 =?utf-8?B?aDBHSTZCN1NpUnBhc3IyN2FCeDRZOWt4Z2E1MmJlZWRNTXN6cjRib2VaVERx?=
 =?utf-8?B?TFY5ZDI5UllrZEduOTFLdThYNVZJUDJXaS94TkdZQ2ZWT3JzQ2UzTERSVnZI?=
 =?utf-8?B?MWRFL1I5aWVFaFpScDFTRW5WMWVseTVjZnpVWjZFdFBVQW9ETDVtV0VTblhU?=
 =?utf-8?B?amoyc2ZGWm9YVFU3WjJldyttTXZBTSttZHJsa2x1bUE0M0ppcm5sK2E1TWZw?=
 =?utf-8?B?TTU2bW5mOFcrYlljU1NOL1h4bEQwUGpnYWFuS1p6RitkQnVYVExVbHV1YndO?=
 =?utf-8?B?MTZsa2VROTV3aEpoSG9tOUlnV290MzczVUYrY2xMc3VMbEJTSWVvM0dmdmx6?=
 =?utf-8?B?RjF1eUJaQU5OeDdjS0ZMeDlJNWJ3RHprdm5kRWR1VmRlMWN0WFVzZTV2b1k0?=
 =?utf-8?B?L3ZvVkptdmx2MUsvYWxoYWw4RnRHdzdLSlArdnE4Q28wT0hsQ0lEcWI5b0Z4?=
 =?utf-8?B?TE5CTjIyNUNPVHNaYXFPRWk3a01lMWwzZXZHY1RCc1Q4N0RvTXk5eUFubmVF?=
 =?utf-8?B?QVg4dVplY25FWGJvVGRzMFhwOUZ0dSs4TU5wbmhveVlFQU90Vnp3bDJIcUFF?=
 =?utf-8?B?YnVFZjY5dHE2VWxUeFFGMGdkQnJ2MXZ2QjdGT21mNXJvVWh6U1U1YkF6OUNv?=
 =?utf-8?B?L25LVzQvdXVFU1plNDBiRHlVRXYvV3lvWGpXNk1QWFM2Nk9vZVZnUklWYU4z?=
 =?utf-8?B?VUV2dmpFeVoydG0zd3NTcTMyOU93UWhvM0UwTHNIN0ozVmlOejRNVFRQakRN?=
 =?utf-8?B?cVh3dzlTR1l1UjJraW5LTzJ4dHFUN0o4YTNOajQwN2ZyelBoUjNud2tCL1NF?=
 =?utf-8?B?YXJzeEpsNFpJYjVsRnV0SUVUWUdhdyt3U0pFdEJCbWNjMWRKYVJPNVBodGYy?=
 =?utf-8?B?T1hIVnQvdVZZRTcrTllPcVcyTDBWTzJYT3VBby9USDg5TFVKSk5EeVdtWjcr?=
 =?utf-8?B?K252aFl5eXRUOG5Jb0J3N2lWeEhqTkowQVdQQVB2Q1JHc2pQTm5hdEwySkNm?=
 =?utf-8?B?bjkxQ2RPVHl2enVHdXpISlhDandyaTQ5TVpVTW4rRk53c0pKbGZPdFZCRVFu?=
 =?utf-8?B?Vm40WGVPc3lyNWRGTTQ2NFlqZ05oYnI4SnFmR0I3N1pCcXV1MU1vVHFUSFVj?=
 =?utf-8?B?VkE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 8ee8f095-add9-4437-e554-08dc80d48c11
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB5089.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 May 2024 18:15:55.1932
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: QHnPKYgrtwBOjgwOMPnJqO0vHy9ynMzxlM5XvhRkQ//v9YnjiI0Je4Wt4x52XKnby3CCxYyjDYqfx9kBtAQIQmFUleP2U0I29yKaGnNz39A=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB6421
X-OriginatorOrg: intel.com


On 5/29/2024 4:05 AM, MD Danish Anwar wrote:
> From: Roger Quadros <rogerq@ti.com>
> 
> The ICSSG dual-emac / switch firmware supports Enhanced Scheduled Traffic
> (EST – defined in P802.1Qbv/D2.2 that later got included in IEEE
> 802.1Q-2018) configuration. EST allows express queue traffic to be
> scheduled (placed) on the wire at specific repeatable time intervals. In
> Linux kernel, EST configuration is done through tc command and the taprio
> scheduler in the net core implements a software only scheduler
> (SCH_TAPRIO). If the NIC is capable of EST configuration,user indicate
> "flag 2" in the command which is then parsed by taprio scheduler in net
> core and indicate that the command is to be offloaded to h/w. taprio then
> offloads the command to the driver by calling ndo_setup_tc() ndo ops. This
> patch implements ndo_setup_tc() to offload EST configuration to ICSSG.
> 
> Signed-off-by: Roger Quadros <rogerq@ti.com>
> Signed-off-by: Vignesh Raghavendra <vigneshr@ti.com>
> Reviewed-by: Simon Horman <horms@kernel.org>
> Signed-off-by: MD Danish Anwar <danishanwar@ti.com>
> ---

I tried to apply this series to review it. Unfortunately It no longer
applies cleanly since it has textual conflicts with 972383aecf43 ("net:
ti: icssg-switch: Add switchdev based driver for ethernet switch
support"), which was part of:

https://lore.kernel.org/netdev/20240528113734.379422-1-danishanwar@ti.com/

The conflict seemed easy enough to resolve, but I'm not sure if the
prueth_qos structure would be placed optimally. I tried to build the
driver to check what the placement should be and was unable to get
things to compile.