Received-SPF: pass (google.com: domain of linux-kernel+bounces-195776-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <8363b014-dd75-4dfc-a248-85a2aa129cce@intel.com>
Date: Thu, 30 May 2024 11:23:55 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [net-next PATCH] octeontx2: Improve mailbox tracepoints for
 debugging
To: Subbaraya Sundeep <sbhatta@marvell.com>, <netdev@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
CC: Sunil Goutham <sgoutham@marvell.com>, Linu Cherian <lcherian@marvell.com>,
	Geetha sowjanya <gakula@marvell.com>, Jerin Jacob <jerinj@marvell.com>,
	hariprasad <hkelam@marvell.com>, "David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, "Paolo
 Abeni" <pabeni@redhat.com>
References: <1717070038-18381-1-git-send-email-sbhatta@marvell.com>
Content-Language: en-US
From: Jacob Keller <jacob.e.keller@intel.com>
In-Reply-To: <1717070038-18381-1-git-send-email-sbhatta@marvell.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cmJSUG1vQVhpN0Y3aG9yc3plR1A0OWxFVFhiL0VyUnczR3hmNXpYSHBTR3dI?=
 =?utf-8?B?QlpKeFpUZU5FRkxSd3Z0M2RoZXZyMWlnY2tNTXBsamlSaFA1MHBVV1RaY044?=
 =?utf-8?B?VFcra2VEaFNPbW5HK2xTU0dwYzdsc1pYWkl4dEs3UDI4NndQcTEvL3ZWbWJl?=
 =?utf-8?B?N0RKak5KMVRnZkFEL2JjL1U5QVJDcGNwZEtJa3J4dUhSQ3cxZFA1WVU4Z0lJ?=
 =?utf-8?B?RjQ0SWkzVW5wNGx2UVhINkl2cExhZ1hPTnlTY1lOY3ZhNDc4Q1NkSlpUNEFU?=
 =?utf-8?B?N05nZUVkZHp0TUdjZytKZjg0a01XNVdPNWdVOXZhRStiKzNCU0ZLcEh3NXcy?=
 =?utf-8?B?QU5zWFlJK1NTdThlcnlnRnduOUFYN0JrREs4Y3lrOTI3VzdVV3FuUnF2eVQw?=
 =?utf-8?B?S3RTd3ZPeVRUZncycFBUTjIwVDM5VXFKUmc1eE5mQ21pMG4ydUxYNlJORnhi?=
 =?utf-8?B?NVJhN0dTNXF0MUh4RnBxSXBIQTQzZTBTV3JYSU1qemMyaFNISVRlNGw0dG1m?=
 =?utf-8?B?aVdXcE1SaytKVFV4RThicGphUURmMGtlY0UrQ2toY3lMR1VHRDIvd01LMWRi?=
 =?utf-8?B?OGRCM1lqT1BnTmk3L3c5NVhrQ05HZmtBbEZkc1JDQkd2ZXNUUWpLS3pTMktM?=
 =?utf-8?B?T0tSeG1SMW5WWFVKempwZCtXZ1JMY1h1L0dKdlBaMHo1QlNhVGhZT0tyM3dH?=
 =?utf-8?B?Q3hGVVY0dkNoU214NkYyR21tcnJCd3hpRVRGeENhY0Zmdk5KV1NRYVUzdWp6?=
 =?utf-8?B?aGc5ckJTRzNwbjJPTkhDcHozUC9TN3VKL1gvaDE4c1NQVUJ6a2tuWDg0d2tB?=
 =?utf-8?B?U1JDZzN6SXFMWjZGQXU5cEprdU9xd3Z6aW5DdnpWV1EzMDNZMi9oMHBTREx3?=
 =?utf-8?B?Y2FuNnowUE92d1U0QVhPVElrZ1BKSGovcnl3OTllVGd2bnVhaGs1dERvK1Bl?=
 =?utf-8?B?aTc3WldqbmtLM1pDbWhVZmVJZXZvWittMTg0VDdNaDlLSVVINUJQRnZPandS?=
 =?utf-8?B?MjB3Q0sremczYzJadzFrVWJGTnhPSHQzNXlRdk84MUFsc3R1dGh4REgwdlEz?=
 =?utf-8?B?ZEJqTkI1OU03MFAxazZqSEFXSlVWQjJrblBpQjl0TDJYb3ErbzRIKy9YNkoy?=
 =?utf-8?B?M3U3empDdC9zZnlxd0diWm03VlNBU2htTjQ3aVpTZHUwdVhleW4rV2FBS21q?=
 =?utf-8?B?S0NaQWFqcmtvajd3T2tycW9ZRjUvQ1lrNitCNysrYTZqZGFBSmRncXFUemYw?=
 =?utf-8?B?UVFxT2VvNmJCUHdrWXVaMjEvbFhDT2dlTUlCZ0ZXYnhXNGVQTktheWYvalhN?=
 =?utf-8?B?bzBjay9HOHF4RG12Sjhwa09YVXo0YWxCZVBJRzdDS2ljU2RhNU1aZzNUbDNi?=
 =?utf-8?B?Y3VNd3NHVU9Bb3QzK1JaTFFwVjJUN3NZdEVQaEppeFZIYk9hY0R5U3dpQVN5?=
 =?utf-8?B?ZDM2b2tST0M1UW1iUjAvUVZPOXRFclVLeGloSCtJL1VUSmZuYTMzNkJHdTNI?=
 =?utf-8?B?NUE2Ym1Rcys5UE00WHJIalNtT2lFamFmSGtKc2JoKzAwY2NtNWFQbEdYR0NW?=
 =?utf-8?B?cDFXVjlCdXcxbE5ZelUzTFQ3ZmFzS2kvaUQrSlVYemRTbmFwUkdRM2FpNmhS?=
 =?utf-8?B?ZzhQSWxUYUpyeXRRVU50OWZSU29vc0NjVlU5RWJDTVhyRlJWLzhXTjN3SDJC?=
 =?utf-8?B?d0tHRXlaTHFoODRqTWUwMUt4OHYzMi9Oc3Z1S3k4RlFkR1AvZk9NNUhjT2JG?=
 =?utf-8?B?UlRGdmkxa0Jaa3FjeWdkMnQ3VEtRbHVXN1Y2N0Y4YlFKYStJUzQ1NDhGMWJH?=
 =?utf-8?B?N3N0TWdsZUdURTVKNy9RRHNpcVRVc2hRbENRa1ZDWmMwOTJzQUdUcUFwMi8v?=
 =?utf-8?B?SUI4MkwvWlYxdzBqakJFYVNCSnFIeTFudDNVMCt1UTlSM0g4VHhQMkZqdnRO?=
 =?utf-8?B?aGQ2bWo1WkU5QkljY3orYU1pckdnNW9VTFhSanA2MEJ4RHhibGZ5OEJYMHlB?=
 =?utf-8?B?amp3ZnVQcGxyYUlKS1ZtWjdBTExPK2VLT1JNY1lia0JpNnR0bFY4c2xBR0Rh?=
 =?utf-8?B?cnluNzdNWUwwMkFRY0xBTnQveXVOeG4vaDBCNjhYTE5zdDM5Zk5oSGIwUHhY?=
 =?utf-8?B?Yk4wdXA0bERvSkFRMGhnNy9abE5sV0cxVW9VcFFRb3VybithaGlRYWRtUVds?=
 =?utf-8?B?Mnc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 9eea355e-0c93-48f1-ae89-08dc80d5aae3
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB5089.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 May 2024 18:23:56.3867
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: wkxruU+38pSwqfpH1JcSHPQZNRqCHNWgm5HOjgrugD2BjmY4jPjYaVGi49NEpsEVwwsqUg9OChiM7MZ13OyHdQuBjz0OqfFIxnITQnOo7bw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR11MB8076
X-OriginatorOrg: intel.com


On 5/30/2024 4:53 AM, Subbaraya Sundeep wrote:
> The tracepoints present currently wrt mailbox do not
> provide enough information to debug mailbox activity.
> For a VF to send a message to AF, VF sends message to PF
> and PF forwards it to AF. This involves stages of
> PF receiving interrupt from VF, forwarding to AF, AF
> processing and sending response back to PF, PF sending back
> the response to VF. This patch adds pcifunc which represents
> PF and VF device to the tracepoints otx2_msg_alloc,
> otx2_msg_send, otx2_msg_process so that it is easier
> to correlate which device allocated the message, which
> device forwarded it and which device processed that message.
> Also add message id in otx2_msg_send tracepoint and new
> tracepoint otx2_msg_status to display the status at each
> stage.
> 
> Below is the trace log when a VF sends a message to AF with
> this patch in place:
> 
> ifconfig-523 [001] ....   146.134718: otx2_msg_alloc: [0002:05:00.1]
> 	msg:(NIX_RSS_FLOWKEY_CFG) size:28 pcifunc:0x1001
> 
> ifconfig-523 [001] ...1   146.134719: otx2_msg_send: [0002:05:00.1]
> 	sent 1 msg(s) of size:32 msg:(NIX_RSS_FLOWKEY_CFG) pcifunc:0x1001
> 
>   <idle>-0 [000] d.h1   146.134722: otx2_msg_interrupt: [0002:05:00.0]
> 	mbox interrupt VF(s) to PF (0x1)
> 
> kworker/u49:2-238 [002] ....   146.134723: otx2_msg_status: [0002:05:00.0]
> 	PF-VF down queue handler(forwarding) num_msgs:1
> 
> kworker/u49:2-238 [002] ...1   146.134724: otx2_msg_send: [0002:05:00.0]
> 	sent 1 msg(s) of size:32 msg:(NIX_RSS_FLOWKEY_CFG) pcifunc:0x1001
> 
>   <idle>-0 [000] d.h1   146.134726: otx2_msg_interrupt: [0002:01:00.0]
> 	mbox interrupt PF(s) to AF (0x10)
> 
> kworker/u49:1-184 [000] ....   146.134739: otx2_msg_process: [0002:01:00.0]
> 	msg:(NIX_RSS_FLOWKEY_CFG) error:0 pcifunc:0x1001
> 
> kworker/u49:1-184 [000] ...1   146.134740: otx2_msg_send: [0002:01:00.0]
> 	sent 1 msg(s) of size:32 msg:(NIX_RSS_FLOWKEY_CFG) pcifunc:0x1001
> 
>   <idle>-0 [000] dNh2   146.134742: otx2_msg_interrupt: [0002:05:00.0]
> 	mbox interrupt DOWN reply from AF to PF (0x1)
> 
>   <idle>-0 [000] dNh2   146.134742: otx2_msg_status: [0002:05:00.0]
> 	PF-AF down work queued(interrupt) num_msgs:1
> 
> kworker/u49:1-184 [000] ....   146.134743: otx2_msg_status: [0002:05:00.0]
> 	PF-AF down queue handler(response) num_msgs:1
> 
>   <idle>-0 [000] d.h1   146.135730: otx2_msg_interrupt: [0002:05:00.1]
> 	mbox interrupt DOWN reply from PF to VF (0x1)
> 
> Signed-off-by: Subbaraya Sundeep <sbhatta@marvell.com>

Makes sense.

Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>