Received-SPF: pass (google.com: domain of linux-kernel+bounces-195783-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <1e14ca4b-6e3e-4d57-acec-bc3ee2bed6ed@oracle.com>
Date: Thu, 30 May 2024 14:30:04 -0400
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] perf/x86/amd: check event before enable to avoid GPF
To: Ravi Bangoria <ravi.bangoria@amd.com>
Cc: harshit.m.mogalapalli@oracle.com, peterz@infradead.org, mingo@redhat.com,
        acme@kernel.org, namhyung@kernel.org, mark.rutland@arm.com,
        alexander.shishkin@linux.intel.com, jolsa@kernel.org,
        irogers@google.com, adrian.hunter@intel.com, kan.liang@linux.intel.com,
        tglx@linutronix.de, bp@alien8.de, dave.hansen@linux.intel.com,
        x86@kernel.org, hpa@zytor.com, linux-perf-users@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <1716990659-2427-1-git-send-email-george.kennedy@oracle.com>
 <75f6aba1-8ed6-4ef8-8811-de40ae40be90@amd.com>
Content-Language: en-US
From: George Kennedy <george.kennedy@oracle.com>
Organization: Oracle Corporation
In-Reply-To: <75f6aba1-8ed6-4ef8-8811-de40ae40be90@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?d0FPZ24zMGVVd29oSFRMcHRMdFdxMmlwclR6aHZPb1ExUWswSzdBRExMY2RK?=
 =?utf-8?B?U2gwa3ZHelNLR1dkVUREaFZkdlhWc2dpSmVpT1B2YnB1Z3NWclBBV2x2RUUr?=
 =?utf-8?B?MURxbUJFQTV1Y1l0MWVtbUdKaVFhYlJJR1VMY3A3eTBKY2Z6RTdFZldTOHZM?=
 =?utf-8?B?ekhhR1dxc25jRGZ2RDgwWTVWUzIvL3I3OC93SzhZYWlBWmFmOVZqT3pnZjJh?=
 =?utf-8?B?QnUzN3pLMWFWM24wSGhzTDRkYkl0d1VseUNHeWRNZHhMZkZTQlZGVDZSMXFC?=
 =?utf-8?B?RUJ5bjRYdmFuSlZHY1V3NEJlTXkvRVErUFFYVGlZOXlrbjd0WEVRTmpIT3hT?=
 =?utf-8?B?SWxldGV2Q3NQYloxOXhFU2U2MWZMSy9VSjl3Qmt2QVVyeU44SHlwZGVlblBG?=
 =?utf-8?B?UFlHYytMSCtCTmxUL0YrRWwyL0YzWjVQcmdjU3ZwZzZ4K0dxM2V0emZqT0JO?=
 =?utf-8?B?SnNOeGRlM0s3SmVPbUNRSUlHNUZ5RzMyN1hacUtVdm1qRnZwLzUrczEzNVB5?=
 =?utf-8?B?a1BleHJ0NzJ3UkcyVjFuWTJBMVNWUGNiR29INEtSU3dPVFc3YkI4NEVGVXpR?=
 =?utf-8?B?TE1GWmp3Q0ZJV21CS2NlZWlQMTdEaHpwNXk0NEltdEtwT1d2SERTV01HV2J1?=
 =?utf-8?B?WGFTZHR2K2JZRXhCaGd4QmNZNVUxNVhFbjh3allLVDg1d0dlSXdQaWNqelRl?=
 =?utf-8?B?eWhKbEpreHFLR1JoM05qSnJIOGZCRDVzdm13OEVzeTAvR0QxeE5vWDdyMktZ?=
 =?utf-8?B?WUxqT0dwaXpveFh3SnhzbkxiMnZFWHhTeFVMdldSSVJKWU0xd0k1YkkvbnRz?=
 =?utf-8?B?akhwMm1xTWczY1ZzUTU4Q3BQdFJwUnhTLzN5R3lsaGdRN3dkMWMrTVV3Q0lx?=
 =?utf-8?B?amgyT3VLS3hMcEFpVW1zTVcxWVhtTkJDQjJlcGJ5Ri9yOUVxM3JrSTZHZHNh?=
 =?utf-8?B?RXN4RkZOU01tcnBRTDBpeHkxUFNtMjExVUdocFRqejRzc2cyRUJjYjRPWVIv?=
 =?utf-8?B?MVhVcmtpaVVxSTdmcFFXcVV5eDVjaW9hMlpZUUkxNTNHN3Z3dUtNL0NXNllw?=
 =?utf-8?B?aGw3bndKdTRLSzJEMDJMdEVzUnA3VWczU3F1eWVyb3FnTFNUd0xjTUtNdWU4?=
 =?utf-8?B?Ulp0K3hYWFEwcUNBVDlzQlRUK1BKdjRlTGJtbUdOM0JjQ1lMWFJERUlwU0Vi?=
 =?utf-8?B?V0l2TllFZHgraU5XRTRqOGEzNk1IcDY2d2FXdjNwUk0vaGRhWGh4bGZOVlVr?=
 =?utf-8?B?VVZNSEYxbmRRZ2REcmlPOTJNVWZpOG5LOTRyMUV3OVlMR0dtM3RQMEhXZ3Np?=
 =?utf-8?B?dXE1RSt3MG91eXRPMTdwRVpWLytHbTdjNTcwM0hId0tHMjlKTnFSenF3Z0Q2?=
 =?utf-8?B?Nmk3ay9iVW1Ua1RIc3duVFFNaTVoQjlDWTdqeSs5dktOeVloOHlkamFXWFlS?=
 =?utf-8?B?ZGRyaTdxQ1FXWXczNXhDamx0bkhGZURsSDIwb1dUMitqYm54bFMyeFErUGdx?=
 =?utf-8?B?ZkRVMzEvVllIb3dGUjgzcFZpNitjVEtMN3lWdGRVNEhaV2g5bzR2WlF5TUVZ?=
 =?utf-8?B?dUg1aEJLOHBtQTU2QVhVb1JkajNiNG5hNTVRSXhsOWhETjBzdnhuYS9pVFVy?=
 =?utf-8?B?dmRhamUvUy9TVWowWng4cml1T0tIc0hCNmhueDVlTXJaZFFCeXdiRjVSN0No?=
 =?utf-8?B?czR6YVZJNGxTVHNFNHgrbmk1cGVZdFZ2THFZTDRMajkrYnA3RVNhK2JaUkh4?=
 =?utf-8?B?aVd6aytFZ2laRnpDZWJWS0FaU0M4dlVEMVN5NjdpRFN1aHJoTUd5VHZLUVJn?=
 =?utf-8?B?bUIwOEtSTnhxMXlpOFJQM2FpdjZHdDgwcXNKeFF1Mi8vUEROeXI4SFgvRG5h?=
 =?utf-8?B?ZnNHVklsZVI5dm9SZU4zSkRhNTZBRW9sanZPL2xISElvSzZKOVFWVzg0TTZx?=
 =?utf-8?B?YVRnV1RGVll3ZTZ0SXIxK3hGKzR3Uit6NU1oMk44MkZXYm85emdWV09VVS80?=
 =?utf-8?B?VzJibUZjKzcwR2dmdmdxemZOcnNoa2FvUGdDV09LbDUwYnNBNjZrYTBLOFBr?=
 =?utf-8?B?RXBSMDBNVyswUXhXS3dBMklXb0dzeWtDa3V1TUdKZWwvaDhZWnhUUUpqZ2hT?=
 =?utf-8?B?MjNBQytIQitvOUQyZVlmajRtYytnRWNoakVlcEVKNlQrQXpJYWdHaUs5Ritk?=
 =?utf-8?B?OEE9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	I4mio2J/KC+A9a/vbqOcommzTqM8Qe3+bkUoNWTHWpyL/4XuNyxof3+B8SHaHXvvMBT2ajcRAVRZvqa4++L17POyJZzPXbqNsVUzCTO6h7GQhjobk+a0QgyTFads2WepPMb/Ob0Q2U7gU6hnuoXLhw7do6oM84lnYVf7XlPzXDPGn4E7hIz8jeTmJf94NiBmDUSJV9P42bgQh9CZGEredphoaj2cd1IFhyfD0AH3R05UfpMd/YyXSemCO2VLPScT2kVNjLP7TLHItAj8afLjULDkZIWn5MF3ehHQUtMZwfIFwyyyLBLqap9q2C02rTRWv6wJ9aplg7W1iXsn4pV2e56GAuoOFshv4g6C72G5N+tQ72xpfwsEmyLzuqMlm3CBo+BBjFY8cg5WzgqZB7pr5uuJU115fKaQkpcopjjTTJuactAO7gIGZKVynPQH0An6T+BJ5RMqDzN5OjgscG/8XFyEN34oorV03CpQerxoFdC8M0VcR/CZXJegIN3/ExzXxHijosk5cSynNkDJTny3cThBJADAHwZzfyIw3QjJNQxKUtL360k+nYtpkCPlvp0lP9eBa65EoMZbzi0fL1Ubyai5gXQI7sIoVz3X5LRRC70=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6cc2e276-a868-4696-bb55-08dc80d68979
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB5895.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 May 2024 18:30:09.9330
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: fB8EkGwvey0yMzENeznsc1BuO4E1+4IX5Nth7GBldhJXK/iCXI9J+RSVRfEuvJMLfSc2FWpExQFdWm/PRR8JsNvdeZ/mbNdbN3gpXLK0TMA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR10MB4340
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.650,FMLib:17.12.28.16
 definitions=2024-05-30_13,2024-05-30_01,2024-05-17_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 spamscore=0 suspectscore=0
 adultscore=0 phishscore=0 malwarescore=0 mlxlogscore=999 bulkscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2405010000
 definitions=main-2405300136
X-Proofpoint-ORIG-GUID: AwOSiyslXyNEhCp8Rf6sHVzjLokOYMxP
X-Proofpoint-GUID: AwOSiyslXyNEhCp8Rf6sHVzjLokOYMxP

Hi Ravi,

On 5/29/2024 11:37 PM, Ravi Bangoria wrote:
> Hi George,
>
>> Events can be deleted and the entry can be NULL.
> Can you please also explain "how".
It looks like x86_pmu_stop() is clearing the bit in active_mask and 
setting the events entry to NULL (and doing it in the correct order) for 
the same events index that amd_pmu_enable_all() is trying to enable.
>
>> Check event for NULL in amd_pmu_enable_all() before enable to avoid a GPF.
>> This appears to be an AMD only issue.
>>
>> Syzkaller reported a GPF in amd_pmu_enable_all.
> Can you please provide a bug report link? Also, any reproducer?
The Syzkaller reproducer can be found in this link:
https://lore.kernel.org/netdev/CAMt6jhyec7-TSFpr3F+_ikjpu39WV3jnCBBGwpzpBrPx55w20g@mail.gmail.com/T/#u
>
>> @@ -760,7 +760,8 @@ static void amd_pmu_enable_all(int added)
>>   		if (!test_bit(idx, cpuc->active_mask))
>>   			continue;
>>   
>> -		amd_pmu_enable_event(cpuc->events[idx]);
>> +		if (cpuc->events[idx])
>> +			amd_pmu_enable_event(cpuc->events[idx]);
> What if cpuc->events[idx] becomes NULL after if (cpuc->events[idx]) but
> before amd_pmu_enable_event(cpuc->events[idx])?
Good question, but the crash has not reproduced with the proposed fix in 
hours of testing. It usually reproduces within minutes without the fix.

Thank you,
George
>
> Thanks,
> Ravi