Received-SPF: pass (google.com: domain of linux-kernel+bounces-195797-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <46b4e8f4-e86a-4755-8e82-a3975973c43e@intel.com>
Date: Thu, 30 May 2024 11:43:08 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 1/3] net: ti: icssg-prueth: Enable PTP timestamping
 support for SR1.0 devices
To: Diogo Ivo <diogo.ivo@siemens.com>, MD Danish Anwar <danishanwar@ti.com>,
	Roger Quadros <rogerq@kernel.org>, "David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, "Paolo
 Abeni" <pabeni@redhat.com>, Richard Cochran <richardcochran@gmail.com>,
	Nishanth Menon <nm@ti.com>, Vignesh Raghavendra <vigneshr@ti.com>, "Tero
 Kristo" <kristo@kernel.org>, Rob Herring <robh@kernel.org>, "Krzysztof
 Kozlowski" <krzk+dt@kernel.org>, Conor Dooley <conor+dt@kernel.org>, "Jan
 Kiszka" <jan.kiszka@siemens.com>
CC: <linux-arm-kernel@lists.infradead.org>, <netdev@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>
References: <20240529-iep-v1-0-7273c07592d3@siemens.com>
 <20240529-iep-v1-1-7273c07592d3@siemens.com>
Content-Language: en-US
From: Jacob Keller <jacob.e.keller@intel.com>
In-Reply-To: <20240529-iep-v1-1-7273c07592d3@siemens.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZGp3eXNGUEhkeFhZSkxRZzFxdllyQkZScDk1Wk1JT29OalgrSHpHRnBKQUNY?=
 =?utf-8?B?R1JYK0VLTzJheUc0WktuZzJCWDQvQitjTE5aTTZ2U1pXSEtkYTB2QmlTVHBq?=
 =?utf-8?B?VHJLQS91VHlkUTVDZEhNOXVsZmhYQ1NXNE9BdURMKzBzTXBqUnBVQktxRGIx?=
 =?utf-8?B?S0Z6clJtN2FJbFF6N1Q3ZTZQVzd3QVp6K0pKMVV1WFpSTWVIWHNxYm01ak9q?=
 =?utf-8?B?WGc5VUJMUlM5THY2a3ZXb1NldUd3a3Z2NVlYWU9rOXRXTk52dkNWcDJWU25C?=
 =?utf-8?B?RWx4RDhzUVltL0RhN01ZT2lXWnMwR0RES1BmRjljSE9LUS81dXN2Tmxlb0lH?=
 =?utf-8?B?Ym9zazVmSElJNWppdG50YWVDam5yaTdlWEw4K3dGZ0VCTnhzb2w2Zi90UDQ5?=
 =?utf-8?B?ZmJ4bGRJNVB3ZFFESTlQSytTWHdBK0w0dzZFUnp3akt0N0lxZUdEODZ4b3JE?=
 =?utf-8?B?OEE3UU1vb3Q2MFNWZVZwRVl4R1VLOVBWSGNJM0dqcFFvak04U015cjdnQlB5?=
 =?utf-8?B?NnhaNVpUY2laeFovS1IwMlhMeE02bWZVQmtSaHc5MzhvaHJWTmdBMzZwVDgr?=
 =?utf-8?B?cjhNRXhJVXo3Ri90YzlUemZCaGsrOVo5cHlBUWhHd1pRR2ZMaHdvaVp4Z0c4?=
 =?utf-8?B?bkxrenREazFvQkRZQmlrMDNIeHZEc2tNNWRxTm5VY1pyVWVIa20yRDBKemR0?=
 =?utf-8?B?UHZTUEs0ei9tbmVSUDRNSG14cldmb0M4bnM5SFFwME5PQlBtVUJ6QlFhVkN0?=
 =?utf-8?B?enNpUVh0VzRjWUFNc0FpSmhGa2lRRXhOQ3lFSjBIR244bVZTS0dhOHZRbEFK?=
 =?utf-8?B?N29xZ1BPbUxLNiswOWp6ZzNXZWZYdDlOdlpxajFGTk1FcEhCT3MveGV6Y1hv?=
 =?utf-8?B?aVJJMVdpK2dQK0pGQ3IyUk9jc1F1R2NuUmlPMzErSlRzR2d4dWtKcnRQRDdE?=
 =?utf-8?B?NDQra0VFUSswcjZDRXNsM3gwajI3WkMweDErNHpwZEgxdGN1SkxqYStzVmRB?=
 =?utf-8?B?ZjhrK0NON1BXVWpTbFJCeHFBTXlucGQ2VSs0bmZVcU54c3Mwa2JSNWxwM0Nx?=
 =?utf-8?B?Q0xUb011djlRU3NTZUpqMkhidGpzMXVyMzZjYTd5ek1sWlpLZHdjQjhYV2ln?=
 =?utf-8?B?a21OT2pmOXoxT2xDU0RQTDBPMkJ3dzVnZTNJMUtKcmdNQlFwUHVSWGpDWDdD?=
 =?utf-8?B?ZGs3Mk8zcS9sajJySnhmeSsyM2tWWHAreEc2SHN0YU5EOTNlSDZ5Wk9icDZk?=
 =?utf-8?B?NTRlWnl4cnhiZE42NE5WZklROEpjM0dkTG5TS2srOXN4RUxNa0FRcTBFWjZn?=
 =?utf-8?B?VHIzZVJPRkZZUFRycm4xbGgyajVjMzlsTFdmVHMyeUNPTzBUaUI4V2x1UWxU?=
 =?utf-8?B?VE5TTHc1ZmZrRUNDTnJpSkxTcnA0Q2doSVM3ZnpMYkplWWlTSXQ5Tkh1WWJE?=
 =?utf-8?B?SThvbmRvWnV3Y2dSZmhoZ1JEVkszR0JjTUZqOUcyVU5lRVFwT1hnY2F4M3Ux?=
 =?utf-8?B?bHJVeXJPN1U3NWFrZWd2WnA1LzJxeHdGdDJTdllNV0NYL1JIK1IwdnUzYUxq?=
 =?utf-8?B?TkdlUHplaFFtNmFGNE5yc1B4bFpZZk1LdkFoQWxVUXZyUjJaK0UzaTlJR0xN?=
 =?utf-8?B?Z0ozZnR4MEFqRnlwS3JIdXBiZVZLcWtGb2t0VHVnZldDTnRsTE5QYWFZZ09H?=
 =?utf-8?B?K2NyWTN4ME5URWozM3cyTHRGeVFITTBjV2RaeDFuMXd2SUF1d0I1SzFwQ3Yy?=
 =?utf-8?B?YmlCV3FtOE1DU2Yyc0dKNExqb2ZPSUhEdGpHSjlWTFhPZ3dFN1YwQWY4YzJt?=
 =?utf-8?B?Wk5XSGEyMGk4L1M2amU2TVVjWlM2bFQycU5wTmdWak0vN1U5NnBWWmsySDZD?=
 =?utf-8?B?VUZqNm9temcrT25admg1Y2xyNGJIK2xyZXhSNi9JNmE4UlZpRHVZM2lSVUtJ?=
 =?utf-8?B?YUV5ZURkQ1V2QmlHRkQ2eDUxZVcydUtDVFlydE9CQ0EvRU1aNmVROFlhUFRl?=
 =?utf-8?B?dHpzVFpYY0lQUGt5bkx2MnZMNmNHNENtU3VieHVMekVZUVdkS3Y1c3BuYTJV?=
 =?utf-8?B?ZWFtY1EyZU5kQlBTTHdyeEIzZTRQemhLUHNxRVh5UjNWV2pMMmhFWjY4Yldi?=
 =?utf-8?B?bEk0N2sxK1pXV21LayttdGxpYmdVRkx5TDRQWnZrNkQyQUNwUURuQUdPZjNo?=
 =?utf-8?B?S0E9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: b4cfe6eb-6ad5-4d57-6ece-08dc80d85a48
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB5089.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 May 2024 18:43:09.6627
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: chDM1PqeUYwpnW54lJrWO8Yc1E56dn9MYJAKd1sa9qW4bsIo5UyGuamuOLuyXadOo4jJVGGAvbfMX0ItO2owFnswiXEqCSV/QhW+c+3tv8Y=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR11MB6249
X-OriginatorOrg: intel.com


On 5/29/2024 9:05 AM, Diogo Ivo wrote:
> Enable PTP support for AM65x SR1.0 devices by registering with the IEP
> infrastructure in order to expose a PTP clock to userspace.
> 
> Signed-off-by: Diogo Ivo <diogo.ivo@siemens.com>
> ---
>  drivers/net/ethernet/ti/icssg/icssg_prueth_sr1.c | 49 +++++++++++++++++++++++-
>  1 file changed, 48 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/ti/icssg/icssg_prueth_sr1.c b/drivers/net/ethernet/ti/icssg/icssg_prueth_sr1.c
> index 7b3304bbd7fc..01cad01965dc 100644
> --- a/drivers/net/ethernet/ti/icssg/icssg_prueth_sr1.c
> +++ b/drivers/net/ethernet/ti/icssg/icssg_prueth_sr1.c
> @@ -1011,16 +1011,42 @@ static int prueth_probe(struct platform_device *pdev)
>  	dev_dbg(dev, "sram: pa %llx va %p size %zx\n", prueth->msmcram.pa,
>  		prueth->msmcram.va, prueth->msmcram.size);
>  
> +	prueth->iep0 = icss_iep_get_idx(np, 0);
> +	if (IS_ERR(prueth->iep0)) {
> +		ret = dev_err_probe(dev, PTR_ERR(prueth->iep0), "iep0 get failed\n");
> +		goto free_pool;
> +	}
> +
> +	prueth->iep1 = icss_iep_get_idx(np, 1);
> +	if (IS_ERR(prueth->iep1)) {
> +		ret = dev_err_probe(dev, PTR_ERR(prueth->iep1), "iep1 get failed\n");
> +		goto put_iep0;
> +	}
> +
> +	ret = icss_iep_init(prueth->iep0, NULL, NULL, 0);
> +	if (ret) {
> +		dev_err_probe(dev, ret, "failed to init iep0\n");
> +		goto put_iep;
> +	}
> +
> +	ret = icss_iep_init(prueth->iep1, NULL, NULL, 0);
> +	if (ret) {
> +		dev_err_probe(dev, ret, "failed to init iep1\n");
> +		goto exit_iep0;
> +	}
> +

Once initialized, the icss_iep driver logic must implement the actual
PTP clock interfaces?

Neat.

Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>