Received: by 2002:ab2:7853:0:b0:1fa:5c73:8e2d with SMTP id m19csp58251lqp; Thu, 30 May 2024 11:55:26 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXClwGoaQDAXxCySa7IgwuTKTEPDzzd8pSorYSmcVLzwjAeIKatNMR8wr/NeBz5ENseVmOhhYoLan5JNbVYQzxV3rnGWctdYoJc7onWQw== X-Google-Smtp-Source: AGHT+IHw/idfX1MVHgrJMOacA5LttKK0XAzIhPnEfqoDjd1MpsWtpyocfPWZvlWezsNlSwpYuVua X-Received: by 2002:ac8:7d81:0:b0:43d:fa37:609e with SMTP id d75a77b69052e-43fe92cd072mr36722981cf.39.1717095325929; Thu, 30 May 2024 11:55:25 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1717095325; cv=pass; d=google.com; s=arc-20160816; b=I10pKTpRmJxcI97v1OF1lixQKlRTwuz++1FSwbxhP5arMlZZt1rcy4zfyh6OEzOKGu VLkewhwAzAmU2BypdIocrIOUWoG9vcxROKGX0dfwzazzH63eZDTV5UC8RLvxpIu4PxLl /P55N19O9/ytLshoUr5uQVgetal5l6nLwuU4QHw+MjuH3j/zlGffC8OCEJm5e4clZ17P EGX93qlonVDtz2FHO1bRdngXewWkVvuPzpG9QDyiOyAfNsn7/WR1Pg5ebi1K51lyzhxq zxqweqrZRVTH59BRXZ75SbAw9BOrbSUp/PfaYCmO1m2cjE4sFe6UX87FCqVvlsNW9+B6 DwIA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=qCwDNVvoLckV2y4/aZXJohvjkiQuKxt5yo00ZDtV4lI=; fh=o6gYzVEmFagyMhfDoRUk3qHYvl4FYIXzFVzkZqbdWEE=; b=PDtNprIwim5QaFfzCkAJgYWxQd6kUG0xJTiuGatM2Gz5H41Z8Q21YGUPGfxPcAjN6h jX4Ij1OEt0/krx56sQQqqudYINl94bbEkV8XOPFIrWLZjxY+QmuJuG0cPJWjqAD+2O4O RGhabVP0fmQ3H8ksDFErBKYwNDS/wcmKFgvINWeYLpLTfmdrGtK9d7tdZdc5Oo5zGnRT akrQ2QZZi23kB7AOtE8KzHN+CsZ3KkJq9BvLSwKyE6Ve6sZ6uBmDhGdQA24394Lcwz5o PEYLrENIv+PBFC5LFmM9vAh7YWQzVb04gTzyI8I98SQn2cVvig3kSdjmjvk8mTXa0Y6l d2Ow==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=iw1pGLR2; arc=pass (i=1 dkim=pass dkdomain=linux-foundation.org); spf=pass (google.com: domain of linux-kernel+bounces-195803-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-195803-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id d75a77b69052e-43ff23ac6d6si2297281cf.60.2024.05.30.11.55.25 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 May 2024 11:55:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-195803-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=iw1pGLR2; arc=pass (i=1 dkim=pass dkdomain=linux-foundation.org); spf=pass (google.com: domain of linux-kernel+bounces-195803-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-195803-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id A64FE1C23061 for ; Thu, 30 May 2024 18:55:25 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 64C36537EE; Thu, 30 May 2024 18:55:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="iw1pGLR2" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 58B1752F92; Thu, 30 May 2024 18:55:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717095319; cv=none; b=MFu5IY2oUao+z5YIgnZUbW0Eo1rHfjoaG74Mu7hxH0dmCIUf6+safNkpBMOz4w38cBYMPVFIR/GtgTAI9sCfZW3Rkt+FNHFVIuUNSXXKhsi3wQUN5YzWCBdVaJcPEWZDz0/NA+EWQWbezjc16oH4lh+sNQ8xY+QlxghHlIKx2WI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717095319; c=relaxed/simple; bh=4hWBQo8mKhTDOaJg0ytrw+HQ2Vee7IeEmNaUpqVR9Rw=; h=Date:From:To:Cc:Subject:Message-Id:In-Reply-To:References: Mime-Version:Content-Type; b=BYE2m0lyj6iKMgI5c6Brz5+qOu8O9wUdgEJCpUci6iw692X/jMBl+ypEDRbXZTu83oxU9DhUYc+Tp8nzo+azS9fp7Ec/zmd2FKuRD59QeDSlU6uA1MCJaA7PelMOq18dGdgnEe7AXU4rsjWsx3oxiHLGfQL4cVb3eHi2xU3vUGA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b=iw1pGLR2; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id C7642C32781; Thu, 30 May 2024 18:55:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1717095319; bh=4hWBQo8mKhTDOaJg0ytrw+HQ2Vee7IeEmNaUpqVR9Rw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=iw1pGLR2r+v8CUGMhN5abhUVsfMLtQajfepQTw58H/C9SEHWTdsQJVctscnEg4Fk2 UMUHY7LTTHkyxx+aSBivctH9wxOl3HmMhOYzWmgqAPXp1AKtF81keyxJRcvRMe1mQj IfyrrC1diBcUuv0nb0GJjvggBECt8mTxNLJJOTh0= Date: Thu, 30 May 2024 11:55:18 -0700 From: Andrew Morton To: Tejun Heo Cc: Kemeng Shi , willy@infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 0/8] Add helper functions to remove repeated code and improve readability of cgroup writeback Message-Id: <20240530115518.a4be2d0afa4139e346407583@linux-foundation.org> In-Reply-To: References: <20240514125254.142203-1-shikemeng@huaweicloud.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Thu, 30 May 2024 08:35:05 -1000 Tejun Heo wrote: > Hello, > > Sorry about the long delay. The first seven patches look fine to me and > improve code readability quite a bit. Andrew, would you mind applying the > first seven? > Thanks. All 8 are in the mm-unstable branch of mm.git. I've added a note to the eighth, to wait and see how that unfolds.