Received-SPF: pass (google.com: domain of linux-kernel+bounces-195815-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <f0a1ca78-f94e-4f02-a5e0-ef9d610fac07@nvidia.com>
Date: Thu, 30 May 2024 12:16:03 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 2/3] selftests/futex: don't pass a const char* to
 asprintf(3)
To: Shuah Khan <skhan@linuxfoundation.org>, Shuah Khan <shuah@kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
 Peter Zijlstra <peterz@infradead.org>, Darren Hart <dvhart@infradead.org>,
 Davidlohr Bueso <dave@stgolabs.net>, Edward Liaw <edliaw@google.com>,
 =?UTF-8?Q?Andr=C3=A9_Almeida?= <andrealmeid@igalia.com>,
 "Nysal Jan K . A" <nysal@linux.ibm.com>, Mark Brown <broonie@kernel.org>,
 Valentin Obst <kernel@valentinobst.de>, linux-kselftest@vger.kernel.org,
 LKML <linux-kernel@vger.kernel.org>, llvm@lists.linux.dev
References: <20240529022938.129624-1-jhubbard@nvidia.com>
 <20240529022938.129624-3-jhubbard@nvidia.com>
 <94fe2649-8def-4f2a-ba5f-19ae8a4226bf@linuxfoundation.org>
Content-Language: en-US
From: John Hubbard <jhubbard@nvidia.com>
In-Reply-To: <94fe2649-8def-4f2a-ba5f-19ae8a4226bf@linuxfoundation.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?cW4wQmtSUWNJNVpwYThpRzhnRlozdDloSWhNNmJRdjE5azRwcm0zM3ZUeUND?=
 =?utf-8?B?R2c4QlJaYUtzaHVLUWd1V09tYUgxUVdmWEp6dUxNNTFyTFArWjVFbFdxWWlE?=
 =?utf-8?B?UzloN2lFRUtBcVZkVVFqV0QrcFh3MkRvNjFsWGlZUllqc1NBdSs4QlZuTXZL?=
 =?utf-8?B?dDhNMGVLYXZ6cm1WWDl4QzRhT1FxSWxOS1lyanpuVi9ZZDMxVWpyRFA5amxY?=
 =?utf-8?B?emJ0K2hYOTFuQkFmeEVvZ1k1N0dMOE4vblRDb25MQldncGdNOXRobkdVYmNO?=
 =?utf-8?B?NHNwQTl5Z1JpcENRMzlIYUV6Y2ZQMlZmejBydXU5SUFOeGRNZDR5UVpCNVpz?=
 =?utf-8?B?OE9LdVBWU0FER3Y0eStwU29KKzlEdDVTdldBaFk3ZWc0SVErSEZIcTNpTU5W?=
 =?utf-8?B?NkhUQVo3NEFBajJXL0YySXpDbFErMTVEdkxYSk1EWFI0Ym14WVBqdlA4aWZP?=
 =?utf-8?B?eTZCMlhRTEFLR1BNN3lDR3h6Z3RmeDVubzhCdkMrNXpqSVlTVElpcExraUs5?=
 =?utf-8?B?aXBYNENaRVZrL2pmcHlHbTZGaXNmM3F6aStiSnVucFJncFBmczhub2gyOFVs?=
 =?utf-8?B?S1daQmE2K1ZnWG90aVJCOVlobG50dzBFZzJLZXlRRVF5bEFxdTBSVGRCSWp1?=
 =?utf-8?B?U0cxRytJaEladjdCbEQ2dElQenZmVmNSSG4wRGVWa21CM0xOU0s1WElWT09a?=
 =?utf-8?B?K2IwWFgrQXNkdlpIQWZQMXEwSzV1aG1OQ2xnUkNhb3F3K28yenFSSkRuelpj?=
 =?utf-8?B?ZXdNbkJubHAzNjhNNmNRUkVYUzhxOHpJNW5mU3B5SXRsSlBYaHBuaWhLWkNo?=
 =?utf-8?B?bEt4eUhrSXp2K3kyVTN4cFJOejRGZXBtMzB4NjM2WjVuL0xNUFBMOGdWSGc3?=
 =?utf-8?B?VFBaSndFcXptRTd0L1cvcW5NTWwxQ3MvNjRlekkyT1BtVXBkbmI4NTR4OFJN?=
 =?utf-8?B?RE1zbUFDZlQ1d01pMitTeWo3amVtZDViVmJaZlZudis0YnVWNk1oRk16dHZn?=
 =?utf-8?B?RDcvZ1gxcmc1Z3p6Vi9pcWdzTjk0RW5ObGhtaUU3QTNEeEJLM2JrUXRjOWRm?=
 =?utf-8?B?QjFPc3orTnBoRC96NTFMSlFtbFVtZkVyRThaN284ZUx6NkVnK2UzZHVXRVJv?=
 =?utf-8?B?c2xPZUd0KzQ1bG1oSEZYakt0Z044amhBamg4bDVMazRXSjFUZXF2ZFF0alQr?=
 =?utf-8?B?QVlMY2M4aEl0djR2ZTR1SHBNWEI2TnUrUm9jeGVLSEdodDY2WHpDcFd3RVU3?=
 =?utf-8?B?Q3Q3Rlczdk9vY29oVWFGd0lFRENLMjlZU0FOUFhBT3ZjVE8xZVlsbjBxcnZ5?=
 =?utf-8?B?R2ZHWjZUNHZJUkhjZ3N6aTdoUlY5MUVKWEY2QlRZdlNZQUs0M0dwQitibVB2?=
 =?utf-8?B?WVlnTkd1K0JwTFhaUk53Z2dqZDhwUFRvYmxodGhtbitzSDJETWx4WGd4VUhK?=
 =?utf-8?B?L25ZTkVkNGIxTzBLWkw2bG1UQlFPNDF3d0RIL3l3RXcxblViNFd6RE5kZnZU?=
 =?utf-8?B?Q08wTVVDN21zWFB2cWxvenY0ZllLUU50RnJia05NdEZESjdORzFRcWsxK002?=
 =?utf-8?B?WWRNNmNvb2ROM3doTERIZWh4Z1BWek9yV1hWVXk3ZUYvazJjWUcrYnZqZHdZ?=
 =?utf-8?B?UUhBeTNXek9GdmhSRHd6WktiUEJrbHRLWlpkS0NPaUswdVZTTTlIa0hMQXl3?=
 =?utf-8?B?ellGcE5yVU01SEdEcTdqTVM2OEY3VXB1Zy9iM053Zy91TUVXaTdzNVlkbUVQ?=
 =?utf-8?B?K2RHbFJmbU5FUVRRVEx5K0NuVHNtd2w5VURwaENrUDkvZ1RGYjNsNXZvTUIv?=
 =?utf-8?B?WkVwY1RvS2pyVUpxdEZuTG9uYzZsZ1VCZDdKM1J4dGZGT1h1Y1lERXpHT0I0?=
 =?utf-8?B?MzdWRlgrQjh5b1k5a3hGT0dHek9JVUZOd0I4TWJHWGFmOGw1QXUvcitycmFs?=
 =?utf-8?B?Wmp4UGFITkRKajFoNzFmSzNycWhMRTZCeXRza0JESHcvZURJbGVGR0w5ZWNw?=
 =?utf-8?B?R1hPTkd0MEN3N05jbjBvY1IxZGJmcjE4VU8rU1I3a0hmOElTY09KNGd1a29H?=
 =?utf-8?B?ZDhhVGVOT01qTmxvWFR2c1ZwN1pPbE9CaFFZY1NvVHhSY3pObm93MmUzMkZH?=
 =?utf-8?B?VVorQ1NlN3hIMkFjZWh5WlBEWjI3blBzd0ZkSjRnKzFvdk16b1diOTVqU3I4?=
 =?utf-8?B?d3c9PQ==?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b4c43990-c8b0-4265-1d2c-08dc80dd0167
X-MS-Exchange-CrossTenant-AuthSource: BY5PR12MB4130.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 May 2024 19:16:28.0202
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Eoma1Ap1ujYpYjUCA7GR49zyZs6fNakvrjTdpRytX94Cys3DSkURgfp9o6iFQ7he65MYtfAus8IZaJ23LfqTIQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB6955

On 5/30/24 12:04 PM, Shuah Khan wrote:
> On 5/28/24 20:29, John Hubbard wrote:
>> When building with clang, via:
>>
>>      make LLVM=1 -C tools/testing/selftests
>>
>> ...clang issues a warning, because test_name is passed into asprintf(3),
>> which then changes it.
> 
> Please include the warning in the commit log.

Ah, OK, the warning is:

futex_requeue_pi.c:403:17: warning: passing 'const char **' to parameter
of type 'char **' discards qualifiers in nested pointer types
[-Wincompatible-pointer-types-discards-qualifiers]


Please let me know if you'd prefer a v3, or if you'd rather fix it
up, whatever seems easiest for you.


thanks,
-- 
John Hubbard
NVIDIA