Received-SPF: pass (google.com: domain of linux-kernel+bounces-195827-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <e0f3563b-5cd7-4f3c-ae7c-4478c25d527c@nvidia.com>
Date: Thu, 30 May 2024 12:28:14 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 2/2] selftests/lib.mk: silence some clang warnings that
 gcc already ignores
To: Shuah Khan <skhan@linuxfoundation.org>, Shuah Khan <shuah@kernel.org>
Cc: Beau Belgrave <beaub@linux.microsoft.com>,
 Steven Rostedt <rostedt@goodmis.org>, Mark Brown <broonie@kernel.org>,
 Naresh Kamboju <naresh.kamboju@linaro.org>,
 Nick Desaulniers <ndesaulniers@google.com>,
 Justin Stitt <justinstitt@google.com>, Bill Wendling <morbo@google.com>,
 sunliming <sunliming@kylinos.cn>, Masami Hiramatsu <mhiramat@kernel.org>,
 Valentin Obst <kernel@valentinobst.de>, linux-kselftest@vger.kernel.org,
 LKML <linux-kernel@vger.kernel.org>, llvm@lists.linux.dev,
 Nathan Chancellor <nathan@kernel.org>
References: <20240529020842.127275-1-jhubbard@nvidia.com>
 <20240529020842.127275-3-jhubbard@nvidia.com>
 <88c64f5e-4586-4b38-b3c8-0c3af93a71ae@linuxfoundation.org>
Content-Language: en-US
From: John Hubbard <jhubbard@nvidia.com>
In-Reply-To: <88c64f5e-4586-4b38-b3c8-0c3af93a71ae@linuxfoundation.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?UTBVUW1UV0xkM0hxQUIvcnY4SFBpb2lBNWdPM3JRRkxCa3lKSkJWSE10d0gr?=
 =?utf-8?B?RFluZldEaTRnTisydFY2YkZ1QWFCckswNkdaVmJ6bENIczdRa25PdytqTkpC?=
 =?utf-8?B?d2hOM2JDbmgzVUxjYnF0TSs1Ui9RMU5kSkRuc1hCU1dmTmVpSDE3UWh2QVIz?=
 =?utf-8?B?eVVqbVRIam15S212WXg4Vmp0WkVwbGU3Z25GYkpCZUJrTHZtQkQrOWh0YkM4?=
 =?utf-8?B?K2NjWUlubXNGMFUwdWs2dUMvclhGcU1JamJLNEd0aTF2dUJJSHU3Q1R1MUJ2?=
 =?utf-8?B?S1JGUVI5Q0RpUVVKL3YzVkYwTGNrM0laMFNlbEJxeU95T05hUkdISzFub0JC?=
 =?utf-8?B?WkMxdzRVd3FoQ2puZmVIZm5oVzlYN29uYzloMmZnamhNYWNRRjlkSEtKYU1H?=
 =?utf-8?B?aUtNZDRQcndLeEtvbUJyVFkvSFl0YVBaZ25yMEhiMUJoRGZydnVOdWEvMTlz?=
 =?utf-8?B?L1cwTGFSYVBKa0JDeVhuTUl5RFYreTA2aTJlc0NEUmJ0eHc2aGlYOEtsUnFN?=
 =?utf-8?B?aC9JaEFRZ2s5MWREZ3JmUlJCMkptdEF0bVJKSHEzZFFwRHhXcTdHOHlubGRh?=
 =?utf-8?B?dGxzOEZJNUYzNDlVQ3dtMGU4VC9GQzJhZVVhd1VsUjVSK3VEMGlUUUo1TVdK?=
 =?utf-8?B?LzVYd0V6SmNlMWRKdG9GOHpQK2FybXIrK2Z1Z3BDaFRWdlgzS1BScWdpYUh1?=
 =?utf-8?B?N3orZU5SRkNPaTVQZEdndVJTZHE2NUtwNkNYb3MzYjhwdFhxNi8ycFUvaWRm?=
 =?utf-8?B?bUF0WDgwTVZ3UmpGT1R2bnhidlo2Y3JqNkR5ME5BWmIyL0NndEd0N28ya1Rj?=
 =?utf-8?B?NDl5Rm5OVnhZV012Tm5PV3pXZ2h2bFVQb1F6Z1g0Tk55c3AzMWNMNUROWGhm?=
 =?utf-8?B?MHo5NHFNWWc3NnZwekFacmJqTGhNN3RDRmZsYW1MZCsvVXhDVGd0YUk4bk5w?=
 =?utf-8?B?eU1PcTRrbVZnSm5CVDhnMUFJblJJcXpvYmJ1ckhDSjlLZmkzWU1kbmc4VG9F?=
 =?utf-8?B?VzVISlRXanVlUzhDaktySTFMWUJ3ZWxtRURaYkxQeGh6OFlIRnVCT2N5ZWhF?=
 =?utf-8?B?blRaenJLa1h4S0dtTGlYVngrNFUxOUFzcXBVZkVKVWxsa3VtZ2tVN1JsTWt2?=
 =?utf-8?B?TGRTSmk2TUc0QndJYk01T3V4QUtGbHM2VHIweG92YVp0R2ZKeVJhVFFsY3E2?=
 =?utf-8?B?bGhqQ2hFNjFSZlR4a21pVG4yZVNLekUzWi9rRm9mR1VITm1jdUJQNFJSc1Vt?=
 =?utf-8?B?ZUxLR0Y3Y043c0VBVGliR3lUeFowU09sZG44RDBCTzhQeUI3Qk52Wk9Rczhu?=
 =?utf-8?B?UEpiMTJOWFAyMHpUeEl5WTlIdVMrb3d1UjhHd2VIWExMbitETEhnUmtQQ1Br?=
 =?utf-8?B?UjkvWjlHMXdIQUliekJXVHFYamxZVlEvU2lWckNIQ3JnT1ovdDhNejllOUE1?=
 =?utf-8?B?TENpOFl5ODlpZkdPRlViVnYrSlRHNCthUDBhTmdoSlpmN1BwWGgxdmlSOU5u?=
 =?utf-8?B?Q2hvVFloK0FrTEd3NSt6TUJYb3VISVBNSEJhQ2lCcEwweVY1TlZEWVRlamtw?=
 =?utf-8?B?NFpwUkFITnNDeUlQZ2dzQzNQR2VPckQxSUl5REhMTWU0aGhFTHBXSWRKY3B3?=
 =?utf-8?B?eTFTWFNwa1ZScFpLSVlmbzI1TDJEMHJ0UzJUUlByRHFiV0FiTXRSaVkybjlX?=
 =?utf-8?B?andiYkFoU0YwWmlsV0JWb21RelZ5RllHbS91V3d6dkt3Y1ZXTjN0eEVKZG1J?=
 =?utf-8?B?MitLQnRMZHhzbzMva2dFckpiZHFSOVFxWGxDbUtUN1UzOS8zdklYUEtjWW1H?=
 =?utf-8?B?K0FueVlHTkdFRG9KaXovYk5sS3RjdFJ1dDNSLy9TS3hYNGZKaWR4dURFQzRX?=
 =?utf-8?B?c2ptbjNjUkF1b0tUYjJ2SC9NVTNMVUVUMDJ5ZTdjZ2o4TEd5ME5lTm84N0ov?=
 =?utf-8?B?QXZTWXVKWlIzSkN3Y3pHMVdHaUJ2NXdBVnIwcDUwMkVNZEQ3K0pyeXNpbHJ6?=
 =?utf-8?B?dUx3dmVCKzRSSC93OTNXY3NIRFFXSDkyM1RHdi8zOEZ5M3dhRWVyRk5JeXhp?=
 =?utf-8?B?VU16TXVxV0VBL0RwcEdUZ1FzNDZXNVNNSExjZzIwN09rcUlxeDNtKzlKTzJq?=
 =?utf-8?B?MVhpV0ViYzNZdkdLM056aGZKdHZIdDE1OW9LNGl0UGhhNUZqZVQwY1hsTlpS?=
 =?utf-8?B?WXc9PQ==?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7303b896-3dc6-49f2-5642-08dc80deb59a
X-MS-Exchange-CrossTenant-AuthSource: BY5PR12MB4130.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 May 2024 19:28:39.8402
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Tu73YmL+Zki3WQ+o4Xar4Ajyk1AiFj+p+YprjLe+5gY0O8SHGQjTtufcz89YaYMQPQ6sjjH2eYdxyhaKrbD0Mw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR12MB7025

On 5/30/24 7:25 AM, Shuah Khan wrote:
> On 5/28/24 20:08, John Hubbard wrote:
>> gcc defaults to silence (off) for the following warnings, but clang
>> defaults to the opposite. These warnings are not useful for kselftests,
>> so silence them for the clang builds as well:
> 
> Please you add more information on why they aren't useful
> for kselftests.

Ah OK. My wording is a little misleading. The warnings are not useful
for the *kernel*, as previous decided by the gcc settings when building
the kernel. And it is only only due to including kernel data structures
in the selftests, that we get the warnings on clang.

So it is not something unique to the selftests. There is nothing that
the selftests' code does that triggers these warnings, other than the
act of including the kernel's data structures.

I can post a v2 to update both the comment and the commit description.


thanks,
-- 
John Hubbard
NVIDIA

> 
>>
>>      -Wno-address-of-packed-member
>>      -Wno-gnu-variable-sized-type-not-at-end
>>
>> This eliminates warnings for the net/ and user_events/ kselftest
>> subsystems, in these files:
>>
>>      ./net/af_unix/scm_rights.c
>>      ./net/timestamping.c
>>      ./net/ipsec.c
>>      ./user_events/perf_test.c
>>
>> Cc: Nathan Chancellor <nathan@kernel.org>
>> Signed-off-by: John Hubbard <jhubbard@nvidia.com>
>> ---
>>   tools/testing/selftests/lib.mk | 6 ++++++
>>   1 file changed, 6 insertions(+)
>>
>> diff --git a/tools/testing/selftests/lib.mk 
>> b/tools/testing/selftests/lib.mk
>> index 2902787b89b2..41e879f3f8a2 100644
>> --- a/tools/testing/selftests/lib.mk
>> +++ b/tools/testing/selftests/lib.mk
>> @@ -50,6 +50,12 @@ else
>>   CLANG_FLAGS     += --target=$(notdir $(CROSS_COMPILE:%-=%))
>>   endif # CROSS_COMPILE
>> +# gcc defaults to silence (off) for the following warnings, but clang 
>> defaults
>> +# to the opposite. These warnings are not useful for kselftests, so 
>> silence them
>> +# for the clang builds as well.
>> +CFLAGS += -Wno-address-of-packed-member
>> +CFLAGS += -Wno-gnu-variable-sized-type-not-at-end
>> +
>>   CC := $(CLANG) $(CLANG_FLAGS) -fintegrated-as
>>   else
>>   CC := $(CROSS_COMPILE)gcc
> 
> thanks,
> -- Shuah
>