Received-SPF: pass (google.com: domain of linux-kernel+bounces-195847-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <44428518-4d21-4de7-8587-04eceefb330d@nvidia.com>
Date: Thu, 30 May 2024 13:00:55 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 0/6] selftests/x86: fix build errors and warnings found
 via clang
To: Dave Hansen <dave.hansen@intel.com>, Shuah Khan <shuah@kernel.org>
Cc: angquan yu <angquan21@gmail.com>,
 "Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
 Ingo Molnar <mingo@kernel.org>, Binbin Wu <binbin.wu@linux.intel.com>,
 Alexey Dobriyan <adobriyan@gmail.com>,
 Rick Edgecombe <rick.p.edgecombe@intel.com>,
 Sohil Mehta <sohil.mehta@intel.com>, Yu-cheng Yu <yu-cheng.yu@intel.com>,
 Dave Hansen <dave.hansen@linux.intel.com>,
 Valentin Obst <kernel@valentinobst.de>, linux-kselftest@vger.kernel.org,
 LKML <linux-kernel@vger.kernel.org>, llvm@lists.linux.dev, x86@kernel.org,
 Muhammad Usama Anjum <usama.anjum@collabora.com>
References: <20240527210042.220315-1-jhubbard@nvidia.com>
 <4d2c93e8-5ab0-4b28-af24-c00d57f359fe@intel.com>
Content-Language: en-US
From: John Hubbard <jhubbard@nvidia.com>
In-Reply-To: <4d2c93e8-5ab0-4b28-af24-c00d57f359fe@intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?UkhaTFUyMVhyWGhLNTc1bmk3WHJPL2svNHRUUy9OelVzSDZySThOUEF4SHhx?=
 =?utf-8?B?dnYrQTRhbjNkZUpZRlRDZ2lpcGdVOVBxTnhiTVBjYW1CUzJtbXF6OXFzajVH?=
 =?utf-8?B?em51b05nL3lvK1Y3cWZKUk1YUWtYcmFxZk95QVJWTHp4NEZray9qb3lwRXlo?=
 =?utf-8?B?dUpFcUZnelJRL2JoU1JEdEMwMWRobEswYnFXZy9Xd2o1RTZqbDh5VDZNOWtR?=
 =?utf-8?B?NVpzQVlkZUJBT2Q3b2ZVaENuSmhHdld2WCt2aTljWWtDWURjNjdHMVNqNEtI?=
 =?utf-8?B?NDRHUjBmeTdrNW90U1dJV2tKM2RQSG5sSVNBVGdmSjI5V2NkOHUxWG5Sc0l4?=
 =?utf-8?B?NUVhRFozd1hOZit4VVNNRVpPRDZCL0Fna0NVSENrTEpNby8zVXE1a25vMGlL?=
 =?utf-8?B?OVJIaGlMcytmV3ZEVUpXMnF2bzArMzV4NHlZQTRqd0MvZGo3NlNZSzNKNnFJ?=
 =?utf-8?B?MDZzOWlNWVZoMTZubGNhZktMelRGVDhJa0E4YVRMWmgva21xYzVwcmd1aDJX?=
 =?utf-8?B?eVhsSERTZi85VEE4RWFMSmp0QUtIS2gvaEZxajU0S3JyMk9sTHRRejZ6aXVK?=
 =?utf-8?B?QlNpRTVnY1RIZ2lZWG95ZjRvQmNLT256UG03cWI3blhMbGpXUTFMRllBSkxN?=
 =?utf-8?B?a3hvajlwS1pUUWpCcEc5dEJ2TzEySVR5V0RkNkZHMFNTNEpRNXRVbG1RRnMy?=
 =?utf-8?B?TzJib0Zic3FBR05MdVNUYnpjNmVVaUZIa3cyaUE5aFVMNmhvQ0kwd3F5ZGVm?=
 =?utf-8?B?bHJpb21DUkpveEJiOWlIN25IV2s0SWUyMUZtb0JLOHFRanJXSFBkZjl6eURt?=
 =?utf-8?B?bXJGNDlXQm1JcVlmeWh6ZUFLMVRaY2tCVWh0Mmh3cml0Um82dzZyeUFGZUhr?=
 =?utf-8?B?TndYUE8wb1RGNFFFTUNNc09OcHU1ajdGQ3U3U0lNaWhyQjRZOTdGVE1GVzF4?=
 =?utf-8?B?bzFoUno3TXpwelB5Znoya3hNaHp6YTlGSjRzVEYrdmVQWXVNdFNWWGg4aDBD?=
 =?utf-8?B?TjZZWE5SemZjMmM1TGw4SWt5REpCaXNrQkhJM2ZEZmhscEFscTdNOStRNG1E?=
 =?utf-8?B?elNlcWJ0SFdYZU9Ucmh3ZUw0OXZqTStWVUUxRTZ0UHYxNjVZWHRZTE85cDlK?=
 =?utf-8?B?SEpKZ3RDdzNTajYzWEdlYVIrZDZ0cU9LY2hTTThGNlpyamxZS0dqd3F4VDIw?=
 =?utf-8?B?cXVmbEVIZXh1U1BnYldqQVk0Q1Y5ckFuU3djdGk0ZFBEUUVRYTFMZllOcmpF?=
 =?utf-8?B?RVZyR3F0YTMyVWw2ZVQ0eWgzbkZ4N0NKNVVHRkhlSWh4WldWOWplQzdZMlZ0?=
 =?utf-8?B?TTlUUXB3Ly9XUVMxZHJKWFdsQXpJWFNMWGo2Sk1sZTRiK1FyV0tIZEVoQWly?=
 =?utf-8?B?ckhUUUwzMWwwU01TMG1ab3labzV0TlRXeHdxbTdza1dIakFZV240VkxleXFK?=
 =?utf-8?B?empuU3dZeElPaXNTRDZOVEwrZmZTbENJNU8yajFOdTlqWXNBRDl2VGxFdUly?=
 =?utf-8?B?N3g4OXkrUlRPdGc0K25MQ0dIa0k5YTFCTU5iaXpkRlhPTGlHcU5BdFpDcmM0?=
 =?utf-8?B?VWJ6MFQ4OTZSMUZ1R2tncnR5Rm5MYVJBa2Y5RDF3Qk9NVzhUWFVINUJoeE1o?=
 =?utf-8?B?d01NQlIvNmYzMjZRaHc4UVd3dnhROFdrdzkvWEFzdFk1aDNhbmtjTHM4ZE1X?=
 =?utf-8?B?NlYwVGovdjVUSzRrZW5nb2I0THpCRnphWnJVOWhGamRyZ214RzJtN3NFWDF6?=
 =?utf-8?B?Nms1N3hQYm9MdzU1dG53Vk9vcmhXSHlTVWVCWExHMmNBME5qNlFiTzZ6MVZN?=
 =?utf-8?B?ay80M1RObzVDYk5uUlpLeG9obHR2VTdKalUwcDlvRjFKQlAvMVBxRzlJY1dX?=
 =?utf-8?B?aEFDeUFyRGE3TmFuL2JlU2VMRjkzWEZpRjNBeUtua21PcFBSQnJaUjUrelFM?=
 =?utf-8?B?aWwyenlHNWp1TWNOZ0IxVkxoM1BYWmxRRHFpZ1FmV2pzTFBBRCsxS0plYWJW?=
 =?utf-8?B?V3NlUFNQOEhIZzFNcjBQS2xuSkRLOElzWEVodzdoV1NoMnMzSW4vOWdyZXlJ?=
 =?utf-8?B?eHpHVXhQV2U5UVpWZmljMDBuNUkxYVptU2tCd0lONzB6YmlHOUZTaXByK2p6?=
 =?utf-8?B?WlpsaUYwcEN5V1lhS0dkS2NubE9nRjNLU25rdVlXMDdTcmNld2NoU0VWOWlW?=
 =?utf-8?B?YVE9PQ==?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b7ea9a66-b5c1-468c-58f3-08dc80e345e7
X-MS-Exchange-CrossTenant-AuthSource: BY5PR12MB4130.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 May 2024 20:01:19.9413
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: J0o1fPCgL9AfL7UHel96oj342jmccKv+1cuDcaNi5EMXlV30tPceIY+koHBdukCx7RoNmGt4RGhRiegYLkpAkA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR12MB6620

On 5/30/24 12:46 PM, Dave Hansen wrote:
> On 5/27/24 14:00, John Hubbard wrote:
>> John Hubbard (6):
>>    selftests/x86: build test_FISTTP.c with clang
>>    selftests/x86: build fsgsbase_restore.c with clang
>>    selftests/x86: build sysret_rip.c with clang
>>    selftests/x86: avoid -no-pie warnings from clang during compilation
>>    selftests/x86: remove (or use) unused variables and functions
>>    selftests/x86: fix printk warnings reported by clang
> 
> John, could you and Muhammad have a chat and perhaps settle on a series
> series that gets acks from both of you?
> 
>> https://lore.kernel.org/all/20240501122918.3831734-1-usama.anjum@collabora.com/
> 
> I had Muhammad's in my queue and didn't realize we had two overlapping
> series' bouncing around until now.

Aha OK. Muhummad, after looking through this, I see that our
test_FISTTP.c fix is identical, and that's about it. My series goes
a bit deeper IMHO and completely fixes all the errors; the tradeoff
is that it is more intrusive. Which I think is appropriate.

Would you be OK with my posting v3 that uses your patch for
test_FISTTP.c [1], and the rest of my patches for the rest?


[1] 
https://lore.kernel.org/all/20240501122918.3831734-7-usama.anjum@collabora.com/

thanks,
-- 
John Hubbard
NVIDIA