Received-SPF: pass (google.com: domain of linux-kernel+bounces-195882-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <ccc29a33-d2c5-4aba-a530-240d17ae94e4@intel.com>
Date: Thu, 30 May 2024 13:24:18 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v19 15/20] x86/resctrl: Pass two extra arguments to
 resctrl_arch_rmid_read()
To: Tony Luck <tony.luck@intel.com>, Fenghua Yu <fenghua.yu@intel.com>, Maciej
 Wieczor-Retman <maciej.wieczor-retman@intel.com>, Peter Newman
	<peternewman@google.com>, James Morse <james.morse@arm.com>, Babu Moger
	<babu.moger@amd.com>, Drew Fustini <dfustini@baylibre.com>, Dave Martin
	<Dave.Martin@arm.com>
CC: <x86@kernel.org>, <linux-kernel@vger.kernel.org>,
	<patches@lists.linux.dev>
References: <20240528222006.58283-1-tony.luck@intel.com>
 <20240528222006.58283-16-tony.luck@intel.com>
From: Reinette Chatre <reinette.chatre@intel.com>
Content-Language: en-US
In-Reply-To: <20240528222006.58283-16-tony.luck@intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?THMwNG0zcEJMUnQxUUJlTldWS3h2ZVQvT1lXaDhVMmdKRGRNZlNsaS9sbWlW?=
 =?utf-8?B?cjZJRktRaWZJVnRDNXNWMVE2dWphU2ZrenJRQzlHUWZ2ZExqNGVwekpSSmxw?=
 =?utf-8?B?VWFlVWpmY2xWQnFxWkk4OGJvUFpNWEhPS1cyUzhtaW5nL3VlT2NnSHBESVk5?=
 =?utf-8?B?SG4yV3RweFBhcGJoRWw4ZFZZT1hPSnl6b1pPc3dPYldrTzRWUSsrOG94bzFE?=
 =?utf-8?B?YUp5SnUxa2IzUXNJcVRmUStSZFZNamltek5IVzJRQWNBMjRjRHVGTEFhOHRX?=
 =?utf-8?B?M09nY2twNFVGOTdXdWZZZFpFcGxtTTBMdS9abCtnV0tWWkcyZmJDZDgrQnM4?=
 =?utf-8?B?M0NNamhVS1BhcTdLQlpmTkJsOW16eWE0TmtUVCtOQ2xpTjdxMHFuSmg0VFI3?=
 =?utf-8?B?ZkhTa3BUSkkvb2R1ckVxQnN4RmxTbVJpNG1QUnB5WFlROTJwTUZiVlFkU0lx?=
 =?utf-8?B?R3FtQ3BScTVaOFBnNStKVEpZekNWb1RHdEZKZWxkUTkxVlltT0d5SWRaOWs1?=
 =?utf-8?B?RjU3VkROSm1DbWZpZjBEa0JCN3ZVU1l6YitiOER2S3JZTFQwTWFQUGh0Kzho?=
 =?utf-8?B?ZC9wZFdXTWxtNHQxZjRBby9DUHRaL3BENmpadVhMMlFxT2tRc1FiakNVUytz?=
 =?utf-8?B?NVY4aVk3K0k2aks3dnQ3TUlUZy8rMkNMMzNJcUNob3B2KzdXazdJOTNlSEVa?=
 =?utf-8?B?ZHphZ0NKbE94UXVjMjNIWTRBSFplWVhJWnpRRzNzcHRMWTcxWFRLUU1DU21I?=
 =?utf-8?B?dnErNk9WK1NZUDRZRGV1aWNsZ3Q1RGhMUkxIdkF5clk2cXpESmZUM2RDZ3Vk?=
 =?utf-8?B?YldaTG5QQldoYjJ1aFpHRmRaWVZ1ZFlEVFFjYjlJVVVoRC9xOVZCb093WXhs?=
 =?utf-8?B?K0RtYXJPMnN6bUp2RWNyYjBMZzl4RkpUVUdOU09FTC9JSzRsMDBGbStnWmdt?=
 =?utf-8?B?ajQwTnkya3F0ZEVuL2xLSjBLZkprRGUvMTNIQStydmpWUWhxUHg0cFFDR1E4?=
 =?utf-8?B?ZXd1ZnV3dUVYVEZIN0Q3cEFUd1R1K09na1g3T2VpR3ZEYXJNQzRlWDJIRWUv?=
 =?utf-8?B?Y29DYjZCa3pDNFQrWUxIbEplT0hrQTBGVXpDcUlZdnVTQXNjVEFEb3Myandq?=
 =?utf-8?B?Vy9rY3FWazVTVm9VWlJSMEdkQ1doODg4TzNIcTNRVVdGMkxvTWFodXVmdW5v?=
 =?utf-8?B?ZHZqeHhmY1BSdHBLNG8vcmVQVzJZVzRNREdGMlJjVVpsNTBGeVhYMXZ2VEJw?=
 =?utf-8?B?ZysxRjErRnFKdFhnS2M5aWZ3RkdycFZDcWUwQ212alEwZVkzeEdMZmtNWks1?=
 =?utf-8?B?dXo5Ymo0VGFyZ2lHaG1iN3AxN2JjeEtiUjVIWTl1aUM1K2pnVnExZDF5bENy?=
 =?utf-8?B?K3ZWNXdCakxVbnZVQ1JBazJVbXk0NURCZjZRbXZrQUQyS2FHTTYvQkh2VG1W?=
 =?utf-8?B?MTdSMWc1KzBDbU9YclJYdGE1TjdhMW1pQ0pjbHVxZkJNZGFWeG95YVN3ejY0?=
 =?utf-8?B?VmdIbHA0RjRmSWdENnpnNFhYRHV0SVJRbXBvQzJsZTg3cE9iU3ZuTm5tMEYr?=
 =?utf-8?B?dGZ5b05LTFBWMlpIN0lBakNBSVFoYVNoeWdBUm0rT2JscXZqeS95ZHk3c2lF?=
 =?utf-8?B?YklrZWR2bWZFQlZ3Ynd1a3I5MUFYR3ZhUmZqazVtcDltcUN3MXdIRjZMTXNT?=
 =?utf-8?B?NU1EVmx4RjJVbEZ6ajM2YW1wZ2xVQzRqSGt3cE9WNlZkUmtUVmhUTmhuMEtn?=
 =?utf-8?B?UzA4Ym5zZEQ0TDJ5QmhxYXdPQndBQW9QNVRnMkgycDgzc054SVRlS0hXV0d2?=
 =?utf-8?B?Z0dzeTIzQ1hZTTNDdllzL2hVelpObVJCd1BUajg3SDNCZ3hZeVhCWSt2dkFo?=
 =?utf-8?B?ZnBodXZhU0NNV2doanhYWDUvQXFDTGhrM2dHL1hVU0k5emIxVU9DMUlrckFF?=
 =?utf-8?B?SnR1TTA0cVppZTEzNkFvTjRqaHluN2hoMUJyZDVlODhMRHpJZG05K1ZNekVJ?=
 =?utf-8?B?QlRac2RzS0V1NWUrU1h3NW03cHI5c3RsdzJIeDExQ3dkU3kxM0tSWmdVK3hR?=
 =?utf-8?B?MzI1MFY5UkQrOVN5bit6MlYwUnYybXpuOGRSdkpML2x0T2NiY3plK0xERlJT?=
 =?utf-8?B?TElJelVlMjdCUm1YNmxkSHB1UjNJa0FJdStCeThrWG4rSWhuN3FzU1RTZ3RO?=
 =?utf-8?B?WVE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 6f49f52e-6b43-4296-275a-08dc80e67cb0
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 May 2024 20:24:20.3839
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: glaZMX8Bx9v6+J3BWt3xL6Q8XyAd+y8fFMMtaWnQcMtYskh2INYVxg/0+cNHq/wjVNqN61eUXc1brnf7FY4+cexphbxVSOTprOWY2AqUrGE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB6772
X-OriginatorOrg: intel.com

Hi Tony,

On 5/28/24 3:20 PM, Tony Luck wrote:
> For backwards compatibility on Sub-NUMA Cluster (SNC) systems the legacy
> files in the mon_L3_XX directories must report the sum of data from each
> SNC node sharing that L3 cache instance.
> 
> To make this possible, pass the "sumdomains" and "ci" fields from
> rmid_read structure as extra arguments to resctrl_arch_rmid_read().
> 
> Note that the call from check_limbo() never operates on a "sum" basis,
> so pass sumdomains=false, ci=NULL.

Why is passing "sumdomains" necessary? Can it not be inferred from
domain being NULL?

Reinette