Received-SPF: pass (google.com: domain of linux-kernel+bounces-195889-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <b4bcd52c-ba0b-46b2-b302-fb412542328b@intel.com>
Date: Thu, 30 May 2024 13:30:26 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] ethernet: octeontx2: avoid linking objects into multiple
 modules
To: Arnd Bergmann <arnd@arndb.de>, Arnd Bergmann <arnd@kernel.org>, "Sunil
 Goutham" <sgoutham@marvell.com>, Geetha sowjanya <gakula@marvell.com>,
	Subbaraya Sundeep Bhatta <sbhatta@marvell.com>, hariprasad
	<hkelam@marvell.com>
CC: "David S . Miller" <davem@davemloft.net>, Eric Dumazet
	<edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, Paolo Abeni
	<pabeni@redhat.com>, Richard Cochran <richardcochran@gmail.com>, Suman Ghosh
	<sumang@marvell.com>, Simon Horman <horms@kernel.org>, Anthony L Nguyen
	<anthony.l.nguyen@intel.com>, Jiri Pirko <jiri@resnulli.us>, "Mateusz
 Polchlopek" <mateusz.polchlopek@intel.com>, Netdev <netdev@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
References: <20240528152527.2148092-1-arnd@kernel.org>
 <2f1603fa-d03c-412c-895c-bc4afa06834b@intel.com>
 <866cb878-47fa-4bb9-ba93-6a0c0e70a4f7@app.fastmail.com>
Content-Language: en-US
From: Jacob Keller <jacob.e.keller@intel.com>
In-Reply-To: <866cb878-47fa-4bb9-ba93-6a0c0e70a4f7@app.fastmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QlYrRWRYRUQrNHQvbnBGazdFb05hd1ptNjR0Q1RpRHl2OFpwa005TUZ4Zlp3?=
 =?utf-8?B?emYrZFFqUWFSVVM0d1J5TXVzUUE1YWMrK25hR3BQNTQ0R2F0QXFOTnNEaTU3?=
 =?utf-8?B?ZlVIT3lsRlNuQ3dZeVJPQnlib3NiUW05cGpieGh1ZEN4RFBUVmUzWjQ3NVNN?=
 =?utf-8?B?QTlmY3VvUFlyT0FPcHhZeS9uZkdKWkxrZkJVUVAxRDZKN0pITXp6cGlYNU1i?=
 =?utf-8?B?bGVrdlZGNkhJSXpCWE9mT2N6bEJ5SWRMWmdURE1QdDBlREprdDRkelhQRExn?=
 =?utf-8?B?OVdVSlpMME5qd09ucVVRcEQwOXgyT3kzTXl2Q3EzWUJDS2o4cnNhemFhWFQ4?=
 =?utf-8?B?ZCtVNFg5YkxvQm4rWm1vTmZPS3JmMnUyb0VyQjFlUUdJTVV0ZkVnZW5GNHp1?=
 =?utf-8?B?aExSUWEvZi9LS0Q3WnpmU0FVL0x5QktGR1pmY05tZVppY2UvZnh0M2JOMGhq?=
 =?utf-8?B?eXBkYUVVVktiU2xlcjN6VFdkMldKU2pxZ3FwNTMyUXozTkpmN1JSYmM5MXpG?=
 =?utf-8?B?R250anpYcWN5blVKTjZXbHIzTUtUWHltTzRqc0UrK1hsM21iQ2h6VW5hZ2RY?=
 =?utf-8?B?UE45cmhuRlBFVnVMVjBCdHRjdWo5ejdvQ01Cbk14T1gva3M0QmhlZFVHc0s1?=
 =?utf-8?B?aTBIR3QrREpXZktMZGVOS1l3U05ObW9uU0xKb2hSdHl5b3duaVJHU0J2Q2tJ?=
 =?utf-8?B?NVBsbkdUY3VLd05XdW5HWmpncEFibG1GOGRzd2pyV0JCSjJqblJuVFJGcDFX?=
 =?utf-8?B?UDcvWWgwRDl1VGRYbjVYQm0yRFRadkZxdXEvWVk4WmwxZkJmRDhpNDJKQ1FV?=
 =?utf-8?B?ZGZ1YS8wdWNQcmhiTGNpNjJoSHJZeXhBSm10WVBGRk9Da3E3ZzVlN2QyOE40?=
 =?utf-8?B?SWJlVjZGQURXaXVQcmk2RWxVVjN6Q3JKR09RNTRiSmFDQ21kM2Z6Y2didE5l?=
 =?utf-8?B?MlZYOGVkRGtXZnRRM3A4ZXVwdjcwbW1VZEgrczNacTBZK3kzQmczMGNMZlRa?=
 =?utf-8?B?SVdzeHMwZWRzWnVsMWVPcXlmaHVvWDZMdWRxVkR4NmtYeUZTYkxIVHNBdDJ6?=
 =?utf-8?B?bWVKOGpRNU1hZG1EbENvamVMUDNTNFI5MVAyRUdIcTdBeTl0MFUzUkkreVB0?=
 =?utf-8?B?di84cFZYcXJtejAxNU5idTNHSzBGN3VBZmhvU09UblZRRlBuWCtaUThGTDdF?=
 =?utf-8?B?ZVhQQ05Xa1lReUpWRXJnSzc0cFRhSE9TVUdLRHE5RXVWRG05ZUVzNWFpQUpi?=
 =?utf-8?B?ZGJ6WFJGMEE3UHV6OUQxMzEvMzBpeWgvMjFpWXlQSkdVdHJqa0ZBeEVDVi9D?=
 =?utf-8?B?SG9uL05JaXF0L1l4UGd1Szl2eCtaMW9MOHhPY1FEMTJQeXVYRjVTcWNuWVdQ?=
 =?utf-8?B?clIvZXBvRUY2ckJYeSsvTk5mU01lUFBnT2xsbzBBSzI1cXdNVldMWVRlNTRT?=
 =?utf-8?B?UEhKdEdQNEtiQ2ZCUmhSa2FkcG1SaE5Day9xVHVRTWdocmlMTDBaVVVkUEFE?=
 =?utf-8?B?bkI1M3RkOHBKazdHRU1VektUQWFLdHJMeTRDajlMczhvL3BPeS9ieXMydlNL?=
 =?utf-8?B?M1pwWDBmR3hnVmo1ZW1FSE5uamk4amE1K1hwZVprbDBoMldBYmlrRElqT29H?=
 =?utf-8?B?a3pxT1pIVUdSQXNLVVZqeDBRNStWYUhEdzZ6RzBnVWNDMTdUODFSbmxCVnIx?=
 =?utf-8?B?QU9xS0h5TjkxQkpBQlgrT3JUNE93TXZ6Q0Y0bzN4cHFKbnVaVmNUWE5BSDhr?=
 =?utf-8?B?Tjk1Q0JFTEg5SWR3Ty95RkJRazF0UmM3V3FMeW9mcWRFUHg0UEo3aThTcmV2?=
 =?utf-8?B?ZzhCSXVmSmd1dHJFWFBuVWdRK2pBY0dUQ1M4TzdMWUVVL3BZaXpxSHVZTm1L?=
 =?utf-8?B?Yi9pM2dlWVZBWVdKcHozVEQrOGt5MlNOK2ZJYlJTRUdST2hmbnlXSG9hMXlK?=
 =?utf-8?B?ZjFzSS9rM01mN1FSWlQ5TTV1a0x1ZHNORElpU25YcXlRbXFDV0M1cXBwT1Bx?=
 =?utf-8?B?SWZEQVVneWJlQjYrVTQ2VGJHblpjaUhSRTk1OXpKUW5sdDlieEQ2cWJSWkl4?=
 =?utf-8?B?VVBPRFZYWHQreE14Q3E1dGFlcXUzVXNabUhjUGxsR21ha0ZLK1hJV09WRVc3?=
 =?utf-8?B?OVBwVGxzbFdxSFI4Y0tad2xJbUZwZkUvNVlhUGJXby9NeTEwNVdlRGJNMGp2?=
 =?utf-8?B?Znc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: b4883ff1-63bb-4fd6-f970-08dc80e75880
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB5089.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 May 2024 20:30:29.1422
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: uPJFTsV52oFJPq67BS9/AYkndEdLx7o1XDSsyi1lGDLmhp+vO6pFypIefM0LmXycdT6cxbTERFrrf6NeKoY6wnAw7n6S6uWXruOjaccZTAY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB7766
X-OriginatorOrg: intel.com


On 5/30/2024 11:52 AM, Arnd Bergmann wrote:
> On Thu, May 30, 2024, at 19:54, Jacob Keller wrote:
>> On 5/28/2024 8:25 AM, Arnd Bergmann wrote:
>>> From: Arnd Bergmann <arnd@arndb.de>
>>>
>>> Each object file contains information about which module it gets linked
>>> into, so linking the same file into multiple modules now causes a warning:
>>>
>>> scripts/Makefile.build:254: drivers/net/ethernet/marvell/octeontx2/nic/Makefile: otx2_devlink.o is added to multiple modules: rvu_nicpf rvu_nicvf
>>>
>>
>> When I tried to build, I don't see any warnings produced on the current
>> net-next with W=1. Is this something new and not yet in net-next tree?
>> If not, how do I enable this warning in my local build?
> 
> The warning has been around with W=1 for over a year now, it still
> shows up here:
> 
> make ARCH=arm64 allmodconfig drivers/net/ethernet/marvell/octeontx2/ -skj20
> scripts/Makefile.build:236: drivers/net/ethernet/marvell/octeontx2/nic/Makefile: otx2_devlink.o is added to multiple modules: rvu_nicpf rvu_nicvf
> scripts/Makefile.build:236: drivers/net/ethernet/marvell/octeontx2/nic/Makefile: otx2_dcbnl.o is added to multiple modules: rvu_nicpf rvu_nicvf
> 
> 
>     Arnd

Hmm. Ah yep, I must have missed W=1. I thought I had it enabled. Doing a
clean rebuild with it, I do see the warnings.

Thanks,
Jake