Received-SPF: pass (google.com: domain of linux-kernel+bounces-195890-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Thu, 30 May 2024 13:39:58 -0700
From: Jacob Pan <jacob.jun.pan@linux.intel.com>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: X86 Kernel <x86@kernel.org>, LKML <linux-kernel@vger.kernel.org>, Thomas
 Gleixner <tglx@linutronix.de>, Dave Hansen <dave.hansen@intel.com>, Ingo
 Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
 linux-perf-users@vger.kernel.org, Peter Zijlstra <peterz@infradead.org>,
 Andi Kleen <andi.kleen@intel.com>, Xin Li <xin3.li@intel.com>,
 jacob.jun.pan@linux.intel.com
Subject: Re: [PATCH 1/6] x86/irq: Add enumeration of NMI source reporting
 CPU feature
Message-ID: <20240530133958.229975d1@jacob-builder>
In-Reply-To: <20240530091916.54056820@jacob-builder>
References: <20240529203325.3039243-1-jacob.jun.pan@linux.intel.com>
	<20240529203325.3039243-2-jacob.jun.pan@linux.intel.com>
	<9dabe435-7208-4aa8-886c-a3351ee11e80@zytor.com>
	<20240530091916.54056820@jacob-builder>
Organization: OTC
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

Hi Jacob,

On Thu, 30 May 2024 09:19:16 -0700, Jacob Pan
<jacob.jun.pan@linux.intel.com> wrote:

> Hi Peter,
> 
> On Wed, 29 May 2024 13:49:40 -0700, "H. Peter Anvin" <hpa@zytor.com>
> wrote:
> 
> > On 5/29/24 13:33, Jacob Pan wrote:  
> > > diff --git a/arch/x86/kernel/cpu/cpuid-deps.c
> > > b/arch/x86/kernel/cpu/cpuid-deps.c index b7d9f530ae16..3f1a1a1961fa
> > > 100644 --- a/arch/x86/kernel/cpu/cpuid-deps.c
> > > +++ b/arch/x86/kernel/cpu/cpuid-deps.c
> > > @@ -84,6 +84,7 @@ static const struct cpuid_dep cpuid_deps[] = {
> > >   	{ X86_FEATURE_SHSTK,
> > > X86_FEATURE_XSAVES    }, { X86_FEATURE_FRED,
> > > X86_FEATURE_LKGS      }, { X86_FEATURE_FRED,
> > > X86_FEATURE_WRMSRNS   },
> > > +	{ X86_FEATURE_FRED,
> > > X86_FEATURE_NMI_SOURCE}, {}
> > >   };
> > >       
> > 
> > This is incorrect. FRED does *not* inherently depend on NMI_SOURCE; the 
> > dependency is the reverse, but since it *also* depends on FRED being 
> > dynamically enabled, there is no need to add it to the static table;
> > the dynamic test:
> >   
> My misunderstanding of the dependency table, thanks for pointing it out.
> Will remove.
> 
> > > diff --git a/arch/x86/kernel/traps.c b/arch/x86/kernel/traps.c
> > > index 4fa0b17e5043..465f04e4a79f 100644
> > > --- a/arch/x86/kernel/traps.c
> > > +++ b/arch/x86/kernel/traps.c
> > > @@ -1427,8 +1427,10 @@ early_param("fred", fred_setup);
> > >  
> > >  void __init trap_init(void)
> > >  {
> > > -	if (cpu_feature_enabled(X86_FEATURE_FRED) && !enable_fred)
> > > +	if (cpu_feature_enabled(X86_FEATURE_FRED) && !enable_fred) {
> > >  		setup_clear_cpu_cap(X86_FEATURE_FRED);
> > > +		setup_clear_cpu_cap(X86_FEATURE_NMI_SOURCE);
> > > +	}
> > >  
> > >  	/* Init cpu_entry_area before IST entries are set up */
> > >  	setup_cpu_entry_areas();    
> > 
> > ... suffices just fine on its own.  
> I am not following, do you mean checking for FRED is sufficient for NMI
> source? I think it works since NMI source cannot be disabled if FRED is
> on. Just want to use the architectural CPUID bits to the fullest.
> 
Nevermind, I got it now, will keep the dynamic test.


Thanks,

Jacob