Received: by 2002:a05:6500:2018:b0:1fb:9675:f89d with SMTP id t24csp64126lqh; Thu, 30 May 2024 14:14:51 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCX+L9SyHuWz+7RCkAPkS8JM1Wl/1bsL/wno0+Q9Ksbt0b9rROp2o6tGLO1Hv97kltpencARO6OvSEuLGFURvBMJivFJOlrDigJVkscyyA== X-Google-Smtp-Source: AGHT+IF9jglxTt0tpKZIF03X8ulsJEzt7boXxgVTuqUImUGD1dKbC4GljIzpRWghA3DRWyFpawjH X-Received: by 2002:a50:cc9b:0:b0:578:197b:30d3 with SMTP id 4fb4d7f45d1cf-57a36382541mr95611a12.2.1717103691370; Thu, 30 May 2024 14:14:51 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1717103691; cv=pass; d=google.com; s=arc-20160816; b=Gq2JYdIRYdSWXcnssiL4WcLsRwineXEtnQpfi8tg1PSb3yNe6SZnSsJls24CXEAc3Q VRWoR1P1Nv77NlgMdTm6e9DwKgx8fF5lYAHkfBlWCm3dDB+O/oDSYtxeMU1zkmYAfkcU 3JvBkRdAIqOXtk87Z4yzelBZBCUVviMtzW02qPQe0BnYnf4TSucNXtPY+1apiWWWUeYE ORawtf3+xl28Ex224TLBqaZqtTSuxVkXvhGV+3+ss+DOvHiE32Y+CG9QdNd0uNYgre8l 2btOhv1zORMGmB7fdwda7eGYLj/7wLQBvhH+UYzNzC+hVaWSuedhvaHtdryYya4Lc9ww tQYA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:dkim-signature; bh=bnFlTPs2pgPgYgNKGfWbxk0F5NtAH0V5NFqN7FXOABc=; fh=LlrTOouP6yDFtvZDg0aN3qlsunxuL3Yz1uFdk790dZk=; b=0XR4esqnPZI4U2KC2KWA3oWj5Ay3aA+93zuuO2ZmlGDJuQXT8VO7hv35VjowoP+Vht 8t9GxEtFwqkEf1aJ8ONLIekPy5huq75X0xQUPNE8InZuLjXsIkMQpql/wK+lbnpVV7Nj cQojhHAQcOmx9O/mXJgk1CaPu6L5C4lhuj70/EoE+MqRJgLC0AXnG+44ts0vCFLxqP1c 8z1dBy/qZH3xzs5onfOvYeZOOepwVSFGID7KDm1jYLpZfR6joXZh4RqnrTT0b/m9g2cx pj9lI3XIb7ytrEg4WG16qEWfA2JzxKdNLE5oLMfd9M6FbB+8S5v3GJosVl/66lnDfUtn MQRA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=google header.b=Csy++LCS; arc=pass (i=1 spf=pass spfdomain=linuxfoundation.org dkim=pass dkdomain=linuxfoundation.org dmarc=pass fromdomain=linuxfoundation.org); spf=pass (google.com: domain of linux-kernel+bounces-195927-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-195927-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id 4fb4d7f45d1cf-57a31b80bcasi202500a12.24.2024.05.30.14.14.51 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 May 2024 14:14:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-195927-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=google header.b=Csy++LCS; arc=pass (i=1 spf=pass spfdomain=linuxfoundation.org dkim=pass dkdomain=linuxfoundation.org dmarc=pass fromdomain=linuxfoundation.org); spf=pass (google.com: domain of linux-kernel+bounces-195927-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-195927-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 19AF21F223BE for ; Thu, 30 May 2024 21:14:51 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 03D9F18130F; Thu, 30 May 2024 21:13:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="Csy++LCS" Received: from mail-il1-f170.google.com (mail-il1-f170.google.com [209.85.166.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C75ED145B3C for ; Thu, 30 May 2024 21:12:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717103580; cv=none; b=cWAmH0sev7s165/+WqBOOcuH4KFQUdoQVMigTtr+4oXy/OiokKIQlNSA4FjCZZbC/yA2/l7Fc3mJnO/fXHaGfNyG696GtayJ9Vn/oEv/7lfTnPLWNPuZotWkOUQvCJGRZBR9xRI47V+pCcQJJ/8DZs9r3giSjAq+q5InMCLuE8M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717103580; c=relaxed/simple; bh=nyif9nV5MZxEv61ZzzS4YP56t1CRAFYYagtsWILkqWc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=oMNgQjmC7erh5Vg9JpiscN0G0ETr62GXHewnTUO66F23QvfiJ1xpdAsAe96eAx9d2sGPPgJ4J8iFLJRBLDHCUu06NrueOo9CqMgoSs9Mb23kKxPt7IhH14lbPY8cPPZhfDm+Oz+oJ9EgD+Ui0ckkJw8588vIoojaecCrpPecQlQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org; spf=pass smtp.mailfrom=linuxfoundation.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=Csy++LCS; arc=none smtp.client-ip=209.85.166.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linuxfoundation.org Received: by mail-il1-f170.google.com with SMTP id e9e14a558f8ab-3745eb24ffaso895445ab.1 for ; Thu, 30 May 2024 14:12:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1717103578; x=1717708378; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=bnFlTPs2pgPgYgNKGfWbxk0F5NtAH0V5NFqN7FXOABc=; b=Csy++LCSXYpZrsQoZrxSCF6fYzzfMYlUUzo5etpE9K8p6C6KDeorgH6U/wM7UPRdDQ 1SJnf4TzLznSBwtRDs5HZJbM+eJ6X9oTzSMyuq2Tq+E4Dfg6P18GfCKscjh7KHvaGMRY bB8uu7IQda5IioOinB2FNxCYeYnJ5HJAFJK8Y= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717103578; x=1717708378; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=bnFlTPs2pgPgYgNKGfWbxk0F5NtAH0V5NFqN7FXOABc=; b=vjL20pbJLnYUj2umM7/s5+pXc4dUF13Pcfkb8HWKLU4L091YtFagu1rqH0EAcFygoj d1BFDnvpsIVdYAKg5tX44wXd0auWou5SV787lyMxVffQw4uQQtaHZfDmttG+8T78qnp5 AKzGwvC4pW1oK/TiZFkI04oUloF5QWa+FUE30FGyEUAgl74xgQc9AAvqo5B2eO6jC2Cd G0KXlK5+BB4icgEy5ZE3gN59HMN9qBXu0jM/klP7Nq9R+zz8cRqVywqY6uQQ78dNQG6K rovbgXTlaAjsOC/F26Uu8FNSHf7PM8SFiWxUi17FTsXb8gJ4EB2/7hVjAJzq8D+FsWHi 6bLg== X-Forwarded-Encrypted: i=1; AJvYcCWk1rtkPQwfQCWXZaSmp/IkaPrZ9SbWs+42FVRCK2tIyeitOuXPWreJ+wZSB3IFGjSSCq2RPInERMEtZu2qyBo+06xqMI8Q01Srv6VC X-Gm-Message-State: AOJu0YyE7nuPtcCskMBOTDTbw5stTwOMrDh2bV/LNYotI3XVOrO7srfq bxcH0NLF8fZKVmen1ekvp80g+c1Gpzkx898iZcY/2IWbf53qoarhwpZy56pSFeU= X-Received: by 2002:a05:6e02:1a0a:b0:374:60da:64dd with SMTP id e9e14a558f8ab-3748b96e509mr906225ab.1.1717103577901; Thu, 30 May 2024 14:12:57 -0700 (PDT) Received: from [192.168.1.128] ([38.175.170.29]) by smtp.gmail.com with ESMTPSA id e9e14a558f8ab-3748a27a27bsm1084115ab.87.2024.05.30.14.12.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 30 May 2024 14:12:57 -0700 (PDT) Message-ID: <3db9068e-9f95-4ad9-86fa-e24b06da8828@linuxfoundation.org> Date: Thu, 30 May 2024 15:12:56 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/3] selftests/futex: don't redefine .PHONY targets (all, clean) To: John Hubbard , Shuah Khan Cc: Thomas Gleixner , Ingo Molnar , Peter Zijlstra , Darren Hart , Davidlohr Bueso , Edward Liaw , =?UTF-8?Q?Andr=C3=A9_Almeida?= , "Nysal Jan K . A" , Mark Brown , Valentin Obst , linux-kselftest@vger.kernel.org, LKML , llvm@lists.linux.dev References: <20240529022938.129624-1-jhubbard@nvidia.com> <20240529022938.129624-2-jhubbard@nvidia.com> <20ebb3a6-cdbb-4ffc-9ba2-c9eaa4d6ec74@nvidia.com> Content-Language: en-US From: Shuah Khan In-Reply-To: <20ebb3a6-cdbb-4ffc-9ba2-c9eaa4d6ec74@nvidia.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 5/30/24 13:13, John Hubbard wrote: > On 5/30/24 12:03 PM, Shuah Khan wrote: >> On 5/28/24 20:29, John Hubbard wrote: >>> The .PHONY targets "all" and "clean"  are both defined in the file that >>> is included in the very next line: ../lib.mk. >>> >> >> What problems are you seeing without this patch? > > Code duplication. It's a sin. :) Please mention that you are removing duplicate code. futex Makefile overrides CLEAN - just making sure it does the cleanup correctly. thanks, -- Shuah