Received-SPF: pass (google.com: domain of linux-kernel+bounces-195932-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <1f30da7f-59fb-4d43-9ef9-89573402cf4d@intel.com>
Date: Thu, 30 May 2024 14:15:15 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [RFC net-next v3 1/2] net/mlx5e: Add helpers to calculate txq and
 ch idx
To: Joe Damato <jdamato@fastly.com>, <linux-kernel@vger.kernel.org>,
	<netdev@vger.kernel.org>
CC: <nalramli@fastly.com>, Saeed Mahameed <saeedm@nvidia.com>, Tariq Toukan
	<tariqt@nvidia.com>, Leon Romanovsky <leon@kernel.org>, "David S. Miller"
	<davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, Jakub Kicinski
	<kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, "open list:MELLANOX MLX5
 core VPI driver" <linux-rdma@vger.kernel.org>
References: <20240529031628.324117-1-jdamato@fastly.com>
 <20240529031628.324117-2-jdamato@fastly.com>
Content-Language: en-US
From: Jacob Keller <jacob.e.keller@intel.com>
In-Reply-To: <20240529031628.324117-2-jdamato@fastly.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?N1FjaGdDVUY2MGZuWkRsY1UwWGJZTDUzZXVYS1NRT3BKdzkraDROOGlwWjVn?=
 =?utf-8?B?cFVBYmZONWpHRWoxVlcwdmJ5QzR0WjY4L3M5ZnFINlExNUZqbjF0ODZla2h4?=
 =?utf-8?B?ak9Vdnd1WUJ6MVptVmdBZWV6cDJRS2JSZndOTVorcFh1cERoM2liMTBrUmJ3?=
 =?utf-8?B?UjZIY0xhaDJvdUZaWHFaT3FxSTBaaU1MaVY5UzVUcW1KeklTRms3UUhtQVRB?=
 =?utf-8?B?Tk41dU1oZk82ZFJQQlAya21FUDVINkl1OWtKaEpjbThWMGZUTGNsbDd3cDFL?=
 =?utf-8?B?YmhsZ0JOY3FCL3I0ZUx6cDlpNlRJTGM4ZVphZ2VNVDJCZnYxdmFjazhLTjFE?=
 =?utf-8?B?TDJLYitWbTMxY0tKbmRJSW5TM0hYOXdiR0FVVGdmLzdMRkRnUDZJOFlaelJL?=
 =?utf-8?B?M1MzY3VHNzF4WDArRktvVjFVblQwK3ZFZk5GTFBNYnlYSkN5T2lqc1V6RTVN?=
 =?utf-8?B?UzE0elpleHhXbVF3d01wRTY2L05MamlENkpLRndjdDB0MmVOczAwbUxUbmRV?=
 =?utf-8?B?dlFJK0x6VjRNbFZGREdGY2RGV3dPRnl1WEllcXIxTU9wZWZTdUxhM25RcnZH?=
 =?utf-8?B?NzZ4T0xKNXhiRWdpSC96V3JDVEQrV04yMWVQU2xkZ3RMdGNxYnl3U1VhemNi?=
 =?utf-8?B?S3dBbDljS21sdmJHd0Rqc3F3U2d6WjlrLzFoZG9TNHVDZllCMEpyNG42STd1?=
 =?utf-8?B?VldnYkd4VlhkQ2lVdDhURGxlT0ZDRjRudjdDS3M5Um42Vzl2dldSckZ1Ung1?=
 =?utf-8?B?aXQzdHRGWHc1MDZUSGR4cGFISnpLbytjUDA4VE0reXFwZzlPNXVBT1VTQnBp?=
 =?utf-8?B?UTBKanhFbnpuOXlvcFdSd0pyT0FUbGcyenZYbDJSZ3kzbTFsc0RXTU0yMnh2?=
 =?utf-8?B?OFJFRVdjSGJhUEtzY3A3dkE0Zk1GMFlpL0dkOWpWelA3UFU5Ylp5N2hFZUZ2?=
 =?utf-8?B?eWRQdmJxeVk3RElRazVaQlg3WlRETllieDVURHZHNkFKWnR6UzhSRWhMRWQw?=
 =?utf-8?B?NE05QUErM3BBRHkwdW83Wi9SRzZYTURpajQzdGtveUNFRzQ2K3NKL1ljVkM4?=
 =?utf-8?B?THNLVnFoQ2dGTlFmSXJiSEY0YzljOFplRGxURGV0L2dlbDBPZTVvT2h4ZnpL?=
 =?utf-8?B?bFgxalB0VktzOGNNR2ZQSlVSVHdGSjAycWhSZ1J0Mk5PeWlWWHFTaTNDMm80?=
 =?utf-8?B?VmRxaEk3MHpubGFSbHp0QkhsYW80ODBJdTkvTkhQNjJMeDA2K1hYZHFaN2dI?=
 =?utf-8?B?ejJhdTh3ZWQxKzVCUGI2YkVYaE1wRGYrOGdXNHJ2SXlJc2t1RmtoN01URi91?=
 =?utf-8?B?UTV2aDZ0RGVjV091OW5md25Sd3hlU3lkd2J6OFIwWlhQUmR0VFZQS0gwaDFG?=
 =?utf-8?B?Y05VWWxPOEtUY2d6NmFBYlB6TzA0aG1RZ3ZnVzZ0UjNUTkt1L2VxeGVycmJF?=
 =?utf-8?B?MURYY1R5Q1NEUCtUOU5OMGdwM2hmQnN6NURkUUdnVFpESFNOTHc1SG5oSXFx?=
 =?utf-8?B?TjFoNlVoTTJSNWMvbXFraDB1TitxazE3YUpoUEZiNHFja2dXVkppTWVYaEln?=
 =?utf-8?B?QjRRVkxxSzl5RjYwVzY5SUlQSTRBTzFTK29SWEJvNjRvWFk1U0pJUDNjWk5k?=
 =?utf-8?B?Z2FZK2RtcHNmbVRQUFRmb0x6Y0N3NXhaMndBVzV2SzRFdkdWdVBFNHBSOTF2?=
 =?utf-8?B?UXp4S1hoQVF6MTM2TnRjZ0NSUFIybzRhaGZ3WEJ4WEk2S1lRMk5INHprUGk3?=
 =?utf-8?B?VUEwaXg1dGh0eUpqUHA1dTFhbkM1Q1pEai9oaVl6NUdXREl5dmh3Q1JicFN6?=
 =?utf-8?B?VUlPQVUvQUNCRDNQWDhiL0thSXMybkpQY3FjSkpiVlhIN3Y1MEZGVDhZUTVi?=
 =?utf-8?B?MGh6M2dmc0JhMEMrbURDUFg0TEJGa2x6Vkp3M2JhUzFWTGQ4V3lyUitiV3ky?=
 =?utf-8?B?aGdidmxtOGR3cE1TdUwxdlJpb2dPZkd0b1NmTjkyRjl4K0hrMGFaSGZUaXVJ?=
 =?utf-8?B?NDRXbTlSTXFiMUZ3WW8yTzN3UHZ5TmdYVDdyNEVIeW5xMkg3OUdWUlFRRnEr?=
 =?utf-8?B?MGRMMmwyZGFRT0NlNG9wTUNkWnJKRjdYZnRNQVFZZkh0MEFvRS9pN3kzSEpM?=
 =?utf-8?B?VlpSSldlZ0NOQThFbU1DYklwUXJialFPMHpSZWlvVjNJaTViTURPcnhodHNp?=
 =?utf-8?B?Vmc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 276602f1-1e35-4eff-3e9a-08dc80ed9a76
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB5089.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 May 2024 21:15:16.7690
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: qgIbykkiOyXsDd0Wv/f23jQs3hzJClrl6E3OPpRG28Xf8VrdMGS75J6gaCa5APoy313A6Ye8lI8p03fJOZLt6OWx6b+38LbBVi5QQ56Gstw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM3PR11MB8760
X-OriginatorOrg: intel.com


On 5/28/2024 8:16 PM, Joe Damato wrote:
> Add two helpers to:
> 
> 1. Compute the txq_ix given a channel and a tc offset (tc_to_txq_ix).
> 2. Compute the channel index and tc offset given a txq_ix
>    (txq_ix_to_chtc_ix).
> 
> The first helper, tc_to_txq_ix, is used in place of the mathematical
> expressionin mlx5e_open_sqs when txq_ix values are computed.
> 
> The second helper, txq_ix_to_chtc_ix, will be used in a following patch.
> 
> Signed-off-by: Joe Damato <jdamato@fastly.com>
> ---

Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>