Received-SPF: pass (google.com: domain of linux-kernel+bounces-195934-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <e1119c31-f249-4e0d-b965-59967f38711d@intel.com>
Date: Thu, 30 May 2024 14:16:18 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [RFC net-next v3 2/2] net/mlx5e: Add per queue netdev-genl stats
To: Joe Damato <jdamato@fastly.com>, <linux-kernel@vger.kernel.org>,
	<netdev@vger.kernel.org>
CC: <nalramli@fastly.com>, Saeed Mahameed <saeedm@nvidia.com>, Tariq Toukan
	<tariqt@nvidia.com>, Leon Romanovsky <leon@kernel.org>, "David S. Miller"
	<davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, Jakub Kicinski
	<kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, Richard Cochran
	<richardcochran@gmail.com>, "open list:MELLANOX MLX5 core VPI driver"
	<linux-rdma@vger.kernel.org>
References: <20240529031628.324117-1-jdamato@fastly.com>
 <20240529031628.324117-3-jdamato@fastly.com>
Content-Language: en-US
From: Jacob Keller <jacob.e.keller@intel.com>
In-Reply-To: <20240529031628.324117-3-jdamato@fastly.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QnhUR0RVd1lnbExxYnBqd2ZGUHBRM0xWZlBXN0pOWmRKV0hwcGptbi8rV1Zs?=
 =?utf-8?B?MHZXVEVHYk5SeEVhZlNIV0lZYWoxdlh2YlZ5eEdWOUFpSDU4enhnUGpKdG1T?=
 =?utf-8?B?NGpMa1FmbytsM1k3UVFNZEF1WXNqWHV6cXRldHdVZ1JGZHl0bHhpMjlnUG10?=
 =?utf-8?B?MzZMMXF5enFibmJmQ1U2UDFxODk1QmZlQ0YzS3RNT0lwMWo1TFdESXBWL2pQ?=
 =?utf-8?B?WnVRL3BhSkN3RTl4R1pVVnFvNXJ2Y0pjN0ZHdzhkTCsxRElnKy9DamltRHdk?=
 =?utf-8?B?b0ZPNW5nb1NUSDF6TE1JcVVnMkhWc29UNWpvNU9DRGhpOTBoeVE0ckIzK0hM?=
 =?utf-8?B?WHdnK2R2WDhRb3JBam4vQjc2N01BdEhXeXRrK2kyQTFPQzJjZVhodDJkb01z?=
 =?utf-8?B?azVxUTZnaG54WFloa0ZjRGZQNXB3aisrcTV2azYxQ2xpU3cxcWk3ZzlQS1d5?=
 =?utf-8?B?VUcyOHJrU21lR3hObmJWSXJMMGZiR1VURkQvSytMSERIdGh5M1ViMm81RUpq?=
 =?utf-8?B?QmZ5VWloODNFS3laUjZTMEhsei9xOWI0d1ErR21FN0NhVjZjdjFVZllBVjV6?=
 =?utf-8?B?aXFpd1FxZHQrWmV5SUhnRUtqdXBtSUdTVXI1dU1IaGRjWVJmOFNrU2JPblUx?=
 =?utf-8?B?Sm1LQTY0aUptRDM3Q3l3K2l1SFBZUjFYWkZNOGxJakoxVDlLRFkyTmtzOCtw?=
 =?utf-8?B?djRXYnZGRVB1cXlCa3R0TDdpY3QrMDFUR0h2Rk9hazJsZ0NXUjhUbUxvSzFu?=
 =?utf-8?B?SCtLVzlFVGlLRENidXJMVFFzU21HcnQ4amo4eHlBZUcvMERuUFpObytmbjFi?=
 =?utf-8?B?MVQyTURRZWVHK1ZDcURyODZIdlJnV1FqajdQRVJmVU8wQ215bVFnUVd3Lzl2?=
 =?utf-8?B?UzU1TEx5SHpsZnFDVHVXU3UwSXJDZW1TUkNSaW1CYjhUNUFTSnFUajYxTHJh?=
 =?utf-8?B?UWNpUG5tRTRCTDJwZC8yQTVPQVFWUGRmWUhtTnJ6cDI3OGRDQStqOGRRczFB?=
 =?utf-8?B?NWc0bnFIN3RuOERSVXJ5Wm1GQjJ1VUJ3OXI1Tjg5V2hEZkViYUhnTFdSM1pq?=
 =?utf-8?B?WCtuOGk1dDQzTE5uR005b0dlSm9QM20vLzlLcXg1MVNEMnFSeFY3d1UxU3c1?=
 =?utf-8?B?Sm5jNWQ0R1kyMkNWdk1JbThaNnk2VHEwWWpha1FqVmxtUjY3dXZVVEh2VlVq?=
 =?utf-8?B?K01hRmFsd0h3dU1BUDVWWnJ2azRzYXMwb2FodVhKNTUvOUlrMjJOMXpoMDdX?=
 =?utf-8?B?L2I3SUxVY3NNYTZuSUNrMWxzb0s2KzdDVlgvaFBIUkVVRnpKR2U2ZVpNMWtB?=
 =?utf-8?B?bmN2N0I3MkkxMGNFQWVUUmkwR0szRXZTaTl4UDVmQ25kNEU4M1R0YTZFTGhk?=
 =?utf-8?B?bDlHNDQvM1dKQ0FtK0lncG5JNk1HZDdGTkQ0ZFRzVTdPMUVTWmlXc2RVREVJ?=
 =?utf-8?B?WXhrQThDeitsTkJyTlkyaERlZmpTNk84QU9yazNnVm05aFVra0JVaHl3QzhR?=
 =?utf-8?B?UGN4bFU4ak9wOEZVVkJQOVhUeHlRSXYrRWU3NmdhY3dLWjVsT3pxd2crUVdE?=
 =?utf-8?B?YmRvMXNLRXBINU12dnNEaU43UEYyMTR2bFFtQXlMUUk3WXhHNFp0TmJacEpQ?=
 =?utf-8?B?SXNBSG5id3RoRDkwdXhKeW5oNVNDa1o1c1BSM2l6S0dYVE1KNGNHaFZ0UHVs?=
 =?utf-8?B?dm5wMGNGOElGbnZ3TXFrb1dLYmxxYWhINS83UFhYeC8ycTJUVmsvRXZMYjc5?=
 =?utf-8?B?c3c3dG4yY2tmNDh4WjRNR1BOOER3QnRJQ0VMT2RlTEN1UTVpSEtGNThTaXo5?=
 =?utf-8?B?R1cvaHFvZzhqQnk2OERXQ2tjTFRiRDhCa0FCenZXcUlVZzZycys3UEV3UUFq?=
 =?utf-8?B?YldqZDRoVzUzQ3lOVHhCUlNSSER5TCswOXlVNHQ1QUI5Y0VYaEJMNXRzdmpP?=
 =?utf-8?B?bG14Z21KcU1zZTVkZ2hEU2tXZXpXZDhRd1FtVGxmZFl0RVlaZ2hSVGE4K3hk?=
 =?utf-8?B?NEp5a0FIbTF1bGRXTWhHakE4V29uNVpsMVdmaGc0L0N6UzdNdkhiTzFQd2ho?=
 =?utf-8?B?K3hPR3Y2M2hGK0hMekZ6NVh2RDJEM1hGS1dxWlA5YTJoM05ubGVjeXRxclV1?=
 =?utf-8?B?dStRSDhQTnpkSTJXR3gzTVpjVG1ha1ZOTTYyTnRiTU1ZMjRMOER6RjFtYnJN?=
 =?utf-8?B?Tnc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 49c06106-1f51-4076-2a5c-08dc80edbfae
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB5089.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 May 2024 21:16:19.2089
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: +FyDMQ6ASQAbHqOZ+Rd/xpBldAr82s1B0jPUZCBvge8gKldQ3N7sxrNAEU4TI2YdQ6v+pT4VKwS1+3mho33rZecT6/cMstl7BktZ3Ja8p1s=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM3PR11MB8760
X-OriginatorOrg: intel.com


On 5/28/2024 8:16 PM, Joe Damato wrote:
> Add functions to support the netdev-genl per queue stats API.
> 
> ./cli.py --spec netlink/specs/netdev.yaml \
>          --dump qstats-get --json '{"scope": "queue"}'
> 
> ...snip
> 
>  {'ifindex': 7,
>   'queue-id': 62,
>   'queue-type': 'rx',
>   'rx-alloc-fail': 0,
>   'rx-bytes': 105965251,
>   'rx-packets': 179790},
>  {'ifindex': 7,
>   'queue-id': 0,
>   'queue-type': 'tx',
>   'tx-bytes': 9402665,
>   'tx-packets': 17551},
> 
> ...snip
> 
> Also tested with the script tools/testing/selftests/drivers/net/stats.py
> in several scenarios to ensure stats tallying was correct:
> 
> - on boot (default queue counts)
> - adjusting queue count up or down (ethtool -L eth0 combined ...)
> - adding mqprio TCs
> 
> Signed-off-by: Joe Damato <jdamato@fastly.com>
> ---

Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>