Received-SPF: pass (google.com: domain of linux-kernel+bounces-195940-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Precedence: bulk
MIME-Version: 1.0
References: <20240522114755.318238-1-masahiroy@kernel.org> <20240522114755.318238-4-masahiroy@kernel.org>
In-Reply-To: <20240522114755.318238-4-masahiroy@kernel.org>
From: Andrii Nakryiko <andrii.nakryiko@gmail.com>
Date: Thu, 30 May 2024 14:17:22 -0700
Message-ID: <CAEf4BzZ4JvrnXYdE7YP06b574b5QKiU-asy_jtnP=JGH-5uR3g@mail.gmail.com>
Subject: Re: [PATCH 3/3] kbuild: merge temp vmlinux for CONFIG_DEBUG_INFO_BTF
 and CONFIG_KALLSYMS
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, 
	bpf@vger.kernel.org, Ard Biesheuvel <ardb@kernel.org>, 
	Nathan Chancellor <nathan@kernel.org>, Nicolas Schier <nicolas@fjasle.eu>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, May 22, 2024 at 4:48=E2=80=AFAM Masahiro Yamada <masahiroy@kernel.o=
rg> wrote:
>
> CONFIG_DEBUG_INFO_BTF=3Dy requires one additional link step.
> (.tmp_vmlinux.btf)
>
> CONFIG_KALLSYMS=3Dy requires two additional link steps.
> (.tmp_vmlinux.kallsyms1 and .tmp_vmlinux.kallsyms2)
>
> Enabling both requires three additional link steps.
>
> When CONFIG_DEBUG_INFO_BTF=3Dy and CONFIG_KALLSYMS=3Dy, the build step lo=
oks
> as follows:
>
>     KSYMS   .tmp_vmlinux.kallsyms0.S
>     AS      .tmp_vmlinux.kallsyms0.o
>     LD      .tmp_vmlinux.btf             # temp vmlinux for BTF
>     BTF     .btf.vmlinux.bin.o
>     LD      .tmp_vmlinux.kallsyms1       # temp vmlinux for kallsyms step=
 1
>     NM      .tmp_vmlinux.kallsyms1.syms
>     KSYMS   .tmp_vmlinux.kallsyms1.S
>     AS      .tmp_vmlinux.kallsyms1.o
>     LD      .tmp_vmlinux.kallsyms2       # temp vmlinux for kallsyms step=
 2
>     NM      .tmp_vmlinux.kallsyms2.syms
>     KSYMS   .tmp_vmlinux.kallsyms2.S
>     AS      .tmp_vmlinux.kallsyms2.o
>     LD      vmlinux                      # final vmlinux
>
> This is redundant because the BTF generation and the kallsyms step 1 can
> be performed against the same temporary vmlinux.
>
> When both CONFIG_DEBUG_INFO_BTF and CONFIG_KALLSYMS are enabled, we can
> reduce the number of link steps.
>
> The build step will look as follows:
>
>     KSYMS   .tmp_vmlinux0.kallsyms.S
>     AS      .tmp_vmlinux0.kallsyms.o
>     LD      .tmp_vmlinux1                # temp vmlinux for BTF and kalls=
yms step 1
>     BTF     .tmp_vmlinux1.btf.o
>     NM      .tmp_vmlinux1.syms
>     KSYMS   .tmp_vmlinux1.kallsyms.S
>     AS      .tmp_vmlinux1.kallsyms.o
>     LD      .tmp_vmlinux2                # temp vmlinux for kallsyms step=
 2
>     NM      .tmp_vmlinux2.syms
>     KSYMS   .tmp_vmlinux2.kallsyms.S
>     AS      .tmp_vmlinux2.kallsyms.o
>     LD      vmlinux                      # final link
>
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> ---
>

LGTM, thanks!

Acked-by: Andrii Nakryiko <andrii@kernel.org>

>  scripts/link-vmlinux.sh | 45 +++++++++++++++++++++--------------------
>  1 file changed, 23 insertions(+), 22 deletions(-)
>

[...]