Received-SPF: pass (google.com: domain of linux-kernel+bounces-195931-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <6bca860d-2189-40a8-9588-11edd3b3840e@nvidia.com>
Date: Thu, 30 May 2024 14:14:43 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 1/3] selftests/futex: don't redefine .PHONY targets
 (all, clean)
To: Shuah Khan <skhan@linuxfoundation.org>, Shuah Khan <shuah@kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
 Peter Zijlstra <peterz@infradead.org>, Darren Hart <dvhart@infradead.org>,
 Davidlohr Bueso <dave@stgolabs.net>, Edward Liaw <edliaw@google.com>,
 =?UTF-8?Q?Andr=C3=A9_Almeida?= <andrealmeid@igalia.com>,
 "Nysal Jan K . A" <nysal@linux.ibm.com>, Mark Brown <broonie@kernel.org>,
 Valentin Obst <kernel@valentinobst.de>, linux-kselftest@vger.kernel.org,
 LKML <linux-kernel@vger.kernel.org>, llvm@lists.linux.dev
References: <20240529022938.129624-1-jhubbard@nvidia.com>
 <20240529022938.129624-2-jhubbard@nvidia.com>
 <ceb9182e-b6d4-4f6d-bb53-87efe5337230@linuxfoundation.org>
 <20ebb3a6-cdbb-4ffc-9ba2-c9eaa4d6ec74@nvidia.com>
 <3db9068e-9f95-4ad9-86fa-e24b06da8828@linuxfoundation.org>
Content-Language: en-US
From: John Hubbard <jhubbard@nvidia.com>
In-Reply-To: <3db9068e-9f95-4ad9-86fa-e24b06da8828@linuxfoundation.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?bVFEN2xVV1RGRWRnWEVkak52ODJ0NHF3UHR6UVNQZWNLTDkyUTFVVVFBOW0y?=
 =?utf-8?B?UmFhWUZEMHVORENGYUhWT3FxSVYxNXJqb2lndGtEOVphVm9ZS0pzU0g0eU5h?=
 =?utf-8?B?Z2c2NWZiL0Jtb3Y5UFJCajNLeHpLVFREb0VmYS9NQ2l3aVcrdmdCcjB4NEFu?=
 =?utf-8?B?RlBvVU9iNXdGeUhIMy94dksydm9NME5kTzh4OVoyUEsyaUFya2dSanFqd3A4?=
 =?utf-8?B?OVlHM2FYZnlSbmdNVkRoRUNxVDFIZXpuRjZ5Zi9SZ1U4RWRwQXdQQytodnlu?=
 =?utf-8?B?OHBWTmhSbWJQMzAyVnRlNjR2OVF2cndXdWtPZmdRQ2xwbGsxaDdJMkdKb0Z3?=
 =?utf-8?B?ZnFHTXNjcUdlWFBCZGJibVF2TW9yd0RreVhTN1BLWUtad2l2RC84eGFYVzlx?=
 =?utf-8?B?UnVRSVlsbGh5TTQ5S1Vqc29OYlNqVXFaYWJpejFOWGcrK3labk4zVXNmL1RF?=
 =?utf-8?B?NWMrSEZnc3VQZ1RscGxCcHZFKzhIRmZVeTQ3Mk0xZVNvWHJ2VzhTZjQxZjB2?=
 =?utf-8?B?NmFYamRaLy9tek5xc2lmMEVaNTNDYzZ0UGhISW1XKzZyemtuWVVNT3NSWmZH?=
 =?utf-8?B?RW1CSmVWNEY0R1BITTh1VXR6eFJjcWVLVi9wMUg3ckg0a2ZuakFOd1NhYXJW?=
 =?utf-8?B?SlIvUDVQbjd6RWRoVEJEVEVsS1l6eWdJWDRIcnBVVXhaaVQ2dWx4K0pPenFs?=
 =?utf-8?B?eHUvMFNtR2M5L2ZMcHB5SllSc3N6cmRDYldBTWRyQ0tidWRpWjZMaVpPUk1I?=
 =?utf-8?B?LzFEQS9sMkR3alcrMWIxaVBhWTVNVnFmQVUzUDFabHhvcEpUcXI0Qkd5ZVMx?=
 =?utf-8?B?Tko1akhYaGdrQVBCVVNTK0hHeCtFLzdpVjlTSEhBYmNXZXhzMHpkK0sxV2Ux?=
 =?utf-8?B?djlsZnI5MHFrR2FsZ0FmeEZwMllweTc3ak1tYXJGNFVWRko3SGY1V09mTG13?=
 =?utf-8?B?aWd3UVYzY2hMMGJsQ25LNFZReHcxMHFUV1AwbkE3L3UxNHJpdXlMK3NNWERW?=
 =?utf-8?B?TktGWGZUWDBHWnhTUGJralF1Z3JQVG5EWnNXcjhpNkR1bmFIYkpIM2FxVldX?=
 =?utf-8?B?M01wNytxOFBQOFkrRTJ4UzJKU2JGRU1NMi95VyswTDlqVTF1VmZwU1pHZmht?=
 =?utf-8?B?Q21NdFJrMldTRkJEVTM5dk8raHpxUjNnOU9GZVBtK1hQUnhEVzQ1bFhTa2ow?=
 =?utf-8?B?WlFlNHJqOVNLRTVSQmpNK3gvRXFKS0hMcmFNUHVVSUpjdlNKQkRTV1IxRjNv?=
 =?utf-8?B?NFgxbUoyYlAxYkttOHorSkNMZ1g2b0hZZCtHM1JNRVlrcnFEWGcrTStSZ3I4?=
 =?utf-8?B?Mm5ScnBmZXhvMTlGT09iZDhDelZ2TmVOL3Qxdm1tVG9qYTZGcjBEcVBPR0lV?=
 =?utf-8?B?eldUNWRtSWNicENhY0hHb3Jsb2liVDVucVFyTlJQYlEwK1ljVzJtMTc2ZzFh?=
 =?utf-8?B?TE5tYW5rZVBmV1JzSVBLVlBVMlMva2M0TzRtcGNUWFRCVURBeEovU2ZQR2RV?=
 =?utf-8?B?UWZyWldIeHk5aDBEZEIxRFdRb1BPaC9JWTQvWUtGbi8wMUZOblM3dzJXSnZr?=
 =?utf-8?B?cUl3T1JkcGNid0hOYUFGQUdYNU9MY29BTmNWbER6OFUvNm1lbmpVWGRMVFp3?=
 =?utf-8?B?cG1MQkNpT25aTHpUT1l4NlNvblhtajZpajBUSEtGM3FkSGJLT1h5MnRHd3pP?=
 =?utf-8?B?Qk9nUnhXaWhaaytJSk9LQ0prY0lmTXZ1UlAyeExNSnpHaGpTSGN4dGc0WFAr?=
 =?utf-8?B?V0c1K2N3U2FKeWl1RFdvNFJoK1ZOSGEyZGMrL1FlQVkzVC94NHowRzZRZmFn?=
 =?utf-8?B?YnZUSm5jZDZ0TEcwcWREMmxOa3dXUURmbmR6SkJPMnpzajVFZDdtQzFIN3Jh?=
 =?utf-8?B?N2Y0dCt5RHZPcHNWUkxmZUR6OFRQSHJaNFdSRThuZTJ2TlEwQlFHN0NJQU1p?=
 =?utf-8?B?c2xMMmRIaHg3M1RYUklmZXh4ZVI4NnUzMkpNUUZMR0N6YndRSmdJMlI0OCtY?=
 =?utf-8?B?aUJNVEMwWHJWclRUdFVrQWFTNVhGYnBvZ3RLU1FzVks5VmJtMmNTTXFZMDA3?=
 =?utf-8?B?OXBzb3BONmNhVDE4MUIrWkZTM2x3QXV4ZTRiZXNPNm5LM1hvRmZXVFZjdmZi?=
 =?utf-8?B?Y0pXWjloM3JydEw5bTlXSjF0R2QwV3B0cTZTNXU5bnE0TTl4V3E0bWxjdXpl?=
 =?utf-8?B?a2c9PQ==?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6683ac54-465b-407f-dd0e-08dc80ed9420
X-MS-Exchange-CrossTenant-AuthSource: BY5PR12MB4130.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 May 2024 21:15:06.1339
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: mScYNzIzwPy2XcCF/IEACiRpzS23ZfZ/irx2CV7cIh1CcKUeoagIVY5Ue1g7iAn6WEOS9VcuYlxPb2aGSdI+CQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR12MB7906

On 5/30/24 2:12 PM, Shuah Khan wrote:
> On 5/30/24 13:13, John Hubbard wrote:
>> On 5/30/24 12:03 PM, Shuah Khan wrote:
>>> On 5/28/24 20:29, John Hubbard wrote:
>>>> The .PHONY targets "all" and "clean"  are both defined in the file that
>>>> is included in the very next line: ../lib.mk.
>>>>
>>>
>>> What problems are you seeing without this patch?
>>
>> Code duplication. It's a sin. :)
> 
> Please mention that you are removing duplicate code.
> 
> futex Makefile overrides CLEAN - just making sure it

(Overrides of Makefile things are per-item, so to speak, not per
file, just to be clear.)

> does the cleanup correctly.
> 

OK sure, I'll update the commit message and post a v3, coming soon.


thanks,
-- 
John Hubbard
NVIDIA