Received-SPF: pass (google.com: domain of linux-kernel+bounces-195959-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Thu, 30 May 2024 22:55:03 +0100
From: Conor Dooley <conor@kernel.org>
To: Palmer Dabbelt <palmer@dabbelt.com>
Cc: andy.chiu@sifive.com, Paul Walmsley <paul.walmsley@sifive.com>,
	aou@eecs.berkeley.edu, Conor Dooley <conor.dooley@microchip.com>,
	Heiko Stuebner <heiko@sntech.de>, guoren@kernel.org,
	robh@kernel.org, krzysztof.kozlowski+dt@linaro.org, corbet@lwn.net,
	Evan Green <evan@rivosinc.com>, cleger@rivosinc.com,
	shuah@kernel.org, linux-riscv@lists.infradead.org,
	linux-kernel@vger.kernel.org, vincent.chen@sifive.com,
	greentime.hu@sifive.com, devicetree@vger.kernel.org,
	linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org
Subject: Re: [PATCH v5 6/8] riscv: hwprobe: add zve Vector subextensions into
 hwprobe interface
Message-ID: <20240530-daylong-pelican-74ccadb9811f@spud>
References: <20240510-zve-detection-v5-6-0711bdd26c12@sifive.com>
 <mhng-0679629d-d115-44ae-a33a-bf42980c7686@palmer-ri-x1c9a>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="54amDOCv5zaovVhC"
Content-Disposition: inline
In-Reply-To: <mhng-0679629d-d115-44ae-a33a-bf42980c7686@palmer-ri-x1c9a>


--54amDOCv5zaovVhC
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, May 30, 2024 at 02:35:51PM -0700, Palmer Dabbelt wrote:
> On Thu, 09 May 2024 09:26:56 PDT (-0700), andy.chiu@sifive.com wrote:
> > diff --git a/arch/riscv/kernel/sys_hwprobe.c b/arch/riscv/kernel/sys_hw=
probe.c
> > index 969ef3d59dbe..35390b4a5a17 100644
> > --- a/arch/riscv/kernel/sys_hwprobe.c
> > +++ b/arch/riscv/kernel/sys_hwprobe.c
> > @@ -114,6 +114,11 @@ static void hwprobe_isa_ext0(struct riscv_hwprobe =
*pair,
> >  		EXT_KEY(ZIHINTPAUSE);
> >=20
> >  		if (has_vector()) {
> > +			EXT_KEY(ZVE32X);
> > +			EXT_KEY(ZVE32F);
> > +			EXT_KEY(ZVE64X);
> > +			EXT_KEY(ZVE64F);
> > +			EXT_KEY(ZVE64D);
> >  			EXT_KEY(ZVBB);
> >  			EXT_KEY(ZVBC);
> >  			EXT_KEY(ZVKB);
>=20
> Conor left a comment over here <https://lore.kernel.org/all/20240510-zve-=
detection-v5-6-0711bdd26c12@sifive.com/>.

This link is to the patch you're replying to, not anything from me.
I commented on a bunch of stuff in v4, but not this patch - generally I
ignore hwprobe to be honest...

> I think the best bet is to just merge this v5 on for-next now, though --
> there's a bunch of patch sets touching ISA string parsing and IIUC that
> sub-extension parsing stuff is a pre-existing issue, and Clement's patch =
set
> still has some outstanding feedback to address.
>=20
> So I think if we just go with this we're not regressing anything, we just
> have a bit more to clean up.  Maybe it's a little uglier now that userspa=
ce
> can see the sub-extensions, but I'd bet wacky ISA strings will be able to
> confuse us for a while.

I wanna do some cleanup stuff w/ Clements series applied, if that's what
you were talking about, but I don't see much point starting that until
the cpufeature stuff has calmed down - Charlie's and Clement's series
really need to be in for-next for it to be worth doing.

> I staged this so I can throw it at the tester, LMK if anyone has issues
> otherwise it'll show up on for-next.

--54amDOCv5zaovVhC
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZlj1twAKCRB4tDGHoIJi
0m7+AQCuLCvXdrPloK2ge546WprTaktc5AJayKqwle2CbRg+qAEAimwmspM+d7gX
w2SCZjy28pKq6A7bDCxZ9Jlu+kWWdwM=
=N8Bg
-----END PGP SIGNATURE-----

--54amDOCv5zaovVhC--