Received-SPF: pass (google.com: domain of linux-kernel+bounces-195967-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <74b2fb73-3047-462f-9053-9d0eece68cbc@amd.com>
Date: Thu, 30 May 2024 17:17:56 -0500
User-Agent: Mozilla Thunderbird Beta
Subject: Re: [PATCH] mailbox: zynqmp-ipi: drop irq_to_desc() call
To: Arnd Bergmann <arnd@kernel.org>, Jassi Brar <jassisinghbrar@gmail.com>,
 Michal Simek <michal.simek@amd.com>, Saeed Nowshadi <saeed.nowshadi@amd.com>
Cc: Arnd Bergmann <arnd@arndb.de>, Ben Levinsky <ben.levinsky@amd.com>,
 "Gustavo A. R. Silva" <gustavoars@kernel.org>, Rob Herring
 <robh@kernel.org>, =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig?=
 <u.kleine-koenig@pengutronix.de>, linux-kernel@vger.kernel.org,
 linux-arm-kernel@lists.infradead.org
References: <20240528120246.3313723-1-arnd@kernel.org>
Content-Language: en-US
From: Tanmay Shah <tanmay.shah@amd.com>
In-Reply-To: <20240528120246.3313723-1-arnd@kernel.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?S0g2OTNsSUFWYVJyd0piRjBWczdTVkVsNmpwRGZma1dDbTRJdDk4cFplUlBB?=
 =?utf-8?B?WHZoc3hDeWRhNnN1alJZUDJRUmdHZGthWDBlRmVoaXZ4YjA5NndiWkpNUS9l?=
 =?utf-8?B?STBFVm5WTzN5T2lmTFl4WXI1WGhrWjhkeDh4UHdvZ3pSbHJOL1ZnYktraWhZ?=
 =?utf-8?B?Y0FYLytLZGFZNktTYUJXYUhkQ2JLazBURnlIYTBGRXpEWGlMNnpuYnhPeUd2?=
 =?utf-8?B?VTFlZVdaVkFhZkhLZ1krbi9RYmc0ektWbmsxTk5WYjNZd3J2Qm8wdjFoZ1cr?=
 =?utf-8?B?eXZkY3RMelo1NGJFdmRQOUN4SW5WeGhyN2hLRG13NHdzem50SlJIb21TUHdC?=
 =?utf-8?B?T01JYll1eW13OXdkL2V1Z1ZXdkM1M2tNWE4wVkhncWFRUmkyUy9PMUtNNUdr?=
 =?utf-8?B?dGQxMUN5Q0c0QjZMMVk4amFPQUh5QzFGYXB2cTZBTkJPaXIyQnpTOFlGM3NK?=
 =?utf-8?B?TmcrWW1GSjlZbHVJaWhXSVg1Z2ZCWENvWW10b1FFQ01ESUpveVI5L2N0WkxW?=
 =?utf-8?B?MGJkNHo1dVdZMFR3REhQUUxwQzZjMkxYTERvdjJFbWZHTVY4V3QwT2JFcnhG?=
 =?utf-8?B?cEdwTjhLRVZkWTdhWkJEZ2JVam1aV0cwZlhnaWJVRGlHWUtuUlRMd0M2MUZO?=
 =?utf-8?B?Y2IzdjJ1VTFEZzA1d1FSVjRVZmkwRU82ODRXd1BjS20vMjJzanlxeXNUN3BJ?=
 =?utf-8?B?d0JjWlh4MUpTYWZnSFQ3SFV3MWJGQ2JVWnFsUnBuSkRkTDJYYUo1R1p1QnhW?=
 =?utf-8?B?WnVuNHlrT20waXhzTDBDVzFQdTYvbWhlbEZYOWxuOFlidEovK2h2Yk9hbDU2?=
 =?utf-8?B?akhnWWZEZXphVkZJcS8yejh0YXNXVzRPaDFpL081QmUraDFsT25WYnA3cGc5?=
 =?utf-8?B?L2FlOEZKV0xzV3J4TjFzK3RLc1k4OS9JbjYwUWhpeHd5TmFCbEpnVTZudzhN?=
 =?utf-8?B?OFpOMVN5NWYwNnhPV3h0dnJNQzRmTUF1N1ZaWmhHQjdrR1R3WUJQeWI1aFR0?=
 =?utf-8?B?YnZackdDb21KMVk1NnpIOG90dnlLOUtuT3VKYUNSK1RacnA3T1ovZ0tXNVhM?=
 =?utf-8?B?NW1JQlFuc2NEdnovK0N1RDcwSjRBTERXYllWVXBFaGlEZmc1VTV6TGxKVmxV?=
 =?utf-8?B?Rk4wSXhNWkRVejMyYkVsUmg2eW5QQmhBL0hTU1gzaVpkZEt0VGFycHV4WXRB?=
 =?utf-8?B?Q3laV2tkb2g2N3VQZ0NRYmhsamYxOEx1K3R6M2svZnNYRzlUNVczUUYweUJF?=
 =?utf-8?B?QUxUUFFFZXVJTWUxOG5jVE85VVlRdU9VNndyYXFXZ0lZcHh2VlJSOTR6M3ow?=
 =?utf-8?B?MDJqK2VGZ0RmRHBwRlpkWmhTTis5R0lpMWVFc2dRRXQwa0VmZXBGSUU0c3Yv?=
 =?utf-8?B?MFgwckFocjZyVTY1V0UvRkRGUStDMGtLZHFtaTBLd0w0MGQvd2plaXpvMnRv?=
 =?utf-8?B?b1BmTWxtQVdUeXFSVEJ6eHJ1bkJBclNrVTdScUh6L3BCdWFXRlRKYiswSFRv?=
 =?utf-8?B?MkdjcWVsc1R2cWJNM1F1Z3poN2NDOHA5K2FMYUNDN0ZER29sbjA3cUl1TjBw?=
 =?utf-8?B?cUxzWHhLVURsV2ttNzhOSDkwc1JKRWdwb0d5QUZtbDN2OTlTa3FSak9Cdkc1?=
 =?utf-8?B?MDF6K1M5Ui9PM09zVFVKTWFsVjkwbkNudEdjWi9haWhZT2tMeWdlZHdnTzZS?=
 =?utf-8?B?QnpKLzFGb29aRHRraUdReHhqR09nSVdhQnExQ2NiMDdaenBHZm9NN1FnY3Vn?=
 =?utf-8?B?QytCNk5XNnRxenJBWnRrYlpkRExsMVM3YWpIamprZTEzcFlaeHZXdHlqZGM3?=
 =?utf-8?B?U0pkVzJUNW5hTnpsUlFyTWZyREg4TllzUHNmZHNvZytadDVleWtPUk5zemFH?=
 =?utf-8?B?cUxHTG5ZcU10Sm9kTVpvenZZZ1RmN2k3aHhrS1o3TEw5MUdPdFBRVFAvSzht?=
 =?utf-8?B?VXlmU0FFMldnSXBxNm9BWG0xMWtWS3dDVlhnZGFWditwdEJJOXFNNFc2dTdM?=
 =?utf-8?B?WnovT0pxemladkFuZlByWllXZFhIaHNmRWRNM0lCRUZFSEdESXU4Z3FOYUUy?=
 =?utf-8?B?c2docWRqbUhPdDBVT3Y3cTJZNS9qbFBKMjJRM0tSaDkzSUorb1lySjVLZWkx?=
 =?utf-8?Q?Wet6ZGaog0ynoKGFaVTPUgbAv?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 908e2e0b-d115-40f9-63b0-08dc80f65ce8
X-MS-Exchange-CrossTenant-AuthSource: BL1PR12MB5874.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 May 2024 22:17:58.9902
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: wcSAG38Qjn1avvmA+c2Duqi5N9HeXf65nwdUmVya7xMW7SHFjpIYw0sM9NrOiLej
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB7282

Tested-by: Tanmay Shah <tanmay.shah@amd.com>


On 5/28/24 7:02 AM, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> irq_to_desc() is not exported to loadable modules, so this driver now
> fails to link in some configurations:
> 
> ERROR: modpost: "irq_to_desc" [drivers/mailbox/zynqmp-ipi-mailbox.ko] undefined!
> 
> I can't see a purpose for this call, since the return value is unused
> and probably left over from some code refactoring.
> 
> Address the link failure by just removing the line.
> 
> Fixes: 6ffb1635341b ("mailbox: zynqmp: handle SGI for shared IPI")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  drivers/mailbox/zynqmp-ipi-mailbox.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/mailbox/zynqmp-ipi-mailbox.c b/drivers/mailbox/zynqmp-ipi-mailbox.c
> index 7c90bac3de21..4acf5612487c 100644
> --- a/drivers/mailbox/zynqmp-ipi-mailbox.c
> +++ b/drivers/mailbox/zynqmp-ipi-mailbox.c
> @@ -850,7 +850,6 @@ static int xlnx_mbox_init_sgi(struct platform_device *pdev,
>  		return ret;
>  	}
>  
> -	irq_to_desc(pdata->virq_sgi);
>  	irq_set_status_flags(pdata->virq_sgi, IRQ_PER_CPU);
>  
>  	/* Setup function for the CPU hot-plug cases */