Received-SPF: pass (google.com: domain of linux-kernel+bounces-196011-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <9a72eaf6-d750-4898-be75-6c27512750b1@intel.com>
Date: Thu, 30 May 2024 16:10:04 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v19 00/20] Add support for Sub-NUMA cluster (SNC) systems
To: "Luck, Tony" <tony.luck@intel.com>
CC: "Yu, Fenghua" <fenghua.yu@intel.com>, "Wieczor-Retman, Maciej"
	<maciej.wieczor-retman@intel.com>, Peter Newman <peternewman@google.com>,
	James Morse <james.morse@arm.com>, Babu Moger <babu.moger@amd.com>, "Drew
 Fustini" <dfustini@baylibre.com>, Dave Martin <Dave.Martin@arm.com>,
	"x86@kernel.org" <x86@kernel.org>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>, "patches@lists.linux.dev"
	<patches@lists.linux.dev>
References: <20240528222006.58283-1-tony.luck@intel.com>
 <08ca8fe7-9da6-41da-aad2-0081b789326c@intel.com>
 <ZleODtL_6D-Q_OMX@agluck-desk3.sc.intel.com>
 <a4d37f57-328f-4456-92bc-5e6469d092c8@intel.com>
 <ZlirIUbLw8fLHe0j@agluck-desk3.sc.intel.com>
 <2a761266-e934-4740-bf15-95dbfe4e4d5d@intel.com>
 <SJ1PR11MB60836D413A87A0351ABD90A2FCF32@SJ1PR11MB6083.namprd11.prod.outlook.com>
Content-Language: en-US
From: Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <SJ1PR11MB60836D413A87A0351ABD90A2FCF32@SJ1PR11MB6083.namprd11.prod.outlook.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NHY4SVBRRlRKUmNkZWVrNnpkRHNMc1hKZzJwd3c3RzVHc1dEVitRdzk5K01o?=
 =?utf-8?B?UDhMT3QzV2xIeFNLcTJpTnY4ZlJ6VXduQXJ6S1Fyb2VPYlBuOWdySi9yVlFx?=
 =?utf-8?B?a2RMY213cm9rOEhHK0huMSt1SUJUVCtvNElUVHBhL0dlZXlEZW5YS1E2dEww?=
 =?utf-8?B?SENzY0hST2ozTmpCNGxLMkZST2Q2c2RzOUI1amdXek5hS01BMzdEVHppaWho?=
 =?utf-8?B?SC96K3lraFBGV2NRV2JyT0NKM3lPeFlCN2dWZHRWTTZ6UW5TeWtXdllUUTJY?=
 =?utf-8?B?N052SjI0MmFEV2xUeGhUalBENVhJdFloUUw5eEtibVRlWXhtTS9tUktnbi8v?=
 =?utf-8?B?bXZWOWdWLzJ1aGk4ck9qS0krWmJRaXAwd0R2MGphcXpuUzBMNFB0Z2p1QS93?=
 =?utf-8?B?MVFURldNcWpnT0tOcWJ1RXFYUkZWbTBQM1JwT0t5OGticXBLTnA2NDJycFNk?=
 =?utf-8?B?Zno1N1BnZzFwWGtIbks5L2VWNU9LVmJCcWI1Z0ZMSkI4RjN3ZWtlRUhoKzFi?=
 =?utf-8?B?bnBtTVVscmVlMlpDdWlWRGpINEE5Y0N5SDBOZ3JiaXRhS1Q4Q1VMc2JUdk1L?=
 =?utf-8?B?OVRTZDIxT09OazZLemJ0dlQrcWh6NUI3SjRKd2o5WWZ0RjUya3FRRTdQbkxk?=
 =?utf-8?B?ZXBMTUtaWHcyVjZ4dGprOWJMMGU5dGRndFAwT05rTlduV0lLeG1pMWQ5TDY5?=
 =?utf-8?B?YlhJSDduY3A4SmF2UVpGUlZMcTl4dTA1SDlQQWlaSlMydVo5VExxOTJlVnFk?=
 =?utf-8?B?aE5ldGppM0IvcGxwZWNFUmtPazZJTkhheEFqam1GNk5vMkNocmF3dWxRdURh?=
 =?utf-8?B?b08xTzhBZ0kxaGF3ZFk4cWNweEdtVTdZQW1lcUFUakZpUlMwWDFJeDJNWC94?=
 =?utf-8?B?Q2xEblNNS2I0SGY1OVYrTUl5eXQ1RjNxTUxBT0ticmxXOWJzTEZKeTljS0tw?=
 =?utf-8?B?aXFtQmpiK3p5MEtsWFNxL2FVaUdDK1JGUm5waVRsWDhQdHBRVzVwbWxaOU1S?=
 =?utf-8?B?MjAwK1Zab1E1VTJReDJmTlI5WUlEU3B5U3diaTNkY3QweUJUL1NQZlpZRnVh?=
 =?utf-8?B?T1lPLzFnMGhXcXVpOW10TllncU00cS92bnVjNWlwYzExakFGVmNtUTVKemsr?=
 =?utf-8?B?czhaM1h2U0xyb0NyVDNCV2NsSTJkN29MSC9QV280V2J2d1dtZ1IyalNHTzc4?=
 =?utf-8?B?bGxJMjR3MVFmandhYlNVcGlGTE1OSFhLbTN0akdUZk44OHhWTU5jenlhMWF0?=
 =?utf-8?B?dEJid3QzR0tRcGV2NU9tWG1Rc0NGeGdVQkVhcnhYNUlHZytlb0VtVE1jWGJ1?=
 =?utf-8?B?bUZwWjQvMWRXS1JWeTVEQ21tdk5sWHB0MTN6R0wzaU4vcTlpUUd5V0JObm1G?=
 =?utf-8?B?SU5wa2F1eGtxcDFNVkNTdEd4UTdWM2FVSlVwYmNnSkpxOWovNjNQVE0yZ3kv?=
 =?utf-8?B?dCtOVzNYV045dE1Hc0QxN0Z3aUFNY2tYRVNKTVY5S0dtL3pDN2RiRm1oUXZX?=
 =?utf-8?B?eVprYkFxRFBsTEhBNE1MY0dqUzIwc1BOdTBHa3YrbmJLQ2UxOG10V2NNcTBD?=
 =?utf-8?B?emd0cDhWTEV3dnl2R0UxMUZQU2Q2T0RrRGJSNFhQY0NDT25aNDROVDhvUjNp?=
 =?utf-8?B?YnVEZVNoNXhSZlZMbFpDZFJUMFZIa2x2Y01rTkdLdytNT1BXR0NBK3Z2eEFG?=
 =?utf-8?B?ZjBBdnpOaHFpZzlmeTQ0ZC9oOWdNdFJSWVJWNVRqaWZJS1JjVEtUUkdWc1BZ?=
 =?utf-8?B?UDRTTVh4OVNIVnVvNUpJK0dmemxKQ04wa3lFQ3M4R1MxL1lhTVhYbkhnakRm?=
 =?utf-8?B?NEJ6SDFLa2JrVkV0ZUJqWVBqZU1UN2d5VjBIZVdZdjVnQ3lYc2xpWkJlb3Ra?=
 =?utf-8?B?cHlobERic1VVaWhiSTR4WjQxSWFmamxDVmNQQTJyb04zaDlnYW1FTStoZUNs?=
 =?utf-8?B?MlM0aS9kblRiRVByUjNoUzZzVzBmUk9nWTY4NmpseER0NTdLOWc0SkhkZkhP?=
 =?utf-8?B?NTRjUFE5VWIzRCt4bVZ2SThQejY2SVY2dExYUElEaTBGcTdiS3RvMHhaUHRI?=
 =?utf-8?B?Q2piVTRvQVVYQUlnK3hCOUtiZ1dsdDJUSXpHb250UCtZSm5GMDh1cGlXSGc3?=
 =?utf-8?B?RFBJZGZqY1dOb3VkS3BQalh3R2hJNy9uNzR1L3BnZHhEZXFjYnRUaG54U2VS?=
 =?utf-8?B?YkE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 1a5fba92-fd31-4322-dda7-08dc80fda588
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 May 2024 23:10:07.3033
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 3fpNMA5DSe7XbqfQtErFr5xkOZE4fqs8wsrWd5C2lKHKGsK5GzQpkLQC2bf00nOK6qGoF16NFMQuJUUphR7Xc/IKfW2NwBJXDHZ8uyaiwhM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4981
X-OriginatorOrg: intel.com

Hi Tony,

On 5/30/24 3:49 PM, Luck, Tony wrote:
>> btw ... the static checker I ran did have four other complaints, three about
>> uninitialized data and one about divide by zero. Most problems appear to be
>> in mbm_update() that does not initialize rr.sumdomains nor rr.ci before
>> calling __mon_event_count().
>>
>> Please use available tools to check code before posting.
> 
> Which static checker?  I tried smatch and it only finds one:

I used coverity this time.

Reinette