Received-SPF: pass (google.com: domain of linux-kernel+bounces-196008-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <9fa47acf-86b1-4602-8790-39ed80fd775a@intel.com>
Date: Thu, 30 May 2024 16:07:29 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 1/2] selftests/resctrl: Adjust effective L3 cache size
 with SNC enabled
To: Maciej Wieczor-Retman <maciej.wieczor-retman@intel.com>,
	<fenghua.yu@intel.com>, <shuah@kernel.org>
CC: <linux-kselftest@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<ilpo.jarvinen@linux.intel.com>, <tony.luck@intel.com>
References: <cover.1715769576.git.maciej.wieczor-retman@intel.com>
 <fe9295c6be677d187b1607185e23993dbfe74761.1715769576.git.maciej.wieczor-retman@intel.com>
Content-Language: en-US
From: Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <fe9295c6be677d187b1607185e23993dbfe74761.1715769576.git.maciej.wieczor-retman@intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?d0d4bkFVRERCbFp5RURsWWVJNEdXNkE4NTJMZDJQZ1M4aENSRTJqOFJ4TmJa?=
 =?utf-8?B?VU1uWjcrZmhMejNkNmFrMTBaeU9RQ0hxelNIcTFEdXdYamg3OWJmVk1sK1o1?=
 =?utf-8?B?dVFkanY0TC9QVUpXcW1QanFDMUsxM244Q0lIRE5oeW43K1owVFcwbjNRVXhN?=
 =?utf-8?B?cmRKV1JuVGFxd2lXb2lwUzF5TGpPZGNhV1QxT3o5UExzWVpsS1YyUEZKT3VJ?=
 =?utf-8?B?YXJ1c2k4Unl3d05FSGpHcjVNNHFDUkRLNE5rczhwcGw1eGluMmxFRnJxdlJa?=
 =?utf-8?B?cWx3c3RTS1pZL2ZxeGxWS01TMVdvTXdDM3NYNDZwR2c0TWJmdnQyNFhlOXkx?=
 =?utf-8?B?Zkdzbys0MlM5WXpETUE3U1IzeEdRdGJMejlmRjZOOC9mYVhrL1dhOTVzcm5D?=
 =?utf-8?B?b1N4WC9wSHdrM0lyaFd3My9LTWJzMUJZQUUzL1B4amg3dldOSWlGcFdTU3pl?=
 =?utf-8?B?UVYwQXJiQnJwYlNteE11R0R2MW0vcDNZb2hMU29FQ2krUlBlQk1TZ0E5eXJv?=
 =?utf-8?B?ZXlDeTZ6MVpiZmRJQ2EzU0s1bVIvWmRTbzRkKzdHYVBkOS9nZFpKQ1JZNndj?=
 =?utf-8?B?NTNFVndON05DZzBiY0p0ei91SGU3QmNaMVJvZFkrS2dkWVlNRDhkbUpaOTFw?=
 =?utf-8?B?UnhrVkdWTHFMTGFGaHR5ZkZhV3J6L3BYcUdsS3dyOWxiaGtKSXlpSlNsQXZH?=
 =?utf-8?B?cXJoMUszTzZ1dm1oRUF2ZjZWNDRUeUdZR1NFaU5yWWp1Slhaajc3TG1NYkJp?=
 =?utf-8?B?MnowM042cjJCMFdLclFjZVlNWUR4VklYNlBxdzhzMVlZeVZEQXVZK1piQm8r?=
 =?utf-8?B?WVRXQjRhMVpCQmdvVzJnMFRmd0IrZlQ1S2IraHNsd003OHBwQ0I3d2pHM255?=
 =?utf-8?B?THIyK0haZEd2VEU3RHdPZUtkbVV5QnRpaUViWjRDbjJxVDBoNzBOKy9KWUU1?=
 =?utf-8?B?cm4rZXpsUlViTGF2WHFDdW1CSHhKV1VSb01yWWRWbUpDMTU2OEM3ZjBtRTZY?=
 =?utf-8?B?MXRscnYybTNkSXZGcXRmOWJXaXdqU1hPbkVKb2VxeWYrQUJ1TUlkVGpuT1Rr?=
 =?utf-8?B?UVlFTGREMWpxeDEreFRweTIrSDlMTmE1YWtQTnB6US9ZUmxUalFzdDRsams5?=
 =?utf-8?B?Z3V1YTl2SStMRDlVYnNNd1gwOWtnVHg5bHJCOTVvSnRFcU5pV3RZREI2QVhT?=
 =?utf-8?B?TkREa0dzeDhuTVBwUGl1MW1rakZJcnMzdDR4U1J6dys3bi9yOG1OY2p4KzMv?=
 =?utf-8?B?K2dnbm1nYSticWh2SDEwa3JDYnpHRlJMNkM5djc0blFlWlBycCtwL1dmOGtJ?=
 =?utf-8?B?MTBHME9RaUQzWTN2ZUNOWXVLSzhRZzhDcDBPYytYLzJQTkhBL3R2TFVYYTRR?=
 =?utf-8?B?ZkZQY0xhZndtR3pWdFdJcXRESi82Wnd5bzQrMUIrcjZVVmg4a0U5R0ZiOEFK?=
 =?utf-8?B?NWVFL3UvYlo3RG9DdEkvTTNTTlAxeWhhNHNQRXJ3Ukp6K0RCVEdzWHliaVF4?=
 =?utf-8?B?YzZ3L1NvTnhHSVFRbkhOWWJXeEZldjZiNHAzTVFZSlVydkZLaGFBdXIzd0Zx?=
 =?utf-8?B?VVQ0VVBIZGJ6U2hYc01zZWw2SldtdE84Q3VFdWJRRGxmamNsWDJvY0NmSzl2?=
 =?utf-8?B?Qm9mVnRtUUpuTFFjQ1VSRGtudHk3QWxzbTBxeUltblhETEI4QUZPelNCc0hX?=
 =?utf-8?B?QTJ4NzJuZFV3VEc3S3NiMWUwdXJWRFlZbkZzWkhhbTI4L2l0a2lVT1lCeW0v?=
 =?utf-8?B?NDgzWXFaT3RBSnllc0RFMHIzQ2pwWUw0QVk4MFlXcWNFczdqWGZYR3N0RXEw?=
 =?utf-8?B?bTNEbnB1ZmhMeXUzV2RtOFRBVkM1UU5ZM0t5cGJiaUxSbVNsdzBiaGNMd1lU?=
 =?utf-8?B?QVBVeGhlSFM5cGtQazFMV25ncW1LMnB3SERseTRTUzlpeWNFdGMydDFKVmVj?=
 =?utf-8?B?QU9QUmJQVExST2xpdWxFSFk3dGhGWE4zano2NkxXVXhvbWloSUpsVGxDdGNh?=
 =?utf-8?B?K05kL1pUQmM5RWI5amo2R3NsL3ZLejhsYmMvSmJacUF1ajVjQVFuRlhCU3RD?=
 =?utf-8?B?em9FdmREME9iOVFPem9XL25MaU9QckZEUFVvNTdneEdBblVIcmRkL2UxSmp6?=
 =?utf-8?B?T0NNN3EvUjFKaVNvSTdFRE16Z3BEbXdydk44YWRIZzJFb0RSQ3lJZnVqUVl2?=
 =?utf-8?B?eWc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: f84c6022-bd74-4648-9b9b-08dc80fd4873
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 May 2024 23:07:31.1873
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: RW5vQX8CDMiKD9F2Qe4LvG+ziYrWjo1C+sxNX74SoXz1p0ugrxLP8zdk6JzkunS+D/vOHKx81JWKiGq52Xuh8D/xXbamQVPlHZ0MENuO2oE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR11MB7833
X-OriginatorOrg: intel.com

Hi Maciej,

Regarding shortlog: L3 cache size should no longer be adjusted when
SNC is enabled. You mention that the tests are passing when running
with this adjustment ... I think that this may be because the test
now just runs on a smaller portion of the cache?

On 5/15/24 4:18 AM, Maciej Wieczor-Retman wrote:
> Sub-NUMA Cluster divides CPUs sharing an L3 cache into separate NUMA
> nodes. Systems may support splitting into either two or four nodes.

fyi ... from the most recent kernel submission 2, 3, or 4 nodes
are possible:
https://lore.kernel.org/lkml/20240528222006.58283-20-tony.luck@intel.com/

> 
> When SNC mode is enabled the effective amount of L3 cache available
> for allocation is divided by the number of nodes per L3.

This was a mistake in original implementation and no longer done.

> 
> Detect which SNC mode is active by comparing the number of CPUs
> that share a cache with CPU0, with the number of CPUs on node0.
> 
> Signed-off-by: Tony Luck <tony.luck@intel.com>
> Co-developed-by: Maciej Wieczor-Retman <maciej.wieczor-retman@intel.com>
> Signed-off-by: Maciej Wieczor-Retman <maciej.wieczor-retman@intel.com>
> ---
>   tools/testing/selftests/resctrl/resctrl.h   |  3 ++
>   tools/testing/selftests/resctrl/resctrlfs.c | 59 +++++++++++++++++++++
>   2 files changed, 62 insertions(+)
> 
> diff --git a/tools/testing/selftests/resctrl/resctrl.h b/tools/testing/selftests/resctrl/resctrl.h
> index 00d51fa7531c..3dd5d6779786 100644
> --- a/tools/testing/selftests/resctrl/resctrl.h
> +++ b/tools/testing/selftests/resctrl/resctrl.h
> @@ -11,6 +11,7 @@
>   #include <signal.h>
>   #include <dirent.h>
>   #include <stdbool.h>
> +#include <ctype.h>
>   #include <sys/stat.h>
>   #include <sys/ioctl.h>
>   #include <sys/mount.h>
> @@ -49,6 +50,7 @@
>   		umount_resctrlfs();		\
>   		exit(EXIT_FAILURE);		\
>   	} while (0)
> +#define MAX_SNC		4
>   
>   /*
>    * user_params:		User supplied parameters
> @@ -131,6 +133,7 @@ extern pid_t bm_pid, ppid;
>   
>   extern char llc_occup_path[1024];
>   
> +int snc_ways(void);
>   int get_vendor(void);
>   bool check_resctrlfs_support(void);
>   int filter_dmesg(void);
> diff --git a/tools/testing/selftests/resctrl/resctrlfs.c b/tools/testing/selftests/resctrl/resctrlfs.c
> index 1cade75176eb..e4d3624a8817 100644
> --- a/tools/testing/selftests/resctrl/resctrlfs.c
> +++ b/tools/testing/selftests/resctrl/resctrlfs.c
> @@ -156,6 +156,63 @@ int get_domain_id(const char *resource, int cpu_no, int *domain_id)
>   	return 0;
>   }
>   
> +/*
> + * Count number of CPUs in a /sys bit map
> + */
> +static unsigned int count_sys_bitmap_bits(char *name)
> +{
> +	FILE *fp = fopen(name, "r");
> +	int count = 0, c;
> +
> +	if (!fp)
> +		return 0;
> +
> +	while ((c = fgetc(fp)) != EOF) {
> +		if (!isxdigit(c))
> +			continue;
> +		switch (c) {
> +		case 'f':
> +			count++;
> +		case '7': case 'b': case 'd': case 'e':
> +			count++;
> +		case '3': case '5': case '6': case '9': case 'a': case 'c':
> +			count++;
> +		case '1': case '2': case '4': case '8':
> +			count++;
> +		}
> +	}
> +	fclose(fp);
> +
> +	return count;
> +}
> +
> +/*
> + * Detect SNC by comparing #CPUs in node0 with #CPUs sharing LLC with CPU0.
> + * If some CPUs are offline the numbers may not be exact multiples of each
> + * other. Any offline CPUs on node0 will be also gone from shared_cpu_map of
> + * CPU0 but offline CPUs from other nodes will only make the cache_cpus value
> + * lower. Still try to get the ratio right by preventing the second possibility.
> + */
> +int snc_ways(void)

"ways" have a specific meaning in cache terminology. Perhaps rather something
like "snc_nodes_per_cache()" or even copy the kernel's (which is still WIP though)
snc_nodes_per_l3_cache()

> +{
> +	int node_cpus, cache_cpus, i;
> +
> +	node_cpus = count_sys_bitmap_bits("/sys/devices/system/node/node0/cpumap");
> +	cache_cpus = count_sys_bitmap_bits("/sys/devices/system/cpu/cpu0/cache/index3/shared_cpu_map");
> +
> +	if (!node_cpus || !cache_cpus) {
> +		fprintf(stderr, "Warning could not determine Sub-NUMA Cluster mode\n");

The tests just use "ksft_print_msg()" for error messages. The "Warning could ..."
is somewhat unexpected, perhaps just "Could not determine ..." or "Warning: Could not ..."?

> +		return 1;
> +	}
> +
> +	for (i = 1; i <= MAX_SNC ; i++) {
> +		if (i * node_cpus >= cache_cpus)
> +			return i;
> +	}

This is not obvious to me. From the function comments this seems to address the
scenarios when CPUs from other nodes are offline. It is not clear to me how
this loop addresses this. For example, let's say there are four SNC nodes
associated with a cache and only the node0 CPUs are online. The above would
detect this as "1", not "4", if I read this right?

I wonder if it may not be easier to just follow what the kernel does
(in the new version).
User space can learn the number of online and present CPUs from
/sys/devices/system/cpu/online and /sys/devices/system/cpu/present
respectively. A simple string compare of the contents can be used to
determine if they are identical and a warning can be printed if they are not.
With a warning when accurate detection cannot be done the simple
check will do.

Could you please add an informational message indicating how many SNC nodes
were indeed detected?

> +
> +	return 1;
> +}
> +
>   /*
>    * get_cache_size - Get cache size for a specified CPU
>    * @cpu_no:	CPU number
> @@ -211,6 +268,8 @@ int get_cache_size(int cpu_no, const char *cache_type, unsigned long *cache_size
>   			break;
>   	}
>   
> +	if (cache_num == 3)
> +		*cache_size /= snc_ways();
>   	return 0;
>   }
>   

I think this can be dropped.

Reinette