Received-SPF: pass (google.com: domain of linux-kernel+bounces-196009-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <d8396d97-5000-4ffb-aaba-e71de5d6d909@intel.com>
Date: Thu, 30 May 2024 16:07:34 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 2/2] selftests/resctrl: Adjust SNC support messages
To: Maciej Wieczor-Retman <maciej.wieczor-retman@intel.com>,
	<fenghua.yu@intel.com>, <shuah@kernel.org>
CC: <linux-kselftest@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<ilpo.jarvinen@linux.intel.com>, <tony.luck@intel.com>
References: <cover.1715769576.git.maciej.wieczor-retman@intel.com>
 <16764746e8f9f42cbd45d61210764a9b67085cbf.1715769576.git.maciej.wieczor-retman@intel.com>
From: Reinette Chatre <reinette.chatre@intel.com>
Content-Language: en-US
In-Reply-To: <16764746e8f9f42cbd45d61210764a9b67085cbf.1715769576.git.maciej.wieczor-retman@intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SGpYdWFDVldpMG95anFocjFYVFFVeUE3TTRkZ2hDS3NLOGhoSldkcldGTStm?=
 =?utf-8?B?ZEFXVEdzbjdXKzlYbkhoYjdDWFVJZHpjdU9oak5ES21VQnN5bG8xUks5alJs?=
 =?utf-8?B?aHUyeWltK1ZiY2F4a3ZlTHIxKzFnS2hIT0xnME5ZbUE1NDQxTFdrN0dya3lC?=
 =?utf-8?B?UkIxT0NETG52RHAva1Z4a0FERnN1bEJxN3RZakhENU04bzZ0STFXemI3OWpv?=
 =?utf-8?B?NVdtWENkUEVuLzFKSlhkZzVSbWM1MHVXRUtxVE0ydXh2cldyVDZDUzJ6cWlo?=
 =?utf-8?B?WGVvNW9xNi9aY3ZkWVV6aExkNFpybFRIZHh4dGZiVkZrdDk5MkVxUUxMSTdM?=
 =?utf-8?B?M0JweDZCYjZMVkx4enNOU080MHJIQlBoeExEbHJLci95Z1p1WDExOTZWQjdP?=
 =?utf-8?B?a3A2aGwxczhQUVo5WDQ5VWE4enl6YjdsQTNKN3UrVnJZM3MyUG5JTksvVTF6?=
 =?utf-8?B?RnA2bTd0MkwxaFdGNS9FNGlTcEJReW9zTGxmcnRodzEwQStYTmNKOC9VdWRM?=
 =?utf-8?B?clNOcjlteUE2enRaQVQvc2d1SnJEQzFDL0VBSmUzbDR5OTJJeDF3d3VSS3pw?=
 =?utf-8?B?Um5YNkJxS1gxSERYUEMrUTUyNTBLZndTQ1Zmd2xoTCtCY1Yvdm5SRExsc1V1?=
 =?utf-8?B?YkgycTRPWExUU1QvRTRXeTZ2bkpLZjhqOVZXb1ZrSlczTThqZm1EWkJ1L3U5?=
 =?utf-8?B?K2g3dittUmpBWTVaN25TTnhEeGowODNjUUNoVnpGdEhueHQ3WXR5bGhrN0Jr?=
 =?utf-8?B?M3NnaVMzNlRleHBWa0lXcVYzaEg5UEEwbjBjVUNTRUl1VXV6Y0h2SDgwaGNs?=
 =?utf-8?B?L05aR3RyNGoveHkvYkc2OTlJWmlyM3NtODRtTVNHS3NBTkIweDBySkF5RVlZ?=
 =?utf-8?B?NkQ2aDcyYmhIeEk0d09QYnMvRFZucENDZ1BacmsrQlBUZDlKS3pXbVkyZE1S?=
 =?utf-8?B?a0cwbndWS2t0WmwxU2NZRG9VbGROTGIrdmtLVnpPMGJ1TE5meGVRYWpBSHhM?=
 =?utf-8?B?VWpCSGVEcWdOVUt6OHZrUUpFVmxPU1NsZ1lNTlBYZVFxMTBQenFhWldjOENx?=
 =?utf-8?B?UDJzOERUY005Tm5oS3pnTnVYWTlRZElFTUUyRytCU2RiWHk1ckgxMDZtdVhT?=
 =?utf-8?B?VlkxUU9Hb1JTUWhiTUI2ZlpmNk9XeHJHT2YxNnFVd3hhVU1od24vV1dnZno2?=
 =?utf-8?B?TWRCNU43emU3TVB6WlJuY0QwQVdITi9seFowcUg3OWd6eFVabjF3czRwdHZ0?=
 =?utf-8?B?bUpSdGViZ1lGVHVGMk11NXVhYW5rQWhVaGRZdTNCc3VBc1BsUWc2ZG8rcDVW?=
 =?utf-8?B?VmptVlNUbjB4QlFPZkZ5Zk5McmUrOWVqVDVQTVJHU09tWldqVmh2dDVDb1VW?=
 =?utf-8?B?NGRLNmFGbmREdUFjMjJYYlVUZDlqR2FjTmpyVzY4VWdIRHRwUEg3NE9VNEFE?=
 =?utf-8?B?ODh0Qm12bkZxRmQ0Z1FicnJkWUViOTl3SjlDSXIzUlE5Tk5Bek1hQllsN0RO?=
 =?utf-8?B?VHZnWEN0U2ZVOFpFYjlIVkQ0N0FvcmVQNStjVWNBTTAreGVObk8rLzJES2pr?=
 =?utf-8?B?bHVyTVBUdEt2M2YwMHh6bThldGYwTmYrMFR0dDZqSW8wd3hiUTIyMEordVdO?=
 =?utf-8?B?YzJrK0pBclNSWkk1aytxd0l0NDcvRjhLNk9qN0c0a3p3VnBHclovWWxDYkFk?=
 =?utf-8?B?dnBzSVZWVmRPTWN1c3UxQ1lXY3RuMElZTStraGdZVVpFOXdaaHFzSlVreVYz?=
 =?utf-8?B?UEIvY1FTRldsRTk5Yyt6cE5rOVJTM1RHS25qTTdiNndkeE8veFBWQXpYUU5U?=
 =?utf-8?B?QVd5VWg3K3lTbU83K24rYzRUd3EvYmN1VXhDVDFmbXVscmxuK2hWejdLRFpj?=
 =?utf-8?B?T3lKTEVrbmtXdzBjOWc3NTFTMFd5QnRSVWpIWTFkTHRsajZlVGxIRzYyQytX?=
 =?utf-8?B?SGNIeE1HTVkrUmFSbWIrZitHSGdiSVVlbEVscW90N254RUpZem9LV1ROeTgz?=
 =?utf-8?B?bjg1UUF6MFMvWm05QmFTNFhIY1VONmhWM3VKdEszUXJoNGszMG9pQzd5UzFj?=
 =?utf-8?B?TkJqNUYzbWMyQVp0anVJN0RiVkFORUtwVHhveTRzc2RYZFQ2MXZodXRqdmox?=
 =?utf-8?B?bW5EU3BhMEdDZVk0UHRzaFl2NFZYMEp2VU5iMUExZnA3UGtTT1M0ZHNPRk55?=
 =?utf-8?B?cVE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 2bd6609e-5015-4bf7-7861-08dc80fd4b05
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 May 2024 23:07:35.5352
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: k9xyWej88MvWheBmD/IOeyvQ8iixwkCyUjmb6c+xYG/qko+OVYTVrsnsrJ5VXBZDXFBBvEKaHFJNjtrQuSYFnTwYnJKhgi0Zk+lrGWhHrP0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR11MB7833
X-OriginatorOrg: intel.com

Hi Maciej,

On 5/15/24 4:18 AM, Maciej Wieczor-Retman wrote:
> Resctrl selftest prints a message on test failure that Sub-Numa
> Clustering (SNC) could be enabled and points the user to check theirs BIOS
> settings. No actual check is performed before printing that message so
> it is not very accurate in pinpointing a problem.
> 
> Figuring out if SNC is enabled is only one part of the problem, the
> other being whether the kernel supports it. As there is no easy
> interface that simply states SNC support in the kernel one can find that
> information by comparing L3 cache sizes from different sources. Cache
> size reported by /sys/devices/system/node/node0/cpu0/cache/index3/size
> will always show the full cache size even if it's split by enabled SNC.
> On the other hand /sys/fs/resctrl/size has information about L3 size,
> that with kernel support is adjusted for enabled SNC.
> 
> Add a function to find a cache size from /sys/fs/resctrl/size since
> finding that information from the other source is already implemented.
> 
> Add a function that compares the two cache sizes and use it to make the
> SNC support message more meaningful.

Please note that the new version of SNC kernel support ([1]) that this
series is based on no longer adjusts the cache size. Detecting kernel support
for SNC (if the new solution is accepted) can be done with the test for the
existence of the files Tony mentioned in [2].

> 
> Add the SNC support message just after MBA's check_results() since MBA
> shares code with MBM and also can suffer from enabled SNC if there is no
> support in the kernel.
> 
> Signed-off-by: Maciej Wieczor-Retman <maciej.wieczor-retman@intel.com>
> ---

Reinette

[1] https://lore.kernel.org/all/20240503203325.21512-1-tony.luck@intel.com/
[2] https://lore.kernel.org/lkml/SJ1PR11MB6083320F30DBCBB59574F0BDFCEC2@SJ1PR11MB6083.namprd11.prod.outlook.com/