Received-SPF: pass (google.com: domain of linux-kernel+bounces-196058-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Thu, 30 May 2024 16:53:11 -0700
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Charles Wang <charles.goodix@gmail.com>
Cc: hadess@hadess.net, hdegoede@redhat.com, neil.armstrong@linaro.org,
	hughsient@gmail.com, broonie@kernel.org, jeff@labundy.com,
	linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] Input: goodix-berlin - Add sysfs interface for
 reading and writing touch IC registers
Message-ID: <ZlkRZ7VKNVZSFi0X@google.com>
References: <20240514115135.21410-1-charles.goodix@gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240514115135.21410-1-charles.goodix@gmail.com>

Hi Charles,

On Tue, May 14, 2024 at 07:44:43PM +0800, Charles Wang wrote:
> +static ssize_t registers_read(struct file *filp, struct kobject *kobj,
> +	struct bin_attribute *bin_attr, char *buf, loff_t off, size_t count)
> +{
> +	struct regmap *regmap;
> +	int error;
> +
> +	regmap = dev_get_regmap(kobj_to_dev(kobj), NULL);

We already have goodix_berlin_core->regmap, going through drvdata should
be cheaper than scanning devres resources for the regmap data, so I'll
change this.

> +	error = regmap_raw_read(regmap, (unsigned int)off,
> +				buf, count);
> +
> +	return error ? error : count;
> +}
> +
> +static ssize_t registers_write(struct file *filp, struct kobject *kobj,
> +	struct bin_attribute *bin_attr, char *buf, loff_t off, size_t count)
> +{
> +	struct regmap *regmap;
> +	int error;
> +
> +	regmap = dev_get_regmap(kobj_to_dev(kobj), NULL);
> +	error = regmap_raw_write(regmap, (unsigned int)off,
> +				 buf, count);
> +
> +	return error ? error : count;
> +}
> +
> +BIN_ATTR_RW(registers, 0);

I do not think it is a good idea to allow the world read all registers.
Any objection to make it BIN_ATTR_ADMIN_RW()?

Thanks.

-- 
Dmitry