Received-SPF: pass (google.com: domain of linux-kernel+bounces-196121-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Thu, 30 May 2024 18:09:55 -0700
From: Jakub Kicinski <kuba@kernel.org>
To: Ronak Doshi <ronak.doshi@broadcom.com>
Cc: <netdev@vger.kernel.org>, Broadcom internal kernel review list
 <bcm-kernel-feedback-list@broadcom.com>, "David S. Miller"
 <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, Paolo Abeni
 <pabeni@redhat.com>, open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1 net-next 2/4] vmxnet3: add latency measurement
 support in vmxnet3
Message-ID: <20240530180955.4e542935@kernel.org>
In-Reply-To: <20240528233907.2674-3-ronak.doshi@broadcom.com>
References: <20240528233907.2674-1-ronak.doshi@broadcom.com>
	<20240528233907.2674-3-ronak.doshi@broadcom.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Tue, 28 May 2024 16:39:04 -0700 Ronak Doshi wrote:
> This patch enhances vmxnet3 to support latency measurement.
> This support will help to track the latency in packet processing
> between guest virtual nic driver and host. For this purpose, we
> introduce a new timestamp ring in vmxnet3 which will be per Tx/Rx
> queue. This ring will be used to carry timestamp of the packets
> which will be used to calculate the latency.

How does the user access this functionality?
Please provide more info in the commit msg.

> +	if (VMXNET3_VERSION_GE_9(adapter)) {
> +		adapter->latencyConf = &adapter->tqd_start->tsConf.latencyConf;
> +	}

unnecessary parenthesis, please fix all such cases in this set