Received: by 2002:a05:6500:2018:b0:1fb:9675:f89d with SMTP id t24csp160377lqh; Thu, 30 May 2024 18:26:47 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCU2r1csbIT7uUoLM6sTOy3GK3KSat5iJl4dpEqC7/upQH0o/nwAWyckbCWDodbjv8UDTSQOvw1WGGahamo8wc/G31qsI5SrVn+URe+4zA== X-Google-Smtp-Source: AGHT+IGdXBJzGE3xm6zJqgW9TmXJeWBuEeAXwrNbJZgcAR+QvDmBkZX9a02GgGjW7rVaEIL/LeG7 X-Received: by 2002:a05:622a:1a18:b0:43a:d064:5118 with SMTP id d75a77b69052e-43ff5519702mr4075281cf.64.1717118807584; Thu, 30 May 2024 18:26:47 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1717118807; cv=pass; d=google.com; s=arc-20160816; b=mpR+CzteXKmoJopF1w9ZLthusJrZLFTPy4W9q2Hu1aFXB6G5ZLnTUKUCJNfZ1R7aw/ ojtpSUfrM2LiUfHoHO0cQMFHAssgc6t4p1pTJ35ZxyqrmU4tICoTCgmwfzNgOsiZw/V9 b75mYvvgjrncmQW5h9JYYX2R6BWuuA/b+vHMw8ODmb+h1jhe2ZiMKuwoeigSJ3QDqR8t 0QOri8ZTRiGS+xMylEZf8L+CmJyELZ9j6CUcvgcZ9LMD539fK52Wc1d6632WXlPIfDjl nOoyRM+IFrMZnd47YRRsTDoTaVTW4YvoVLKUVLsGz3Al3MZ2JMCQMEfkieVwUqdLcMe9 ++5g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=N9x3KJfZAFE+0hlOyg8a3tFKFVoKWKQbYsf4Mx27kGY=; fh=hzpJ6/LTj9onDk9S7ATQEoKyk6LZ5V3jQ1c1xvQtQMU=; b=go+0NcK3ytms+VdvyeSeWWtPhaJJ35QWb1Ru7kMag2QPk7wqCDRnb3zl19MsB3Bd9h tQix+1+zSB0YjFAmAzpHdNKhFEsTolNXdyCZpVSABxGpnDVhto9Ylyt9faLbAgF3IXdM WS/RxoajrtZUVs76/s8pfZ8NJKMkgHj52wRsr6g4mzJULYhJ+FrUf3Jlyn0ECX+cFnYM gPkb3SD3zOKKU87oJiiQHHEUwamAGCBm687n+uOjVSrlHZfFku80RjSXnA661ycQqoRA gGqUzqYyA+8/zgiysOdKnXKBaN+e/QNdnaASBilm1tpRwtjrTcNdM5OMQr4XLc+C+Dq+ oBRQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=XcthxgjL; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-196135-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-196135-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id d75a77b69052e-43ff25ba0e9si9141511cf.783.2024.05.30.18.26.47 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 May 2024 18:26:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-196135-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=XcthxgjL; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-196135-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-196135-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 2DE171C24DF8 for ; Fri, 31 May 2024 01:26:47 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 9556BEAE7; Fri, 31 May 2024 01:26:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="XcthxgjL" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B25926AC0; Fri, 31 May 2024 01:26:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717118793; cv=none; b=tvI8jVg35qesxuZf2PP23o370soX8lsOh2QSCDDtEv9J/o4hf2o/GNUOyKL3i1IcUETSBB8cyUB4eKlmAudCK0RJps6ymuhjhIJdj2kfLHUcwBVeD8R6fIs2JRaOBMtCVlfPkFkpqOIQaMPkj3wv1m5ESB3Y78oi5AglsSKflFw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717118793; c=relaxed/simple; bh=N9x3KJfZAFE+0hlOyg8a3tFKFVoKWKQbYsf4Mx27kGY=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Dq5U/ev2H98Pbht0Qj/WrEtlOe5Hnsw5mblV1zECug+uBHojNtU6UgBsSpEe7o9YtVVOX0I7SQWHHWG8NrZp/2c2vOLzqouJmg1Hvn0+PF7CstQksf4y8/sqCUC1S2hYws8ANybtCkusFsS9wI7BvZtTw7i2MPx1DSXd5ypXeFU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=XcthxgjL; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id AFCA7C2BBFC; Fri, 31 May 2024 01:26:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1717118792; bh=N9x3KJfZAFE+0hlOyg8a3tFKFVoKWKQbYsf4Mx27kGY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=XcthxgjLWbApPwZx3iH/h/KsMGbl1GGmAo31uRRm0gZKT10BlU496elvwjsYuKiby uK1axb0ZiTEGL9QA+xxORzFOyMy2gCdgRq1S1noPyFd5QZWODP3a6DGPHxnx4x81b7 Vtx6G6VRBZNEDquAyTMWBrsDDBUBr3obVnAIUTdowVloj5uxLKKLIVGsXRdOeSRWv6 gI19Q3BmsiQstL1KwzWmhmIzch++1bD3dSA+PwrvucY2JRZmBw3XyJXmFc6aVJHYnL eJYK28h0RiRqMdaMnLpdW1JjqyOmU9tFlf7bXiR0TR06nFZE2w/4Dm8Nofod/pHP17 +kOur6nifFVkg== Date: Thu, 30 May 2024 18:26:30 -0700 From: Jakub Kicinski To: Joe Damato Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, nalramli@fastly.com, "David S. Miller" , Eric Dumazet , Leon Romanovsky , "open list:MELLANOX MLX5 core VPI driver" , Paolo Abeni , Richard Cochran , Saeed Mahameed , Tariq Toukan Subject: Re: [RFC net-next v3 0/2] mlx5: Add netdev-genl queue stats Message-ID: <20240530182630.55139604@kernel.org> In-Reply-To: References: <20240529031628.324117-1-jdamato@fastly.com> <20240530171128.35bd0ee2@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Thu, 30 May 2024 18:07:31 -0700 Joe Damato wrote: > Unless I am missing something, I think mlx5e_fold_sw_stats64 would > need code similar to mlx5e_stats_grp_sw_update_stats_qos and then > rtnl would account for htb stats. Hm, I think you're right. I'm just surprised this could have gone unnoticed for so long. > That said: since it seems the htb numbers are not included right > now, I was proposing adding that in later both to rtnl and > netdev-genl together, hoping that would keep the proposed > simpler/easier to get accepted. SGTM.